From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id BBC881B5BB for ; Wed, 19 Dec 2018 21:31:34 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5C6BD2250C; Wed, 19 Dec 2018 15:31:34 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 19 Dec 2018 15:31:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=QvE0wlrNUarDZ5WGBcd+j8smKYeyxrxb608mfXwmC3Q=; b=nRQG1ttVvnTs JOp4qvJtxQzR9E3SxowVyCDINc4oKsACE0iEsJqAD1J7LMNOFypU1DS0Z1N3kWIF bYf3cqnltDGoDEO/rwKojcHabXDIXF+KydX19doyVMreY1s20JKTLbTaN/7Ysmmd iW0/98UqZbXnB0asxm+wmT01JYkuMU0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=QvE0wlrNUarDZ5WGBcd+j8smKYeyxrxb608mfXwmC 3Q=; b=LRLsV9PmPKGPhJEQdbLceZy1gyc5Z4ZHZ1Fr7PIG4bYxsrLLurXDdAgOM C030t8JYH9dyIoW4cQeXeAxHtA2/qBTXLI6HfXpG3vJfMiwS0tKkZHsAr8t9Gy3d n84kXHlm7QshUsf35EytMRZGdoGTKCsZMV/mFL6Kq5QVdUORo84+MRzOhuYsyz1B cWcGy+neCVIIVM7O0+MduaZE42QwKWtxi99AGaYQtbiTDFNm/NfLeSaOrU6I6omL eqOBxHOqo0/CiBJ5/lZyr3ZzGxphwhnDAzgvtRC/+jkBIgWO5ixt5EgNycfkUeyH LwcbJyiIgAaTGAJr35TS8r30Un8iA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejtddgudefkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkf gjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhn uceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvd dtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6E4FEE4559; Wed, 19 Dec 2018 15:31:33 -0500 (EST) From: Thomas Monjalon To: "Hunt, David" , Liang Ma Cc: dev@dpdk.org, anatoly.burakov@intel.com Date: Wed, 19 Dec 2018 21:31:32 +0100 Message-ID: <1867163.ZjDIE9iX7y@xps> In-Reply-To: <96158e0f-6454-2e5c-f843-cb91221ed304@intel.com> References: <1544786028-10138-1-git-send-email-liang.j.ma@intel.com> <2602247.RKfj1taVKr@xps> <96158e0f-6454-2e5c-f843-cb91221ed304@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] libs/power: add p-state driver compatibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 20:31:35 -0000 19/12/2018 10:09, Hunt, David: > On 19/12/2018 3:18 AM, Thomas Monjalon wrote: > > 14/12/2018 14:11, Liang Ma: > >> Previously, in order to use the power library, it was necessary > >> for the user to disable the intel_pstate driver by adding > >> =E2=80=9Cintel_pstate=3Ddisable=E2=80=9D to the kernel command line fo= r the system, > >> which causes the acpi_cpufreq driver to be loaded in its place. > >> > >> This patch adds the ability for the power library use the intel-pstate > >> driver. > >> > >> It adds a new suite of functions behind the current power library API, > >> and will seamlessly set up the user facing API function pointers to > >> the relevant functions depending on whether the system is running with > >> acpi_cpufreq kernel driver, intel_pstate kernel driver or in a guest, > >> using kvm. The library API and ABI is unchanged. > >> > >> Signed-off-by: Liang Ma > >> > >> Reviewed-by: Anatoly Burakov > >> --- > > Please write a changelog when sending a new version. > > > > Dave, any comment on this patch? >=20 >=20 > Looks good to me. >=20 > Acked-by: David Hunt >=20 >=20 > >> --- /dev/null > >> +++ b/lib/librte_power/power_pstate_cpufreq.c > >> @@ -0,0 +1,770 @@ > >> +/* SPDX-License-Identifier: BSD-3-Clause > >> + * Copyright(c) 2018-2018 Intel Corporation > > Something wrong here :) >=20 > Yes, should simply be "Copyright(c) 2018 Intel Corporation" There is also a compilation error with meson: lib/librte_power/rte_power_empty_poll.h:20:10: fatal error: rte_timer.h: No such file or directory Clearly, some quality checks are missing. I'm afraid we won't have any patch for power library in 19.02.