DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: guohongzhi1@huawei.com
Cc: dev@dpdk.org, olivier.matz@6wind.com,
	konstantin.ananyev@intel.com, jiayu.hu@intel.com,
	ferruh.yigit@intel.com, nicolas.chautru@intel.com,
	cristian.dumitrescu@intel.com, zhoujingbin@huawei.com,
	chenchanghu@huawei.com, jerry.lilijun@huawei.com,
Subject: Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating
Date: Sun, 24 May 2020 17:22:46 +0200	[thread overview]
Message-ID: <1867789.0SWPrSUWr3@thomas> (raw)
In-Reply-To: <20200514012729.23920-1-guohongzhi1@huawei.com>

14/05/2020 03:27, guohongzhi:
> The function of rte_ipv4_cksum for calculating the
> checksum of IPv4 header is incorrect.
> This function will return checksum value like 0xffff.
> This value, however, is considered an illegal checksum on some switches(like Trident3).
> RFC 1624 specifies the IPv4 checksum as follows:
> https://tools.ietf.org/rfc/rfc1624
> Since there is guaranteed to be at least one
>    non-zero field in the IP header, and the checksum field in the
>    protocol header is the complement of the sum, the checksum field can
>    never contain ~(+0), which is -0 (0xFFFF).  It can, however, contain
>    ~(-0), which is +0 (0x0000).
> ---
>  lib/librte_net/rte_ip.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Suggested title:
	net: fix IPv4 checksum

Please send a v2 with your full name and add a Signed-off-by line.
You can check the contributing guidelines:

You need to add these lines from previous reviews:

Fixes: 6006818cfb26 ("net: new checksum functions")
Cc: stable@dpdk.org

Reviewed-By: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>

  parent reply	other threads:[~2020-05-24 15:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14  1:27 guohongzhi
2020-05-14 12:56 ` [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksumcalculating Morten Brørup
2020-05-14 14:19   ` Olivier Matz
2020-05-15  1:04   ` guohongzhi (A)
2020-05-15 10:03     ` Morten Brørup
2020-05-24 15:22 ` Thomas Monjalon [this message]
2020-05-26  9:16 [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating guohongzhi
2020-05-26  9:31 ` Morten Brørup
2020-05-26 10:08 guohongzhi
2020-06-24 11:53 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1867789.0SWPrSUWr3@thomas \
    --to=thomas@monjalon.net \
    --cc=chenchanghu@huawei.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=guohongzhi1@huawei.com \
    --cc=haifeng.lin@huawei.com \
    --cc=jerry.lilijun@huawei.com \
    --cc=jiayu.hu@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=nicolas.chautru@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=zhoujingbin@huawei.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).