Re: [dpdk-dev] [PATCH 4/6] mbuf: fix library version on meson build

Re: [dpdk-dev] [PATCH 4/6] mbuf: fix library version on meson build

[Luca Boccassi]

On Mon, 2018-10-15 at 15:50 +0100, Ferruh Yigit wrote:
> Fixes: d27a6261875d ("mbuf: remove control mbuf")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: olivier.matz@6wind.com
> Cc: Luca Boccassi <bluca@debian.org>
> ---
>  lib/librte_mbuf/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_mbuf/meson.build
> b/lib/librte_mbuf/meson.build
> index 45ffb0db5..94d9c4c96 100644
> --- a/lib/librte_mbuf/meson.build
> +++ b/lib/librte_mbuf/meson.build
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2017 Intel Corporation
>  
> -version = 3
> +version = 4
>  sources = files('rte_mbuf.c', 'rte_mbuf_ptype.c',
> 'rte_mbuf_pool_ops.c')
>  headers = files('rte_mbuf.h', 'rte_mbuf_ptype.h',
> 'rte_mbuf_pool_ops.h')
>  deps += ['mempool']

Acked-by: Luca Boccassi <bluca@debian.org>

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-dev] [PATCH 5/6] ring: add library version to meson build

[Luca Boccassi]

On Mon, 2018-10-15 at 15:50 +0100, Ferruh Yigit wrote:
> Fixes: a3d6026711d0 ("ring: relax alignment constraint on ring
> structure")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: olivier.matz@6wind.com
> Cc: Luca Boccassi <bluca@debian.org>
> ---
>  lib/librte_ring/meson.build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_ring/meson.build
> b/lib/librte_ring/meson.build
> index ca8a435e9..ab8b0b469 100644
> --- a/lib/librte_ring/meson.build
> +++ b/lib/librte_ring/meson.build
> @@ -1,6 +1,7 @@
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2017 Intel Corporation
>  
> +version = 2
>  sources = files('rte_ring.c')
>  headers = files('rte_ring.h',
>  		'rte_ring_c11_mem.h',

Acked-by: Luca Boccassi <bluca@debian.org>

-- 
Kind regards,
Luca Boccassi

[dpdk-dev] [PATCH 1/6] doc: add missing shared library versions to release notes

[Ferruh Yigit]

Fixes: 857ed6c68cf2 ("member: implement main API")
Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: yipeng1.wang@intel.com
Cc: pablo.de.lara.guarch@intel.com
---
 doc/guides/rel_notes/release_18_11.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst
index 1348fab06..e803a800d 100644
--- a/doc/guides/rel_notes/release_18_11.rst
+++ b/doc/guides/rel_notes/release_18_11.rst
@@ -304,6 +304,7 @@ The libraries prepended with a plus sign were incremented in this version.
      librte_cryptodev.so.5
      librte_distributor.so.1
    + librte_eal.so.9
+     librte_efd.so.1
      librte_ethdev.so.10
    + librte_eventdev.so.6
      librte_flow_classify.so.1
@@ -317,6 +318,7 @@ The libraries prepended with a plus sign were incremented in this version.
      librte_latencystats.so.1
      librte_lpm.so.2
      librte_mbuf.so.4
+     librte_member.so.1
      librte_mempool.so.5
      librte_meter.so.2
      librte_metrics.so.1
-- 
2.17.2

[dpdk-dev] [PATCH 2/6] doc: remove shared libs with no API from release notes

[Ferruh Yigit]

The internal shared libraries shouldn't be part of release notes shared
library version section.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: Nipun Gupta <nipun.gupta@nxp.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
---
 doc/guides/rel_notes/release_18_11.rst | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst
index e803a800d..795a7ea3f 100644
--- a/doc/guides/rel_notes/release_18_11.rst
+++ b/doc/guides/rel_notes/release_18_11.rst
@@ -299,7 +299,6 @@ The libraries prepended with a plus sign were incremented in this version.
    + librte_bus_vmbus.so.2
      librte_cfgfile.so.2
      librte_cmdline.so.2
-     librte_common_octeontx.so.1
      librte_compressdev.so.1
      librte_cryptodev.so.5
      librte_distributor.so.1
@@ -330,12 +329,10 @@ The libraries prepended with a plus sign were incremented in this version.
      librte_pmd_bond.so.2
      librte_pmd_i40e.so.2
      librte_pmd_ixgbe.so.2
-     librte_pmd_dpaa2_cmdif.so.1
      librte_pmd_dpaa2_qdma.so.1
      librte_pmd_ring.so.2
      librte_pmd_softnic.so.1
      librte_pmd_vhost.so.2
-   + librte_pmd_netvsc.so.1
      librte_port.so.3
      librte_power.so.1
      librte_rawdev.so.1
-- 
2.17.2

[dpdk-dev] [PATCH 3/6] doc: fix vhost library version in release notes

[Ferruh Yigit]

Fixes: 7c1290374621 ("vhost: rename device ops struct")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Tiwei Bie <tiwei.bie@intel.com>
Cc: Zhihong Wang <zhihong.wang@intel.com>
---
 doc/guides/rel_notes/release_18_11.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst
index 795a7ea3f..03f73484e 100644
--- a/doc/guides/rel_notes/release_18_11.rst
+++ b/doc/guides/rel_notes/release_18_11.rst
@@ -342,7 +342,7 @@ The libraries prepended with a plus sign were incremented in this version.
      librte_security.so.1
      librte_table.so.3
      librte_timer.so.1
-     librte_vhost.so.3
+     librte_vhost.so.4
 
 
 Known Issues
-- 
2.17.2

[dpdk-dev] [PATCH 4/6] mbuf: fix library version on meson build

[Ferruh Yigit]

Fixes: d27a6261875d ("mbuf: remove control mbuf")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: olivier.matz@6wind.com
Cc: Luca Boccassi <bluca@debian.org>
---
 lib/librte_mbuf/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_mbuf/meson.build b/lib/librte_mbuf/meson.build
index 45ffb0db5..94d9c4c96 100644
--- a/lib/librte_mbuf/meson.build
+++ b/lib/librte_mbuf/meson.build
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-version = 3
+version = 4
 sources = files('rte_mbuf.c', 'rte_mbuf_ptype.c', 'rte_mbuf_pool_ops.c')
 headers = files('rte_mbuf.h', 'rte_mbuf_ptype.h', 'rte_mbuf_pool_ops.h')
 deps += ['mempool']
-- 
2.17.2

[dpdk-dev] [PATCH 5/6] ring: add library version to meson build

[Ferruh Yigit]

Fixes: a3d6026711d0 ("ring: relax alignment constraint on ring structure")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: olivier.matz@6wind.com
Cc: Luca Boccassi <bluca@debian.org>
---
 lib/librte_ring/meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_ring/meson.build b/lib/librte_ring/meson.build
index ca8a435e9..ab8b0b469 100644
--- a/lib/librte_ring/meson.build
+++ b/lib/librte_ring/meson.build
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
+version = 2
 sources = files('rte_ring.c')
 headers = files('rte_ring.h',
 		'rte_ring_c11_mem.h',
-- 
2.17.2

[dpdk-dev] [PATCH 6/6] doc: remove internal libs from release notes

[Ferruh Yigit]

These libraries has exported functions but the target of those functions
are not user but other libraries.

The version of these libraries doesn't mean much to the user so can be
dropped from release notes.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Indeed this is more a question, should we keep them or remove them?
---
 doc/guides/rel_notes/release_18_11.rst | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst
index 03f73484e..8b755a7e9 100644
--- a/doc/guides/rel_notes/release_18_11.rst
+++ b/doc/guides/rel_notes/release_18_11.rst
@@ -291,12 +291,6 @@ The libraries prepended with a plus sign were incremented in this version.
      librte_bbdev.so.1
      librte_bitratestats.so.2
      librte_bpf.so.1
-   + librte_bus_dpaa.so.2
-   + librte_bus_fslmc.so.2
-   + librte_bus_ifpga.so.2
-   + librte_bus_pci.so.2
-   + librte_bus_vdev.so.2
-   + librte_bus_vmbus.so.2
      librte_cfgfile.so.2
      librte_cmdline.so.2
      librte_compressdev.so.1
@@ -322,7 +316,6 @@ The libraries prepended with a plus sign were incremented in this version.
      librte_meter.so.2
      librte_metrics.so.1
      librte_net.so.1
-     librte_pci.so.1
      librte_pdump.so.2
      librte_pipeline.so.3
      librte_pmd_bnxt.so.2
-- 
2.17.2

Re: [dpdk-dev] [PATCH 3/6] doc: fix vhost library version in release notes

[Tiwei Bie]

On Mon, Oct 15, 2018 at 03:50:54PM +0100, Ferruh Yigit wrote:
> Fixes: 7c1290374621 ("vhost: rename device ops struct")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Cc: Tiwei Bie <tiwei.bie@intel.com>
> Cc: Zhihong Wang <zhihong.wang@intel.com>
> ---
>  doc/guides/rel_notes/release_18_11.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst
> index 795a7ea3f..03f73484e 100644
> --- a/doc/guides/rel_notes/release_18_11.rst
> +++ b/doc/guides/rel_notes/release_18_11.rst
> @@ -342,7 +342,7 @@ The libraries prepended with a plus sign were incremented in this version.
>       librte_security.so.1
>       librte_table.so.3
>       librte_timer.so.1
> -     librte_vhost.so.3
> +     librte_vhost.so.4
>  
>  
>  Known Issues
> -- 
> 2.17.2
> 

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

Re: [dpdk-dev] [PATCH 6/6] doc: remove internal libs from release notes

[Shreyansh Jain]

On Monday 15 October 2018 08:20 PM, Ferruh Yigit wrote:
> These libraries has exported functions but the target of those functions
> are not user but other libraries.
> 
> The version of these libraries doesn't mean much to the user so can be
> dropped from release notes.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Indeed this is more a question, should we keep them or remove them?

+1 for removing them.
At least for dpaa/fslmc perspective, I don't see any additional benefit 
in release note. These libraries (dpaa/fslmc) are not actually 
'libraries' in true (read, plugability) sense :)

> ---
>   doc/guides/rel_notes/release_18_11.rst | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst
> index 03f73484e..8b755a7e9 100644
> --- a/doc/guides/rel_notes/release_18_11.rst
> +++ b/doc/guides/rel_notes/release_18_11.rst
> @@ -291,12 +291,6 @@ The libraries prepended with a plus sign were incremented in this version.
>        librte_bbdev.so.1
>        librte_bitratestats.so.2
>        librte_bpf.so.1
> -   + librte_bus_dpaa.so.2
> -   + librte_bus_fslmc.so.2
> -   + librte_bus_ifpga.so.2
> -   + librte_bus_pci.so.2
> -   + librte_bus_vdev.so.2
> -   + librte_bus_vmbus.so.2
>        librte_cfgfile.so.2
>        librte_cmdline.so.2
>        librte_compressdev.so.1
> @@ -322,7 +316,6 @@ The libraries prepended with a plus sign were incremented in this version.
>        librte_meter.so.2
>        librte_metrics.so.1
>        librte_net.so.1
> -     librte_pci.so.1
>        librte_pdump.so.2
>        librte_pipeline.so.3
>        librte_pmd_bnxt.so.2
> 

Re: [dpdk-dev] [PATCH 2/6] doc: remove shared libs with no API from release notes

[Jerin Jacob]

-----Original Message-----
> Date: Mon, 15 Oct 2018 15:50:53 +0100
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> To: John McNamara <john.mcnamara@intel.com>, Marko Kovacevic
>  <marko.kovacevic@intel.com>
> CC: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
>  yipeng1.wang@intel.com, pablo.de.lara.guarch@intel.com, Jerin Jacob
>  <jerin.jacob@caviumnetworks.com>, Nipun Gupta <nipun.gupta@nxp.com>,
>  Stephen Hemminger <sthemmin@microsoft.com>, "K. Y. Srinivasan"
>  <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>
> Subject: [PATCH 2/6] doc: remove shared libs with no API from release notes
> X-Mailer: git-send-email 2.17.2
> 
> External Email
> 
> The internal shared libraries shouldn't be part of release notes shared
> library version section.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Cc: Nipun Gupta <nipun.gupta@nxp.com>
> Cc: Stephen Hemminger <sthemmin@microsoft.com>
> Cc: "K. Y. Srinivasan" <kys@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> ---
>  doc/guides/rel_notes/release_18_11.rst | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst
> index e803a800d..795a7ea3f 100644
> --- a/doc/guides/rel_notes/release_18_11.rst
> +++ b/doc/guides/rel_notes/release_18_11.rst
> @@ -299,7 +299,6 @@ The libraries prepended with a plus sign were incremented in this version.
>     + librte_bus_vmbus.so.2
>       librte_cfgfile.so.2
>       librte_cmdline.so.2
> -     librte_common_octeontx.so.1

For octeontx change,

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Re: [dpdk-dev] [PATCH 6/6] doc: remove internal libs from release notes

[Thomas Monjalon]

16/10/2018 13:52, Shreyansh Jain:
> On Monday 15 October 2018 08:20 PM, Ferruh Yigit wrote:
> > These libraries has exported functions but the target of those functions
> > are not user but other libraries.
> > 
> > The version of these libraries doesn't mean much to the user so can be
> > dropped from release notes.
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> > Indeed this is more a question, should we keep them or remove them?
> 
> +1 for removing them.
> At least for dpaa/fslmc perspective, I don't see any additional benefit 
> in release note. These libraries (dpaa/fslmc) are not actually 
> 'libraries' in true (read, plugability) sense :)

> > --- a/doc/guides/rel_notes/release_18_11.rst
> > +++ b/doc/guides/rel_notes/release_18_11.rst
> > -   + librte_bus_dpaa.so.2
> > -   + librte_bus_fslmc.so.2
> > -   + librte_bus_ifpga.so.2
> > -   + librte_bus_pci.so.2
> > -   + librte_bus_vdev.so.2
> > -   + librte_bus_vmbus.so.2

The ABI of bus libraries is important if you want to plug a PMD
into an older DPDK: if bus ABI has changed, you cannot.
I am for keeping them.

> > -     librte_pci.so.1

This is a true library!

Re: [dpdk-dev] [PATCH 1/6] doc: add missing shared library versions to release notes

[Thomas Monjalon]

15/10/2018 16:50, Ferruh Yigit:
> Fixes: 857ed6c68cf2 ("member: implement main API")
> Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Series applied without patch 6 (rejected), thanks for the good clean-up.