From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 380FD4235E; Wed, 11 Oct 2023 10:03:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF005402F1; Wed, 11 Oct 2023 10:03:11 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id C926C402A2 for ; Wed, 11 Oct 2023 10:03:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 8B539320154E; Wed, 11 Oct 2023 04:03:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 11 Oct 2023 04:03:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1697011389; x=1697097789; bh=pz1nD+akmyyIDiknfRIIuZFXKyaCWXKEz1T HINjumjs=; b=hV2Wq11ik+l6TL166Ou5RPPkb9XL94/hhgJRKddAUOPt44l6oSH qSYOj7VhAPoxLH/4Pv+yBm6hVzqMlWrWChBK+YRT/ItS4QQyZG2wn2dmvvkDZujT qTd+QjclAhA9SDprjWl2sysmEV5F52BO+3ka2DFKitjW2rsjGg7G/J++JEtkl3bd zYuj89mXT86hgfRKFntKRzUF76MMn4/wHcfhJyr68qXGAEyVBhdYmJkTDBZtVcGz THIyDuZJEHzyeeh6hviv1ylb+IkM3p/15WeLc4oC6fNHgcNZDJ2plwRYMqaynjon z2S8tZsOoqAKP2oqOHmeo1nzM1bUrjXuORA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1697011389; x=1697097789; bh=pz1nD+akmyyIDiknfRIIuZFXKyaCWXKEz1T HINjumjs=; b=VjkCcPTOHqHAK/KijbzWxMOb1cs9aZM6ehAeLcJpsJi5Oxlgtm8 4QLOQnLvx46bNRlKob/nvKtU7kcVxQplOjRG6+1X/QxIHacG04yGVbOYi34NKg4l eTJ39KaD9uUjH+Wi7flMSBjnllJinQm2C0Ka5dzKpyqpAbCtBkbzYlLW99+ln1qh ZNJL7z4ChdQKGUCjFcrE+yXMA/Mxb4YnbRhgJFfzAbF7uJ3C4TQpKsm9rc1b2uFU PMhl6Ggw11Uz0lkZ0+W8Xyhn/UqCjo2e18MJzhLO60P3QzhgtvMiIAP9Z7S+q1xV poM+IA8n8wU8sUa4gmmBBrSSgArBMIFoa4Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrheejgdekhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedviedu vdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 11 Oct 2023 04:03:08 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org Subject: Re: [PATCH] doc: remove confusing command to send patch Date: Wed, 11 Oct 2023 10:03:07 +0200 Message-ID: <1868656.CQOukoFCf9@thomas> In-Reply-To: References: <20231010162635.755975-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 11/10/2023 09:30, David Marchand: > On Tue, Oct 10, 2023 at 6:26=E2=80=AFPM Thomas Monjalon wrote: > > > > In the contributor guide, it was said that no need to Cc maintainers > > for new additions, probably for new directories not having a maintainer. > > There is no harm, and it is a good habit, to always Cc maintainers. > > > > Remove this case as it can mislead to not Cc maintainers when needed. > > > > Signed-off-by: Thomas Monjalon >=20 > I agree Cc: maintainers should be the default / recommended way of > sending patches. >=20 > Just to convince myself, adding some meson skeleton for a "plop" > library, adding an entry in the release notes and hooking in > lib/meson.build: > $ git show --stat > doc/guides/rel_notes/release_23_11.rst | 4 ++++ > lib/meson.build | 1 + > lib/plop/meson.build | 2 ++ >=20 > $ ./devtools/get-maintainer.sh 0001-new-awesome-library.patch >=20 > In this case, it translates to an empty To: list if you follow the > example command line: > git send-email --to-cmd ./devtools/get-maintainer.sh --cc > dev@dpdk.org 000*.patch >=20 > We could add a default list of recipients if no maintainer is found by > the script. > And the next question is who should be in that list.. Or we can send to dev@dpdk.org, Cc maintainers. This is what I do: git send-email --to dev@dpdk.org --cc-cmd devtools/get-maintainer.sh