From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f180.google.com (mail-we0-f180.google.com [74.125.82.180]) by dpdk.org (Postfix) with ESMTP id 815CF593A for ; Thu, 22 May 2014 14:28:46 +0200 (CEST) Received: by mail-we0-f180.google.com with SMTP id t61so3426537wes.11 for ; Thu, 22 May 2014 05:28:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=tjQWaR/agmeuzjT6ky5tsjR1VfORHkapnGzsT0lh3ks=; b=FHlv7b8+YOBOX88nyBQFCBGEEB74RHGjygDplC1SNdDRqEImTQzf2UmCjvkoQPwJyy mappKVrLl0ZhJ4O9xfvL8288OXPPpjcsk8efTzm5QRAkVpRWBtiuzykPGkYqLlqSvAOy r6EVtBIM0QZ1vzEttOq26mSB2HiPD9P8Qy0z4Z093fYJijcjrZ415kY1CQtZA4P7Nh57 ymF2sajo8/gUH5bdKQf+mR2spaL5ev0AQs5J8CQEVE4c09kDAM3iXTde9GyYDbNPIEUn HCekKnGeFLnZKhbFB+nE0N7vm66wbVSYLvbsZJZnWhUtsWM6aDqFMyaKXTwYptAYFJcw u0sQ== X-Gm-Message-State: ALoCoQmK9N1PJYgEJ0dpsOXvBwdLKJZ2Td7zKKAcXwxW0K6KhknU7irrbbLMFb74jlPtWxRupUaF X-Received: by 10.180.13.162 with SMTP id i2mr16292347wic.44.1400761735786; Thu, 22 May 2014 05:28:55 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id l4sm147316wiy.0.2014.05.22.05.28.54 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 May 2014 05:28:54 -0700 (PDT) From: Thomas Monjalon To: "Burakov, Anatoly" Date: Thu, 22 May 2014 14:28:51 +0200 Message-ID: <1871082.JnAAVjVYKa@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: References: <6426409.afQ7rpamsg@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 08/16] Add support for mapping devices through VFIO. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 May 2014 12:28:46 -0000 2014-05-22 12:06, Burakov, Anatoly: > > We should discuss a way to request igb_uio or VFIO binding of a device. > > Why? The device can either be bound to VFIO or igb_uio. So unless you want > binding code in DPDK EAL (to avoid which the > pci_unbind/igb_uio_bind/dpdk_bind script was created in the first place), I > see no point in that. The dpdk_bind script already does that (you bind > either to igb_uio or to vfio-pci). Yes, in some environments, it could be easier to be able to configure devices directly on application command line instead of having to call a python script. I think having a clear and extendable syntax to configure devices in command line could greatly improve usability. But it can be another step. > > This whole socket communication deserves a separated patch with protocol > > description. > > Agreed, I'll break it up and provide a more detailed explanation. Thanks. > > By the way, I'm not a big fan of the suffix "_socket" which can be > > misleading. But I have no other good naming idea. > > Would _mp_socket do? What do you think of _mp_sync or _mp_conf? Usage of the socket is to synchronize VFIO config between processes, right? > > So we have another thread to manage. > > I don't see where it is spawned? > > In rte_eal_pci_init(). Oh yes. Do you think you could merge the thread spawning in the patch adding it? > > You are defining some variables in a .h file. I think it is a problem. > > Well, they need to be shared between several .c files. So you should use an "extern" trick in order to have only one instance of the variables. But I think it's not a good practice. You probably need to group functions using these variables in one .c file. Or do I miss something? > > Here are some other relevant errors from checkpatch.pl: > Thanks, I'll fix those. Thank you -- Thomas