From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9636A1B023 for ; Wed, 17 Jan 2018 18:34:00 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 37E7620B97; Wed, 17 Jan 2018 12:34:00 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 17 Jan 2018 12:34:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=b6p2R9gJvKVDNEE8ET6fJK3It7 dJDy3IdBOWHAFbQ9g=; b=MqMlr48RVRPfzF8jiEuQVXMEo2xgSePTOZdjq87XwR txRkT7azrP3ZMSrLMsIx5b4q7igs9lhnLXKVKoLqvbfTRPRKykbjg+MDHB5muXkk xFTvXpabdZge36cAKcIon2pucsIPId6zKFbw0By3o4Sy2dvw0VcgvsL+cWkuXVvu E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=b6p2R9 gJvKVDNEE8ET6fJK3It7dJDy3IdBOWHAFbQ9g=; b=qjvF2WEaNpYAKpt9NgjhSI Pt30ZDIhnlGP8wtTl8/xZHpkplh/ap+ctpUctzk3l4sW+JEjJIM/FWJLYZ1mvXpF sWnxyk6oo9BPZ/jH0MZvl8Ntc4CXHydncqk9l9mdIHmvM0u/La+t9JgU+iXFAZlT ZMGIQY/ZQWhL+IlLHzLFBPSIYB9OkDqW5a+N1FmjCBVT3/XRi64838jR8HwkXZ6h w0qd7WTZXnm3d6i0fmJQvwW5M3E7dP5jIWeA1sbkj7faBv9z4rh2tou1karpxkRE tdEVSm1cH8qY2PhtRQBA5Nw6gYTJ4hCs8HEJ/6b5iZ/fESdgeV8rfJJD31vve4tg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B592F24707; Wed, 17 Jan 2018 12:33:59 -0500 (EST) From: Thomas Monjalon To: Andrew Rybchenko , Ivan Malov Cc: dev@dpdk.org, Ferruh Yigit , Shahaf Shuler Date: Wed, 17 Jan 2018 18:33:25 +0100 Message-ID: <1871861.OTzHAPg5Oj@xps> In-Reply-To: <1515658359-1041-2-git-send-email-arybchenko@solarflare.com> References: <1515658359-1041-1-git-send-email-arybchenko@solarflare.com> <1515658359-1041-2-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/6] ethdev: add a function to look up Rx offload names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 17:34:00 -0000 Hi, 2 comments below 11/01/2018 09:12, Andrew Rybchenko: > From: Ivan Malov > > +#define RTE_RX_OFFLOAD_BIT2STR(_name) \ > + { DEV_RX_OFFLOAD_##_name, #_name } > + > +static const struct { > + uint64_t offload; > + const char *name; > +} rte_rx_offload_names[] = { > + RTE_RX_OFFLOAD_BIT2STR(VLAN_STRIP), > + RTE_RX_OFFLOAD_BIT2STR(IPV4_CKSUM), > + RTE_RX_OFFLOAD_BIT2STR(UDP_CKSUM), > + RTE_RX_OFFLOAD_BIT2STR(TCP_CKSUM), > + RTE_RX_OFFLOAD_BIT2STR(TCP_LRO), > + RTE_RX_OFFLOAD_BIT2STR(QINQ_STRIP), > + RTE_RX_OFFLOAD_BIT2STR(OUTER_IPV4_CKSUM), > + RTE_RX_OFFLOAD_BIT2STR(MACSEC_STRIP), > + RTE_RX_OFFLOAD_BIT2STR(HEADER_SPLIT), > + RTE_RX_OFFLOAD_BIT2STR(VLAN_FILTER), > + RTE_RX_OFFLOAD_BIT2STR(VLAN_EXTEND), > + RTE_RX_OFFLOAD_BIT2STR(JUMBO_FRAME), > + RTE_RX_OFFLOAD_BIT2STR(CRC_STRIP), > + RTE_RX_OFFLOAD_BIT2STR(SCATTER), > + RTE_RX_OFFLOAD_BIT2STR(TIMESTAMP), > + RTE_RX_OFFLOAD_BIT2STR(SECURITY), > +}; > + > +#undef RTE_RX_OFFLOAD_BIT2STR Why this undef? > --- a/lib/librte_ether/rte_ethdev_version.map > +++ b/lib/librte_ether/rte_ethdev_version.map > @@ -198,6 +198,12 @@ DPDK_17.11 { > > } DPDK_17.08; > > +DPDK_18.02 { > + global: > + > + rte_eth_dev_rx_offload_name; > +} DPDK_17.11; New functions should be experimental. > EXPERIMENTAL { > global: