From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id A204E9239 for ; Tue, 26 Jan 2016 16:24:39 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id l65so108680636wmf.1 for ; Tue, 26 Jan 2016 07:24:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=Jd0xcpsB1vh1vHlSdMBiJOnvZgyaiztSznpADjgdLbg=; b=03vXRBL3XQxcqlLgJONBmFJKU00iOK7wKVwPefmFsFxUUrTttkI752Qgr1R7X8lYqa MwhgPrh9I6181cyMl/i2e5DLIEIXPMVRVbLX7CQLogM+AcE4y4WcZMZE18SeM3NaeHJl tfhhgDRsbXKeSrtZT3rLr1lpG774TzUgsMw7c7JVdwK3UQD606YlG8Xv47TlaBTqZcsA PjJVIKRvab3/xhnENw0h0mIyW3G6OJjpTFYg1BvE1Q3RQ77gEKWE3wpxxR0Du8C9jUAc uBFnWVPGI9mu/3fiS0WkWdLcLzihNkdJs/HMhELfsfBx36cBIsKP+3Uczr9sHzCYhsfw B7Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Jd0xcpsB1vh1vHlSdMBiJOnvZgyaiztSznpADjgdLbg=; b=iuKYb9z+VVMbS6dMdsN0ZBetOjNmCvmYSQ2hyCMYuNjG2GXjxCaJhH1J2elXU7SGLc IvAcqB9sQ/32uW1XSeJLvbozPVSm52gW4BEgxeQQLn3LfbNHqsTOeC6GxJCJOkY41bYw WwXRWJ9ohyZt5z/Ug3AechCU0gV6X/KdhVyzOC8wCb0HXn//BRxfst8K04lj/2QkE6Di IcisIlN4NxjS4nXGPYeXHwuB3AglxLGNtKOY3aURN1kK2JnYkNyAp6TFu5KpkeoV0fVj fWmHvxrPUL1RNbp3faIIgqG03D5TREFSyXxrCDnKs9nKPRHLopA+/djWbQoxhHuQMAZV hxUA== X-Gm-Message-State: AG10YOSMhSgXKobwhULGBwo0ChOi7EyNbug7Szh+i6vzJc7ZPNMyPdSauFiDSYQ7OPUTbxnk X-Received: by 10.28.19.76 with SMTP id 73mr25875366wmt.24.1453821879421; Tue, 26 Jan 2016 07:24:39 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id x6sm1910396wje.38.2016.01.26.07.24.38 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 26 Jan 2016 07:24:38 -0800 (PST) From: Thomas Monjalon To: krytarowski@caviumnetworks.com Date: Tue, 26 Jan 2016 16:23:31 +0100 Message-ID: <1872674.ygjbT6ghrC@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1453283317-1078-1-git-send-email-krytarowski@caviumnetworks.com> References: <1449667198-27218-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com> <1453283317-1078-1-git-send-email-krytarowski@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 1/2] tools: Add support for handling built-in kernel modules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2016 15:24:39 -0000 2016-01-20 10:48, krytarowski@caviumnetworks.com: > --- a/tools/dpdk_nic_bind.py > +++ b/tools/dpdk_nic_bind.py > - for line in loaded_mods: > + try: > + # Get list of syfs modules, some of them might be builtin and merge with mods Please could you explain this comment? Is it remaining from previous versions of the patch? [...] > + # special case for vfio_pci (module is named vfio-pci, > + # but its .ko is named vfio_pci) Isn't it common to have dash replaced by underscore for kernel modules?