From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>,
t.yoshimura8869@gmail.com
Subject: Re: [dpdk-dev] [PATCH] vfio: revert retry logic for MSI-X BAR mapping
Date: Wed, 01 Aug 2018 17:52:36 +0200 [thread overview]
Message-ID: <1874201.M8Nbpmf09E@xps> (raw)
In-Reply-To: <20180731034740.GA3371@jerin>
> > This reverts commit d4774a568ba0a5923229974a002972c83eb04570.
> >
> > The patch is incomplete because kernel 4.16+, while being capable
> > of mapping MSI-X BARs, will also report if such a capability is
> > available. Without checking this capability, gratuitous errors
> > are displayed on kernels <4.16 while VFIO is attempting to mmap
> > MSI-X BAR and fails, which can be confusing to the user.
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Applied, thanks
prev parent reply other threads:[~2018-08-01 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 10:59 Anatoly Burakov
2018-07-31 3:47 ` Jerin Jacob
2018-08-01 15:52 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1874201.M8Nbpmf09E@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=t.yoshimura8869@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).