From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A43C211A4 for ; Tue, 2 Apr 2019 01:25:55 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 46C5D2225D; Mon, 1 Apr 2019 19:25:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 01 Apr 2019 19:25:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=g3aLzXaijlP06v72XTFZoFYVKXZCQuJ6oXU1emtpxEo=; b=lnLpVH1yqsl9 Wu+wihctnAu6VtfNS9o8g79rYFxXru+yIrSr9qWWpghV3feFY+YfGCuo00VvTs/R D1s/JtICcktCVhI+gPt7pm2G0koo6Xjw/k/C0ZTwEW6yvmSLNytnqHa+v4v45WGG EWERlxWyI+r0Z5isf5/tgoBJ/oTC1ww= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=g3aLzXaijlP06v72XTFZoFYVKXZCQuJ6oXU1emtpx Eo=; b=vadjjwXbGFm2TI8fVnbEsqP1oc1MpZXHWllLE3G8TX+g9r1S2d7D9iM/p tfMclkeSbyjNHlFP1UTYs5nZmFo7WqJJ9R568E3A8W/csTrVZ5VyiB6WfD915AYB CxnnSvdrY4IMCwNxYY7fn8gareSEJU6JvX9WNJ4+1dE4SMWBrVZ0lT0MoMhblTcA Ws/MThI6V26GTeUHx7rltuP6UhH/PmiPG+a8ThNGqVt2nlKQhDTPcB14yZkA7siy yQIxowOnoKih1limRfO9//8+IUvxqFmzHHplMZJ5mdhT3pA7fRiyN5R/InfE3dUt urLO7enJdeK9FGlIu5mdm+7ItziTQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleehgddvtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 53A86E408B; Mon, 1 Apr 2019 19:25:52 -0400 (EDT) From: Thomas Monjalon To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com, harini.ramakrishnan@microsoft.com Date: Tue, 02 Apr 2019 01:25:51 +0200 Message-ID: <1874669.yI0RQQHDzX@xps> In-Reply-To: <20190328232451.16988-9-anand.rawat@intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328232451.16988-1-anand.rawat@intel.com> <20190328232451.16988-9-anand.rawat@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 8/8] build: meson changes to build on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2019 23:25:55 -0000 29/03/2019 00:24, Anand Rawat: > Added meson workarounds to build helloworld on windows. > Windows currently only supports kvargs and eal libraries. > This change restricts the build flow to supported libraries > only. [...] > --- a/app/meson.build > +++ b/app/meson.build > @@ -1,5 +1,9 @@ > # SPDX-License-Identifier: BSD-3-Clause > -# Copyright(c) 2017 Intel Corporation > +# Copyright(c) 2017-2019 Intel Corporation > + > +if host_machine.system() == 'windows' > + subdir_done() > +endif Not sure this change deserves a copyright update :) > --- a/examples/meson.build > +++ b/examples/meson.build > - deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline'] Please keep this line intact. > + if host_machine.system() != 'windows' > + deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline'] > + else > + deps = ['eal'] # only supported lib on windows currently > + endif You could override deps for Windows only. Other workarounds look reasonnable. Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EEDECA0679 for ; Tue, 2 Apr 2019 01:25:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BB54837A8; Tue, 2 Apr 2019 01:25:56 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A43C211A4 for ; Tue, 2 Apr 2019 01:25:55 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 46C5D2225D; Mon, 1 Apr 2019 19:25:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 01 Apr 2019 19:25:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=g3aLzXaijlP06v72XTFZoFYVKXZCQuJ6oXU1emtpxEo=; b=lnLpVH1yqsl9 Wu+wihctnAu6VtfNS9o8g79rYFxXru+yIrSr9qWWpghV3feFY+YfGCuo00VvTs/R D1s/JtICcktCVhI+gPt7pm2G0koo6Xjw/k/C0ZTwEW6yvmSLNytnqHa+v4v45WGG EWERlxWyI+r0Z5isf5/tgoBJ/oTC1ww= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=g3aLzXaijlP06v72XTFZoFYVKXZCQuJ6oXU1emtpx Eo=; b=vadjjwXbGFm2TI8fVnbEsqP1oc1MpZXHWllLE3G8TX+g9r1S2d7D9iM/p tfMclkeSbyjNHlFP1UTYs5nZmFo7WqJJ9R568E3A8W/csTrVZ5VyiB6WfD915AYB CxnnSvdrY4IMCwNxYY7fn8gareSEJU6JvX9WNJ4+1dE4SMWBrVZ0lT0MoMhblTcA Ws/MThI6V26GTeUHx7rltuP6UhH/PmiPG+a8ThNGqVt2nlKQhDTPcB14yZkA7siy yQIxowOnoKih1limRfO9//8+IUvxqFmzHHplMZJ5mdhT3pA7fRiyN5R/InfE3dUt urLO7enJdeK9FGlIu5mdm+7ItziTQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleehgddvtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 53A86E408B; Mon, 1 Apr 2019 19:25:52 -0400 (EDT) From: Thomas Monjalon To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com, harini.ramakrishnan@microsoft.com Date: Tue, 02 Apr 2019 01:25:51 +0200 Message-ID: <1874669.yI0RQQHDzX@xps> In-Reply-To: <20190328232451.16988-9-anand.rawat@intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328232451.16988-1-anand.rawat@intel.com> <20190328232451.16988-9-anand.rawat@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v7 8/8] build: meson changes to build on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190401232551.QQ1navxTCRU5Phm1JWS-h1CUpSCEdhcLqv_yRGUZ2hI@z> 29/03/2019 00:24, Anand Rawat: > Added meson workarounds to build helloworld on windows. > Windows currently only supports kvargs and eal libraries. > This change restricts the build flow to supported libraries > only. [...] > --- a/app/meson.build > +++ b/app/meson.build > @@ -1,5 +1,9 @@ > # SPDX-License-Identifier: BSD-3-Clause > -# Copyright(c) 2017 Intel Corporation > +# Copyright(c) 2017-2019 Intel Corporation > + > +if host_machine.system() == 'windows' > + subdir_done() > +endif Not sure this change deserves a copyright update :) > --- a/examples/meson.build > +++ b/examples/meson.build > - deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline'] Please keep this line intact. > + if host_machine.system() != 'windows' > + deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline'] > + else > + deps = ['eal'] # only supported lib on windows currently > + endif You could override deps for Windows only. Other workarounds look reasonnable. Thanks