From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E54FE58D1 for ; Sun, 9 Jul 2017 16:19:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 71D6D2091B; Sun, 9 Jul 2017 10:19:06 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sun, 09 Jul 2017 10:19:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=DH0ngZLLKnwIi3t gkqsdcN6bXwgAAgo3U535ioS+m+U=; b=Ku68QPKkSQO/Qib5uTiVOIE90PscJON LcINjPAVP1EW5pdkEOZqIjUk+X3fAzJ1Owh0dbsOoMuGmH7JmOW/PzZ8s3+D7ZO8 JIkAkF50C66y4zariupB4wqMPqr4Hfmm4SU3/01VZMOi6I9dgI4DmTNwb2PI73aR 7y+H6cX+drGA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=DH0ngZLLKnwIi3tgkqsdcN6bXwgAAgo3U535ioS+m+U=; b=kQLpOhnt iFN1iUO3WbOGdFTD+vZfyYzQQiXbx7DfQjvAp6hxe7ka77/F9IICcqObVXP5XWpb xXID32AQzwPOgaKwqinjwKLsKImzHhhjCGrp7yQhuK5ZjgWPGYt/SSAy3f24HZNX rxEo9VqKK/6WMgClAcxrVsODw4Ug8/20ZkswHvwjHjrIyJTMt84PU+CqI7RgJcGi /qfLBFvwXPvNPQO8VcuHToDoUNQX1v8dygI3O6qFaPVLk9fJGGVxTEEx8ItZlfHr XfnRu/9IekUScQYrKyK/k3bvGxljiLc8+H/2RLj2CfOfiw9VK5cEp0zumd/hGHMF HPrJ9hiFf7wMrQ== X-ME-Sender: X-Sasl-enc: +qwTzC7zcKakge2AEl8gGsU23ixp1omBPF8J0MvKViut 1499609946 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 25C637E568; Sun, 9 Jul 2017 10:19:06 -0400 (EDT) From: Thomas Monjalon To: Jan Blunck Cc: dev@dpdk.org, Gaetan Rivet , Shreyansh Jain , Stephen Hemminger , Bruce Richardson Date: Sun, 09 Jul 2017 16:19:05 +0200 Message-ID: <1881782.F5Es4knhFG@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/9] fix hotplug API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Jul 2017 14:19:07 -0000 09/07/2017 12:38, Jan Blunck: > On Sat, Jul 8, 2017 at 9:45 PM, Gaetan Rivet wrote: > > Sending those fixes as separate patches as they stand on their own. > > This series improves usability of the hotplug API and fixes a few issues > > with existing implementations. > > > > Interesting that you send this series as fixes. From what I can tell > this is a collection of changes that you have proposed before and I > have commented on and requested changes for. But I don't see that they > have been addressed at all: > > - you still concatenate the bus and device name just to pass it down > to the buses and parse it into its components again > - you still delegate the devargs parsing to the buses > > Please fix this issues. If you really want to return a device handle > from the hotplug API please present the use-case and in which cases > this solves a real-world problem. Please Jan, could you check in the 9 patches of this series which ones are OK for you? Thank you