From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D29BA0521; Tue, 3 Nov 2020 17:04:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B35D0C31B; Tue, 3 Nov 2020 17:04:07 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 5E498BE4B for ; Tue, 3 Nov 2020 17:04:06 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id B14BF580A60; Tue, 3 Nov 2020 11:04:04 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 03 Nov 2020 11:04:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= Gb+gI3Kgo0gORdMn34tsg+C+PTzb7WpWdGQlVODL5TY=; b=b3HlPO31uDqJzlNE y3GxQGbIvPyq4loPesi22XhxQ9jAeDSeiywz9lrzAOIFfaKgPhAQtbidPywXDQAz bjQf+JF8lNadREGVAAYJSDlhtEFOy9k7VqWpvt7VsWRk/ve+hM1BcpDWrzVzSdlK hUWC8skRIxwPwZULeGGuu+fJietcMUEN6RNNaTkhCSvKPZWqg8beEHaG85KEX73Q +qm7QSz3AwB5+ig5yoe1oF1vhDYUd15xGIyh+fSpWSuUkqMSnjnINCtm5e19P8+8 KNbXHmL7YWPqp8ZdEvkeqwM59CsyE+JJAMllJlDFJ+GQZU6D+gAutLDVys0WulRA e8+P0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Gb+gI3Kgo0gORdMn34tsg+C+PTzb7WpWdGQlVODL5 TY=; b=Vb7UMVwhmU4l7SRysy/0UyRLBucEioYgwSoXnJgZ1D5BCqI4jcADeJ8ij /M38n01WkO4hlyL1PaEASzR0tpdXFks+kKoyqq3LSc29vFd/in+dF7/4wBKYXUKA Hjlo818hvubkxUYH49dK1vCSoyarYJRNp24/AmimPvrL9+XL5XaBfDPJwTh8IfvO pKBsSCM5PZ0rew2rCDSmVm45JPC8HjJ/wnVCI4yCJtzndXcXqk0UCPpmd7RTHdA+ VvQRJ3rA+KPC8Orq+7/2xWGNEbMi1LHDkJoDeSvbq+oYDOF5/38ZUuKYgHjnzxAt 6fCj7SMDkzKDrsUtT/HBhW22C9uKw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtfedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DFDEA306467E; Tue, 3 Nov 2020 11:04:02 -0500 (EST) From: Thomas Monjalon To: "Gujjar, Abhinandan S" Cc: Akhil Goyal , "dev@dpdk.org" , "Doherty, Declan" , "Honnappa.Nagarahalli@arm.com" , "Ananyev, Konstantin" , Hemant Agrawal , "Vangati, Narender" , "jerinj@marvell.com" , john.mcnamara@intel.com, david.marchand@redhat.com, ferruh.yigit@intel.com Date: Tue, 03 Nov 2020 17:04:01 +0100 Message-ID: <1882047.WhnCstt3cK@thomas> In-Reply-To: References: <1603926611-19086-1-git-send-email-abhinandan.gujjar@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/11/2020 08:44, Gujjar, Abhinandan S: > From: Akhil Goyal > > As I suggested 2 times that there are documentation issues. Haven't seen a > > version To fix that. Please check it at your end and try fixing the timing of your > > system so that CI Can pick it for compilation. > > As far as I remember, I have pulled in all the comments from you for the previous patch. > > > > > I understand that we work in same time zone, getting feedback from you > > > in the mid night will not help me/you to pull this patch in. > > > A quick response will enable me to prepare patch set quickly and send it > > across. > > > > I am not dedicatedly working on your patchset. I will work as per my priorities. > > It is same for me. End of the day, we have mutually agreed to get this feature in. > > > Had it been a CI pass for compilation for both documentation and code, it > > would have been applied last night. I could remove those extra spaces, but > > there are other issues also as the newly added APIs are not visible in html files > > generated. Please ensure that there are no issues in doxygen build issues and > > should be able to see the newly added APIs in html guides. > > This is the kind of information I was looking for, which was not available in your > previous patch. If this info had been available quickly, I would have prepared next patchset. It seems you didn't do all the checks you are required to do. Please be kind with Akhil who is working hard for the community. If you want to accelerate the process, help by reviewing other patches. > Anyway, I will post the next patch set. This is too late. We are not supposed to add new API in -rc2, and for sure not after -rc2 deadline. > > > > And please note, do not top post your comments. It becomes difficult to read it > > in Archives. > > Ok Yes please do not top post, use --in-reply-to to gather all versions in the same thread, and fix the clock of your machine.