From: Thomas Monjalon <thomas@monjalon.net> To: Andrey Vesnovaty <andreyv@nvidia.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, jerinj@marvell.com, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "stephen@networkplumber.org" <stephen@networkplumber.org>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, Ori Kam <orika@nvidia.com>, Slava Ovsiienko <viacheslavo@nvidia.com>, "andrey.vesnovaty@gmail.com" <andrey.vesnovaty@gmail.com>, "ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>, "samik.gupta@broadcom.com" <samik.gupta@broadcom.com> Subject: Re: [dpdk-dev] [PATCH v7 1/2] ethdev: add flow shared action API Date: Wed, 14 Oct 2020 09:22:35 +0200 Message-ID: <1884452.bCSgJj8pPL@thomas> (raw) In-Reply-To: <d3a63fbe-7373-bfd7-b166-12c56fe782c6@oktetlabs.ru> 14/10/2020 08:49, Andrew Rybchenko: > On 10/13/20 11:06 PM, Andrey Vesnovaty wrote: > > From: Andrew Rybchenko <Andrew.Rybchenko@oktetlabs.ru> > >>> Shared action create/use/destroy > >>> === > >>> Shared action may be reused by some or none flow rules at any given > >>> moment, i.e. shared action resides outside of the context of any flow. > >>> Shared action represent HW resources/objects used for action offloading > >>> implementation. > >>> API for shared action create (see `rte_flow_shared_action_create()`): > >>> - should allocate HW resources and make related initializations required > >>> for shared action implementation. > >>> - make necessary preparations to maintain shared access to > >>> the action resources, configuration and state. > >>> API for shared action destroy (see `rte_flow_shared_action_destroy()`) > >>> should release HW resources and make related cleanups required for shared > >>> action implementation. > >>> > >>> In order to share some flow action reuse the handle of type > >>> `struct rte_flow_shared_action` returned by > >>> rte_flow_shared_action_create() as a `conf` field of > >>> `struct rte_flow_action` (see "example" section). > >>> > >>> If some shared action not used by any flow rule all resources allocated > >>> by the shared action can be released by rte_flow_shared_action_destroy() > >>> (see "example" section). The shared action handle passed as argument to > >>> destroy API should not be used any further i.e. result of the usage is > >>> undefined. > >>> > >>> Shared action re-configuration > >>> === > >>> Shared action behavior defined by its configuration can be updated via > >>> rte_flow_shared_action_update() (see "example" section). The shared > >>> action update operation modifies HW related resources/objects allocated > >>> on the action creation. The number of operations performed by the update > >>> operation should not depend on the number of flows sharing the related > >>> action. On return of shared action update API action behavior should be > >>> according to updated configuration for all flows sharing the action. > >>> > >>> Shared action query > >>> === > >>> Provide separate API to query shared action state (see > >>> rte_flow_shared_action_update()). Taking a counter as an example: query > >>> returns value aggregating all counter increments across all flow rules > >>> sharing the counter. This API doesn't query shared action configuration > >>> since it is controlled by rte_flow_shared_action_create() and > >>> rte_flow_shared_action_update() APIs and no supposed to change by other > >>> means. > >>> > >>> PMD support > >>> === > >>> The support of introduced API is pure PMD specific design and > >>> responsibility for each action type (see struct rte_flow_ops). This sentence is strange. Of course PMD implementation is a PMD specific design. I think you can remove it. > >>> testpmd > >>> === > >>> In order to utilize introduced API testpmd cli may implement following > >>> extension > >>> create/update/destroy/query shared action accordingly > >>> > >>> flow shared_action (port) create {action_id (id)} (action) / end > >>> flow shared_action (port) update (id) (action) / end > >>> flow shared_action (port) destroy action_id (id) {action_id (id) [...]} > >>> flow shared_action (port) query (id) > >>> > >>> testpmd example > >>> === > >>> > >>> configure rss to queues 1 & 2 > >>> > >>>> flow shared_action 0 create action_id 100 rss queues 1 2 end / end > >>> > >>> create flow rule utilizing shared action > >>> > >>>> flow create 0 ingress \ > >>> pattern eth dst is 0c:42:a1:15:fd:ac / ipv6 / tcp / end \ > >>> actions shared 100 / end > >>> > >>> add 2 more queues > >>> > >>>> flow shared_action 0 modify 100 rss queues 1 2 3 4 end / end > >> > >> testpmd is out-of-scope of the patch and it is better to > >> remove the description to avoid unsync if testpmd > >> commands are changed. > > > > There is still added value is testpmd example demonstrating usage of > > shared action with rte flows. I will update the example to reflect the current > > testpmd syntax for shared action. > > Yes and no. IMHO It would be OK for series description etc, > but not OK for the changeset description which will be > kept in the history and will become misleading when > commands are changed. I think that no information is better > than potentially wrong information. I agree with Andrew, the API explanation should be enough. Talking about testpmd commands in the ethdev patch is not appropriate.
next prev parent reply other threads:[~2020-10-14 7:22 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-02 12:05 [dpdk-dev] [PATCH] " Andrey Vesnovaty 2020-07-03 15:02 ` Jerin Jacob 2020-07-03 15:21 ` Thomas Monjalon 2020-07-04 9:54 ` Andrey Vesnovaty 2020-07-04 10:10 ` Andrey Vesnovaty 2020-07-04 12:33 ` Jerin Jacob 2020-07-05 10:26 ` Ori Kam 2020-07-06 9:00 ` Jerin Jacob 2020-07-06 12:28 ` Ori Kam 2020-07-06 13:32 ` Andrey Vesnovaty 2020-07-07 2:30 ` Jerin Jacob 2020-07-07 6:21 ` Ori Kam 2020-07-07 15:21 ` Ferruh Yigit 2020-07-07 17:24 ` Ori Kam 2020-07-07 17:52 ` Ferruh Yigit 2020-07-07 19:38 ` Jerin Jacob 2020-07-07 21:03 ` Ori Kam 2020-07-08 9:25 ` Jerin Jacob 2020-07-08 9:47 ` Ori Kam 2020-07-08 11:00 ` Jerin Jacob 2020-07-08 11:50 ` Thomas Monjalon 2020-07-08 12:18 ` Ori Kam [not found] ` <20200708204015.24429-2-andreyv@mellanox.com> 2020-07-13 8:04 ` [dpdk-dev] [PATCH v2 1/6] ethdev: " Kinsella, Ray 2020-07-13 10:16 ` Andrew Rybchenko 2020-07-15 8:54 ` Andrew Rybchenko 2020-07-15 9:00 ` Andrew Rybchenko 2020-09-15 11:30 ` Andrey Vesnovaty [not found] ` <20200708204015.24429-3-andreyv@mellanox.com> 2020-07-13 8:06 ` [dpdk-dev] [PATCH v2 2/6] common/mlx5: modify advanced Rx object via DevX Kinsella, Ray 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 0/6] add flow shared action API + PMD Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API Andrey Vesnovaty 2020-09-12 2:18 ` Ajit Khaparde 2020-09-15 11:50 ` Andrey Vesnovaty 2020-09-15 15:49 ` Ajit Khaparde 2020-09-16 15:52 ` Andrey Vesnovaty 2020-09-16 19:20 ` Ajit Khaparde 2020-09-17 15:33 ` Andrew Rybchenko 2020-09-17 16:02 ` Ori Kam 2020-09-24 19:25 ` Ajit Khaparde 2020-09-26 11:09 ` Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 00/10] RTE flow shared action Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 01/10] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-04 11:10 ` Ori Kam 2020-10-06 10:22 ` Andrey Vesnovaty 2020-10-04 17:00 ` Stephen Hemminger 2020-10-04 17:01 ` Stephen Hemminger 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 02/10] ethdev: add conf arg to shared action icreate API Andrey Vesnovaty 2020-10-04 11:11 ` Ori Kam 2020-10-06 10:28 ` Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 03/10] common/mlx5: modify advanced Rx object via DevX Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 04/10] net/mlx5: modify hash Rx queue objects Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 05/10] net/mlx5: shared action PMD Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 06/10] net/mlx5: shared action PMD create conf arg Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 07/10] net/mlx5: driver support for shared action Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 08/10] net/mlx5: shared action create conf drv support Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 09/10] examples/flow_filtering: utilize shared RSS action Andrey Vesnovaty 2020-10-04 11:21 ` Ori Kam 2020-10-06 10:34 ` Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 10/10] app/testpmd: support shared action Andrey Vesnovaty 2020-10-04 11:28 ` Ori Kam 2020-10-04 12:04 ` Ori Kam 2020-10-06 10:36 ` Andrey Vesnovaty 2020-10-04 11:14 ` [dpdk-dev] [PATCH v3 00/10] RTE flow " Ori Kam 2020-10-06 10:28 ` Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 2/6] common/mlx5: modify advanced Rx object via DevX Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 3/6] net/mlx5: modify hash Rx queue objects Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 4/6] net/mlx5: shared action PMD Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 5/6] net/mlx5: driver support for shared action Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 6/6] examples/flow_filtering: utilize shared RSS action Andrey Vesnovaty 2020-07-09 4:44 ` Jerin Jacob 2020-07-09 6:08 ` Ori Kam 2020-07-09 12:25 ` Andrey Vesnovaty 2020-07-09 12:39 ` Thomas Monjalon 2020-07-09 4:39 ` [dpdk-dev] [PATCH v2 0/6] add flow shared action API + PMD Jerin Jacob 2020-10-06 20:08 ` [dpdk-dev] [PATCH v4 0/2] RTE flow shared action Andrey Vesnovaty 2020-10-06 20:08 ` [dpdk-dev] [PATCH v4 1/2] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-07 6:27 ` Ori Kam 2020-10-06 20:08 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: support shared action Andrey Vesnovaty 2020-10-07 6:30 ` Ori Kam 2020-10-07 12:56 ` [dpdk-dev] [PATCH v5 0/2] RTE flow " Andrey Vesnovaty 2020-10-07 12:56 ` [dpdk-dev] [PATCH v5 1/2] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-07 13:01 ` Ori Kam 2020-10-07 21:23 ` Ajit Khaparde 2020-10-08 7:28 ` Andrey Vesnovaty 2020-10-07 12:56 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: support shared action Andrey Vesnovaty 2020-10-07 18:36 ` [dpdk-dev] [PATCH v6 0/2] RTE flow " Andrey Vesnovaty 2020-10-07 18:36 ` [dpdk-dev] [PATCH v6 1/2] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-07 18:36 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: support shared action Andrey Vesnovaty 2020-10-07 20:01 ` Ajit Khaparde 2020-10-08 10:58 ` Andrey Vesnovaty 2020-10-08 11:51 ` [dpdk-dev] [PATCH v7 0/2] RTE flow " Andrey Vesnovaty 2020-10-08 11:51 ` [dpdk-dev] [PATCH v7 1/2] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-08 22:30 ` Ajit Khaparde 2020-10-14 11:47 ` Andrey Vesnovaty 2020-10-12 14:19 ` Andrew Rybchenko 2020-10-13 20:06 ` Andrey Vesnovaty 2020-10-14 6:49 ` Andrew Rybchenko 2020-10-14 7:22 ` Thomas Monjalon [this message] 2020-10-14 11:43 ` Andrey Vesnovaty 2020-10-14 11:42 ` Andrey Vesnovaty 2020-10-08 11:51 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: support shared action Andrey Vesnovaty 2020-10-08 23:54 ` Ajit Khaparde 2020-10-14 11:40 ` [dpdk-dev] [PATCH v8 0/2] RTE flow " Andrey Vesnovaty 2020-10-14 11:40 ` [dpdk-dev] [PATCH v8 1/2] ethdev: add shared actions to flow API Andrey Vesnovaty 2020-10-14 11:44 ` Andrew Rybchenko 2020-10-14 16:17 ` Ferruh Yigit 2020-10-14 11:40 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: support shared action Andrey Vesnovaty
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1884452.bCSgJj8pPL@thomas \ --to=thomas@monjalon.net \ --cc=ajit.khaparde@broadcom.com \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=andrey.vesnovaty@gmail.com \ --cc=andreyv@nvidia.com \ --cc=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=jerinj@marvell.com \ --cc=orika@nvidia.com \ --cc=samik.gupta@broadcom.com \ --cc=stephen@networkplumber.org \ --cc=viacheslavo@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git