From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/3] i40e: enable extended tag
Date: Mon, 25 Jan 2016 10:16:32 +0100 [thread overview]
Message-ID: <1884621.9QzzlocIgN@xps13> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A98CE19@SHSMSX104.ccr.corp.intel.com>
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2015-12-21 10:38, Helin Zhang:
> > > PCIe feature of 'Extended Tag' is important for 40G performance.
> > > It adds its enabling during each port initialization, to ensure the
> > > high performance.
> >
> > If it's so important, why the values are not documented?
> > Please start to fill a file doc/guides/nics/i40e.rst to explain how the
> > device works. Thanks
>
> It has already been mentioned in getting started guide for a long time.
> Are you suggesting to move into i40e specifically? Thanks!
Yes you're right. I had forgotten that:
http://dpdk.org/doc/guides-2.2/linux_gsg/enable_func.html#enabling-extended-tag-and-setting-max-read-request-size
Yes, it would be better moved into an i40e doc.
And maybe max_read_request_size may be commented to give advices on values.
Thanks
next prev parent reply other threads:[~2016-01-25 9:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 2:38 [dpdk-dev] [PATCH 0/3] " Helin Zhang
2015-12-21 2:38 ` [dpdk-dev] [PATCH 1/3] " Helin Zhang
2016-01-22 1:34 ` Wu, Jingjing
2016-01-22 10:26 ` Thomas Monjalon
2016-01-24 3:25 ` Zhang, Helin
2016-01-25 9:16 ` Thomas Monjalon [this message]
2016-01-26 0:29 ` Zhang, Helin
2015-12-21 2:38 ` [dpdk-dev] [PATCH 2/3] eal: remove pci config of " Helin Zhang
2016-02-22 3:59 ` [dpdk-dev] [PATCH v2 0/3] enable extended tag for i40e Helin Zhang
2016-02-22 3:59 ` [dpdk-dev] [PATCH v2 1/3] i40e: enable extended tag Helin Zhang
2016-02-23 10:44 ` Bruce Richardson
2016-02-24 0:39 ` Zhang, Helin
2016-02-22 3:59 ` [dpdk-dev] [PATCH v2 2/3] eal: remove pci config of " Helin Zhang
2016-03-08 17:05 ` Thomas Monjalon
2016-02-22 3:59 ` [dpdk-dev] [PATCH v2 3/3] igb_uio: deprecate sys files Helin Zhang
2016-03-08 17:48 ` Thomas Monjalon
2016-03-08 18:02 ` Thomas Monjalon
2016-02-22 5:52 ` [dpdk-dev] [PATCH v2 0/3] enable extended tag for i40e Wu, Jingjing
2016-03-08 18:38 ` [dpdk-dev] [PATCH v3 " Thomas Monjalon
2016-03-08 18:38 ` [dpdk-dev] [PATCH v3 1/3] i40e: enable extended tag Thomas Monjalon
2016-03-08 18:38 ` [dpdk-dev] [PATCH v3 2/3] pci: remove config of " Thomas Monjalon
2016-03-08 18:38 ` [dpdk-dev] [PATCH v3 3/3] igb_uio: deprecate " Thomas Monjalon
2016-03-08 18:41 ` [dpdk-dev] [PATCH v3 0/3] enable extended tag for i40e Thomas Monjalon
2016-03-09 0:48 ` Zhang, Helin
2016-03-09 0:50 ` Thomas Monjalon
2016-03-09 0:52 ` Thomas Monjalon
2015-12-21 2:38 ` [dpdk-dev] [PATCH 3/3] igb_uio: remove sys files for setting pci config space Helin Zhang
2015-12-21 18:57 ` Stephen Hemminger
2016-02-22 6:31 ` [dpdk-dev] [PATCH v2 0/3] enable extended tag for i40e Helin Zhang
2016-02-22 6:31 ` [dpdk-dev] [PATCH v2 1/3] i40e: enable extended tag Helin Zhang
2016-02-22 6:31 ` [dpdk-dev] [PATCH v2 2/3] eal: remove pci config of " Helin Zhang
2016-02-22 6:31 ` [dpdk-dev] [PATCH v2 3/3] igb_uio: deprecate sys files Helin Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1884621.9QzzlocIgN@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).