From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id CD2AB8D9C for ; Mon, 25 Jan 2016 10:17:37 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id n5so69046284wmn.0 for ; Mon, 25 Jan 2016 01:17:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=RfDWXEY4s1VF1YIu8ngxbDQfk5GQMfkIACihD3TWmCw=; b=ARQQLPRxkki8ufzseJBhxzAiA3cXymoYEuHhDVwsK6SSe/E5V6G8ak9GdRsgEBQm6n k3vNOrwy+Meb0dFYYhHiIAWGJwZSGMYAn7aX5L8VokVN+JfUH9Lfl0Ui6DKklv3tMSiV u7WHAJyH7TROv/8WOLa5hVbv6vKXHSJQpCTRnJ4nKZDVCY51tviXD9RN3l78zgEKLiju kYFk7nL7O2BynpZWbaw312RlJM2F+g7yfBwBuGuhdpuN6EA9dVxyWXabuEKi8bJM2qUc Xbk3X4vN9WIvWxzaCA3NVVf7uQdkx2Llza39GUvBd4mzhKSlAZXJ+6Oe5E5FlNpnrmSR BZUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=RfDWXEY4s1VF1YIu8ngxbDQfk5GQMfkIACihD3TWmCw=; b=CIQ4PMfzRqvAehTkFPznoYEi6gqBxmg79rgaIe4zCXyvYnfwzIBbrg3pqaGPH3g5sN hdYyuxNJGmcLa20vqixbAZ0VMbIDgxd+E1Yx7Oknmho66R/PXn5UBJJBbqukyCMsJ3pm BidxjS+TcCUK3RJSQNP2kukOo9BAD7PDl/mAOkqfeB8cs25pzFr8BkQBG3jkiVgUJ72r mAXx4sLsfw97Voyrsi2gd5Iri9YKXk7JZ8lh8Ud2eLNyCHHuB3aV3+zi6xbGAmtC4vgP lucbe70F3mmG94ul74UAOhLmGN3lFnqny8BFdxFT71mF4gc/YGiW8+EAyQDKMxzfTA/6 eyGQ== X-Gm-Message-State: AG10YOSuxsFvMMgJ/Xx8qRIQMH1EC5CnYGQGH9mDRF25OM7Rm5LJMVqhZY80zUi1npsqIvRO X-Received: by 10.28.215.136 with SMTP id o130mr16651138wmg.33.1453713457601; Mon, 25 Jan 2016 01:17:37 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id w80sm15214670wme.17.2016.01.25.01.17.36 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 25 Jan 2016 01:17:36 -0800 (PST) From: Thomas Monjalon To: "Zhang, Helin" Date: Mon, 25 Jan 2016 10:16:32 +0100 Message-ID: <1884621.9QzzlocIgN@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1450665486-8335-1-git-send-email-helin.zhang@intel.com> <3789056.EpDHogkSc1@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/3] i40e: enable extended tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jan 2016 09:17:38 -0000 > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-12-21 10:38, Helin Zhang: > > > PCIe feature of 'Extended Tag' is important for 40G performance. > > > It adds its enabling during each port initialization, to ensure the > > > high performance. > > > > If it's so important, why the values are not documented? > > Please start to fill a file doc/guides/nics/i40e.rst to explain how the > > device works. Thanks > > It has already been mentioned in getting started guide for a long time. > Are you suggesting to move into i40e specifically? Thanks! Yes you're right. I had forgotten that: http://dpdk.org/doc/guides-2.2/linux_gsg/enable_func.html#enabling-extended-tag-and-setting-max-read-request-size Yes, it would be better moved into an i40e doc. And maybe max_read_request_size may be commented to give advices on values. Thanks