From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 5F9941B11A for ; Thu, 4 Oct 2018 11:18:41 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 031D7D1D; Thu, 4 Oct 2018 05:18:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 04 Oct 2018 05:18:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=til+rkrLG0DppWoAGC6KsMBKU1+tpsiJeuhnymqFEl8=; b=imCYYVOyFZDx gRMVm2vHO6aREQ+TsY/jM9EQRmUft/KHm8oy98BycASOC8VpKgIePYyKebe4DUqb SNtJg0HVxaWXrztDGt7O4RywTPImS6LL5EsTyPXzK5mEamaCPab1TiMwpdMLDTmY 4/3G5/jzwPif7RvUXBGOXirBV+hWjr0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=til+rkrLG0DppWoAGC6KsMBKU1+tpsiJeuhnymqFE l8=; b=Lxtl+SKz8+TAE6glKNUe0f+s4jo92KUUCHwjkmvJ+OIybPjEnpD13Uoiw 7D5rZ/J91UIlnMSyM3/iMaqHzFXbbrsfCY4XOIsfmjBgOnJ54ED45YE3qPOqZ11o D8vFDxvi6Txt6maoqI7M+UbHyqo/rJLcJ6LNSSBt07YXQ5bTK83lb4MDQN76akoQ X/rH/cM/65QFcXhPBAQlEURO9FUUo5nefjxbDFUUdSb+en13jDd3db0Ti+XTuO+k wyg25tVKJPBj2OpkHojvH2k8ZLavSnj69xsck8hGzw/EB9whCRPRIvE8Tsvwvoa0 m6Mi4omYpuKGCsWhX3ctcOUrBknxA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (106.86.136.77.rev.sfr.net [77.136.86.106]) by mail.messagingengine.com (Postfix) with ESMTPA id E4DD4102E2; Thu, 4 Oct 2018 05:18:37 -0400 (EDT) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org, John McNamara , Marko Kovacevic Date: Thu, 04 Oct 2018 11:18:35 +0200 Message-ID: <1885384.20xM5LhNRE@xps> In-Reply-To: References: <98f283ce5bcf8973c5c08d13f4fbfe375ded6ebf.1535368896.git.anatoly.burakov@intel.com> <102589449.7KdqRJ0jb8@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] mem: store memory mode flags in shared config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 09:18:41 -0000 04/10/2018 11:17, Burakov, Anatoly: > On 03-Oct-18 11:05 PM, Thomas Monjalon wrote: > > 20/09/2018 17:41, Anatoly Burakov: > >> Currently, command-line switches for legacy mem mode or single-file > >> segments mode are only stored in internal config. This leads to a > >> situation where these flags have to always match between primary > >> and secondary, which is bad for usability. > >> > >> Fix this by storing these flags in the shared config as well, so > >> that secondary process can know if the primary was launched in > >> single-file segments or legacy mem mode. > >> > >> This bumps the EAL ABI, however there's an EAL deprecation notice > >> already in place[1] for a different feature, so that's OK. > >> > >> [1] http://patches.dpdk.org/patch/43502/ > >> > >> Signed-off-by: Anatoly Burakov > >> --- > >> > >> Notes: > >> v2: > >> - Added documentation on ABI break > >> > >> doc/guides/rel_notes/rel_description.rst | 5 +++++ > > > > Removed change in this file (dup of release note). > > > >> doc/guides/rel_notes/release_18_11.rst | 6 +++++- > >> .../common/include/rte_eal_memconfig.h | 4 ++++ > >> lib/librte_eal/linuxapp/eal/Makefile | 2 +- > >> lib/librte_eal/linuxapp/eal/eal.c | 20 +++++++++++++++++++ > >> lib/librte_eal/meson.build | 2 +- > >> 6 files changed, 36 insertions(+), 3 deletions(-) > > > > Applied (without extra note), thanks. > > > > This will probably break external mem patches due to conflict in release > notes. Should i respin? No, conflicts in release notes are usual. I manage such conflict myself.