From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 58134B0A3 for ; Wed, 18 Jun 2014 11:23:41 +0200 (CEST) Received: by mail-wg0-f41.google.com with SMTP id a1so534652wgh.24 for ; Wed, 18 Jun 2014 02:23:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=BBPj0YUAjNhC7nR2kDgOWfNgvc4niqxbcv2nRZ8r7wg=; b=cOwIYgka4rypxMvmIoMd8gwJO9Z4s9AjqU104OEytRyR8Lva6Gonx6isjZGq8ISkhW 0+SPCUOy4VDFlpzoVGLhJOtTeTtMNAz5eOLtPKHdK1t4XUw5sgNws4qGdZLPl0mfgc2T 7PUXc15wn5055o2vJo4tgr1nMAH+LbgRME2ARHoGbWJ2aMdRpuKf6FVeq8wgUiVyD1GR ohTEAs24IF94P5Dn9CE6c4LMSvYmON6QU3TgDaQTbMfw+NxakWJtPTHqURh3FfHtoyKL qU69isrZ5otIa3cgJ18gyEIfRQgCl0g6muK1HaYg3UawlmIXdyGSFAFFQZkNofYfAl9X xOvw== X-Gm-Message-State: ALoCoQn/gBxEgiGKUD6SpdZL2mgJVcdMisUL124A20GxNNND9aZvOgCqzgLdl2avo/1PXUv801mY X-Received: by 10.194.11.74 with SMTP id o10mr21536342wjb.82.1403083437745; Wed, 18 Jun 2014 02:23:57 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id o3sm24535002wiz.24.2014.06.18.02.23.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jun 2014 02:23:57 -0700 (PDT) From: Thomas Monjalon To: "Zhang, Helin" Date: Wed, 18 Jun 2014 11:23:55 +0200 Message-ID: <1886490.uKY7E5th3Z@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: References: <1401944951-23783-1-git-send-email-helin.zhang@intel.com> <3908766.ykkJEPOGFU@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 00/27] Add i40e PMD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jun 2014 09:23:41 -0000 2014-06-18 08:51, Zhang, Helin: > Thomas Monjalon: > > Some things could be cleaned up later, especially i40e specific flags in > > generic API must be removed. Please work on a patch for next release. > > Btw, what do you mean the i40e specific flags in generic API? Did you mean > the new flags defined in rte_mbuf.h? Yes, we are working on some bug fixes > and enhancements which might need to be added in the next release. I mean that RSS flags are really Intel-specific. In case other NIC vendors would use this RSS API, it can be a problem to address. But we can wait for this one. About mbuf flags, they are all zeros and useless. So a patch is needed to get some space and define new values (as you already explained). And last but not the least, RTE_LIBRTE_I40E_16BYTE_RX_DESC handling is very strange as it can be seen in this commit: http://dpdk.org/browse/dpdk/commit/?id=ac2ece3fb1f5511 -- Thomas