From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id CDB2BA034C;
Tue, 30 Aug 2022 10:38:58 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id B36AD40F18;
Tue, 30 Aug 2022 10:38:58 +0200 (CEST)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by mails.dpdk.org (Postfix) with ESMTP id BDF4E40F17
for <dev@dpdk.org>; Tue, 30 Aug 2022 10:38:56 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1661848736; x=1693384736;
h=message-id:date:subject:to:cc:references:from:
in-reply-to:content-transfer-encoding:mime-version;
bh=Ij7aD14lWPOuKGPzDHlcTuzRu4gSiF0jbVuWRSCRJ04=;
b=gHVGcUdpjGtcS04gU5LNfSB7vhzDG2wFbCggYQCJnGzILPxtPMLDQ+31
3U9//JnctvSJPHczPvjNEw7Qq7HGMLWChtUY3WGMfJGFD5LLxWimbjLiv
v/UCCm/MKODQY7YsxDxMaINsKtr5C15gJ7A19lL4i4fscxLwcAehdCDL2
uWM6nWinvljnmVHDfgx9mYvJ/ZlAsYe+cjMAMlEFHrW9JCaxRX3sbVfGb
ZI5k08SixGJOO9EicL3KLjX+BUpQXe4fBnjEd6cVTceLpY09GM1HETcZ4
gdtQ+07jcmAPMWXEjvLfJcJYW2mdhIoncEpR2RDlZdvMHDgBkARD7rInZ A==;
X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="274868686"
X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="274868686"
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
30 Aug 2022 01:38:55 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="715223001"
Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82])
by fmsmga002.fm.intel.com with ESMTP; 30 Aug 2022 01:38:55 -0700
Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by
fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2375.31; Tue, 30 Aug 2022 01:38:55 -0700
Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by
fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2375.31; Tue, 30 Aug 2022 01:38:55 -0700
Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by
fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2375.31 via Frontend Transport; Tue, 30 Aug 2022 01:38:55 -0700
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168)
by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2375.31; Tue, 30 Aug 2022 01:38:54 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=Vz3mhK/yh4BcrJdyCDGMdTC9SNKHBCh9NnKX6ixKLvla085RMIoIx+zrw1uW54uPR73SbRPYfkL7yOJFISZbFlh22nMj9PP/B0vDrqN9Z02y+FlSWycH4x7nZkQ3T2EJsyo79PxOTTlp9I6ABLfhRMye8kSpBumaDm89zT0WZ5R6gKUuhEQ9nQHn3tO1VwMKnE2auC585QWhOzEFarosyZiGcTunwnXsYXpUMI/PD/D8b5RxGODFBQxW9fTzSOar1C8CVgqhsN9SuYaTIG4f+tx5SOl+cOep4Jv8UZEEuGtxIKEN419ULyKvZ4r4L7VJhN25U/9KMEFq+v8DZY6MKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=a6+acLtIP0EX3bL2DfQNHJyFqM6IaXDg6PV0azZXPpY=;
b=C3R0M0Ep9KxnFaHgfT9wC6hh8lx7Kydx21F9LcyhXmL8zezDeYJwnK4ju7ZY4IZoeCAdZ0mkvPZqL5cvijFewh2Q7fx8HG0+AI+TsGXdbUBsAdYVeh4zmOB7UtrGxF3r903gvewCi3gfmiLl+k+Z3HT6KLmRmZNt6iBbV4VKoFUP+otduld68BMvvUbHpXRs0ho7SpCwhPOD17gZ3NsDyICUXlUF97mRNtO2NSDunHY4N4KgqNYXnjxiVye4YdoF7SsctSkCx0715g+Lv/MqdAcXiEWNTfIkzOHX+EedFwO3uHVH4h1Cu/312MZ1DKJTWcBxYnEnZCy5mGwk++4GaQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=intel.com;
Received: from PH0PR11MB5660.namprd11.prod.outlook.com (2603:10b6:510:d5::6)
by SJ1PR11MB6250.namprd11.prod.outlook.com (2603:10b6:a03:459::17) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.21; Tue, 30 Aug
2022 08:38:53 +0000
Received: from PH0PR11MB5660.namprd11.prod.outlook.com
([fe80::cd29:e5ca:90fe:5e33]) by PH0PR11MB5660.namprd11.prod.outlook.com
([fe80::cd29:e5ca:90fe:5e33%4]) with mapi id 15.20.5566.021; Tue, 30 Aug 2022
08:38:53 +0000
Message-ID: <18867d76-4c5f-d913-1f16-fda7651a5f55@intel.com>
Date: Tue, 30 Aug 2022 09:38:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
Thunderbird/91.8.1
Subject: Re: [PATCH] rcu: fix build failure with debug dp log level
Content-Language: en-US
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, Anoob Joseph
<anoobj@marvell.com>
CC: "jerinj@marvell.com" <jerinj@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
nd <nd@arm.com>
References: <20220829165151.472-1-anoobj@marvell.com>
<DBAPR08MB5814C84E9C764A5A8121F4DC98769@DBAPR08MB5814.eurprd08.prod.outlook.com>
From: "Morrissey, Sean" <sean.morrissey@intel.com>
In-Reply-To: <DBAPR08MB5814C84E9C764A5A8121F4DC98769@DBAPR08MB5814.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: DB6P192CA0001.EURP192.PROD.OUTLOOK.COM (2603:10a6:4:b8::11)
To PH0PR11MB5660.namprd11.prod.outlook.com
(2603:10b6:510:d5::6)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dfa0de3b-6528-4fc4-526c-08da8a6311db
X-MS-TrafficTypeDiagnostic: SJ1PR11MB6250:EE_
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: xUAvmXuwwnQQ3GlDfnwgKwKWc13HCSdLBIba4jFXcygBpHiHroWZfiKMqNLt8QLw2z392hYZx0Ir/ulNAGstRJ79a+ax6j4UfzN/vUt6i3cQzakGYLVgxXa+WtAuyOtUVv5IAiyQpa6fqvQ05ZYkrcv16Ht31+gmVKstFlVYGbSqe6/sLTVGAkP/P8Hok2MjVum4xEMeIh+c4elh+SMZXfX0EXomcS/1JAdn6DmX15D70eDGrJZOkmPO/TD6So4krHUaD0Pwla26Pihc/QmcVfg9ddpQFNoTySkrFdEgIfTn9zWz/75FiSkGhi9QYL7HkCEYslCcssYfViSbm0o0K+Y05JTVnu7th95iwqSp8JUxtMzG4wY1HwF9HD/VrG2YFFeo1cBD+cN3IE6ibPYT4jP5HQZXx4P1OjoiWhnsslaanx7/3/Pb5mEnad061yuC0WI7KXhkpu1dhdjV2ya42nhVUO+5yZONjHBBSxbpFFGUf44G+tmrKBNpm1LOLIw5fyhLknZNQlb7ugIFyqih9eHKKGGMu9l0LwUtjZAE+GVtU7Hq1ubntjIGFdWaJ2nLHVuoQ+uoZCuGAmmKkDGhOfhHcc2OMWRLkpaJ3oUeBME9MQUnPvemFmXs6nJ1APex0TLzdtQgtC0ioH8nXIwlQRH44Mi8KgdK+pCkNtXeHRamkBAoVIirk54Ajq9bZoyBh4ypoxFIOef4NnBwuRjBJFwmsrFk15hzPbg9Ctz18sq7StlkrfOXpsQ8+oX/X7fNaZmeROWJPQKs9yYIMRE2T2qTF/rcYXNK02Nr4HPtS50=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:PH0PR11MB5660.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230016)(376002)(39860400002)(136003)(366004)(396003)(346002)(2906002)(186003)(2616005)(316002)(6666004)(36756003)(31686004)(53546011)(6506007)(26005)(6512007)(83380400001)(66476007)(86362001)(31696002)(82960400001)(5660300002)(6486002)(478600001)(8936002)(54906003)(38100700002)(41300700001)(110136005)(4326008)(8676002)(66556008)(66946007)(45980500001)(43740500002);
DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGNzN3pPUm1wYy9nUTljc1d3aC93Y0FuTkpqc3gvaGZpalNsVUp2MTIvMk5t?=
=?utf-8?B?RERlWmhjYTZIT0hrTnU2M1dlckdrbUk2ZEt2c2ovQUxXbURqSG1sUWtaWXpP?=
=?utf-8?B?OFY2bVpXcHNrRi9oUjJ6WUhoSm8yaFFtNkp5ZndxSDAxR1VIU3VpcGdMQWFC?=
=?utf-8?B?dHRWdGFaNnJ0ejVuTVUyQUJ4UzBJT20xSUtKWERRazMwTld5RS9jVTQ2T3U2?=
=?utf-8?B?MldQNnVlcHdrdW1hNW5PM2hOV0ZGb0ZEQVZJSnloVlVZbElpVnRTT25McDZV?=
=?utf-8?B?RjEyZkpOQVZwelNFVy8vbzl2L09wUHA2UkVDVGxZVXdBSW5QNW02Smk4cXNM?=
=?utf-8?B?dDZka3g1c1RxaVBzdHVDcndXZjkxb0lxK2VCWGo3WG1YZzZWSjgySzZwUHVL?=
=?utf-8?B?bDZKendwSjIxOU1hdEU0dGN3Vkk2M3lCN1JIc1g5WFdYbzVqeUFvOXhOWURZ?=
=?utf-8?B?ZnNmbEVBWlF5cDRVNW5qMGYvT2pEdG5oRWhFNjlxT2UyS2tSR0dMemZQOFBy?=
=?utf-8?B?V3ZUd3ZCSXdLWFBIRnVJNGQ5WGI2L1hwVEd4R3d3U0xyWi9ia0l0WUIrczJw?=
=?utf-8?B?RFVkbERvRDU0anZiK2VzbFRRczFaek9NakJ2VTM1Y1NydmdEdTFjbUU5a3Bl?=
=?utf-8?B?WkdzWTFCUUxEdkhBTmxYUFZHMnYwYjRuSHBBdWhIZFUrNE55bm9sTkE3eXY2?=
=?utf-8?B?NGtuTkJsWjVESm1kdGxUVGdoelc4ODNDQm9Ga1g3YjhCNC92bGFtMVJjVFI0?=
=?utf-8?B?TzAyU3I4V0F0SS8xTlZZRnBuU2Z3QVhPYVd0M28wT1BOM2JYbDJyZkNWVTRj?=
=?utf-8?B?WjZUSjRLY3NnUEpxRW5xZitmdnpjZjlGWk0wd2xsSXpLWGRING9Qa1VIYkcy?=
=?utf-8?B?Vm1ScUIyWG5MZkZENDZjWGhVU0FvZHpuRitON2VZSW5tZkNHVGIzUXR0Tk5j?=
=?utf-8?B?QXdEbjFXS1JQT3Ard0wzOG05RTI2anVaMndKV21oSHk2SFYzZkJwMzh6ZlVq?=
=?utf-8?B?VHBRc0JocjluTmRhS2s0T056NnpYVDVBUC9UYzJNdXBGYlZra1N6Z0VVUDZH?=
=?utf-8?B?OWxDem1Pa251YUJqMm04TnpqNFdSYnBpdEx0US9FakNEMTdBaDBQeDhjaW9M?=
=?utf-8?B?RldyNmtBSGxtZ01ueEtOVGF0ekNGYTErNXdONDYyNldsUW4vVXRZVlpFTVFZ?=
=?utf-8?B?N2FLdEU2ejU0YzRuYXJ2QWxIZFBZTDFnbjRrdzhsYjZoMDRNWkFuWjAwUzRY?=
=?utf-8?B?dTFOR1BzUnhvN0c0aUwzKzhiUW1Jc1R0ckh3a3pqMVBCaklQd3hCb0NxTitD?=
=?utf-8?B?YnA2ZTdPckEyMWVIZklGZTdpeVRaMlJlZG94RlhmMmJQVlFGN0w3bzZrNlFC?=
=?utf-8?B?MTNvOWRjenFZZ3JzNnhHRVE1WHBEOVlCbVVXd29rOGpNU093a3VWT25JaGNq?=
=?utf-8?B?bTBsMGQ3N0tpdlhqdWZNTjJENm1YRndmbVdlR0dIbGZYVStPYnNzNDc2V1d3?=
=?utf-8?B?aFJ2QzA0OFpzLzZkWThSVUIyTFU5TUp2TGZwVUZRaVhZSm5aVWQwalpMaU5v?=
=?utf-8?B?QXFqcUNtN2Q0anFqdUU1WlpuM2EyTGRibGk5WjdBZW52SUlvREV0RDNTU1l4?=
=?utf-8?B?c1hMVjR5KzcrQmt6MGF3U20zWjhxVktnVGRndlAvWWpvV3RsUUovajg0N1ZS?=
=?utf-8?B?QTAyV0psbklpZGptUDEvdHR3UnlRdXg1QlBoQmZxVWhsTjRzMTFhUGVXT09P?=
=?utf-8?B?VGlRQ3BDZXNjNlR6WkhPTFIwOW01TlZ2dHpyMkcxeWM0c2R1bThJYTRmWlUw?=
=?utf-8?B?eklJcEhXYWtwM3RpeDRRWGcwaG9sdFdDaGxpT3Q3ZkhTNVA2UWRlTjR2dUZu?=
=?utf-8?B?MjZ0MnpQRUhOY2ZweVpiT1FtM3gvQVExeW9RVjRRV200YktLSGtKbERBRlBK?=
=?utf-8?B?a2R4aEFVTlZxaXNsQ2k1NnR0K2ZzeG9mYUUyMVZybTRoRmJ6d2lRTjBlUmNU?=
=?utf-8?B?aVgzQlcyL2FuTDlpTnlKWGtRWXR6VmFVOXpJR0N1Tnd4Qm9UQUxlNzV4dHM4?=
=?utf-8?B?UGlQUnVTRXI4UmxONE95R1RSWjdoVGZCUitxemw0a1NrY0xxZ0R6MVEzU2Vw?=
=?utf-8?B?VzJ3SHFtUEJiME1uNmUwb3NOYzFvQ2kvR0p2aFVjMGMyQ1MxaWEwV09DUStr?=
=?utf-8?B?ZXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dfa0de3b-6528-4fc4-526c-08da8a6311db
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2022 08:38:53.5118 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6d+uSOh//OQ4ZiSrn3LO0fbVNWnUEhL/aD1/QhpDSv1e1UJ1IRFdqt0gtkp65rfExOfD2UhuMoHyhxcdzWA/CS+R5J8Zw7xy0uaAzccx1c0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6250
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On 29/08/2022 17:55, Honnappa Nagarahalli wrote:
>> -----Original Message-----
>> From: Anoob Joseph <anoobj@marvell.com>
>> Sent: Monday, August 29, 2022 11:52 AM
>> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
>> Cc: jerinj@marvell.com; dev@dpdk.org; sean.morrissey@intel.com
>> Subject: [PATCH] rcu: fix build failure with debug dp log level
>>
>> Build fails if RTE_LOG_DP_LEVEL is set to RTE_LOG_DEBUG. Fix the same by
>> including the required header when RTE_LOG_DP_LEVEL is set to
>> RTE_LOG_DEBUG.
>>
>> ../lib/rcu/rte_rcu_qsbr.h:678:40: error: expected ‘)’ before ‘PRIu64’
>> 678 | "%s: status: least acked token = %" PRIu64,
>> | ^~~~~~
>>
>> Fixes: 30a1de105a5f ("lib: remove unneeded header includes")
>> Cc: sean.morrissey@intel.com
> Agree on the fix.
> @sean.morrissey@intel.com Does the process that removed this header file inclusion needs fixing?
> If yes, should that fix be included in this patch?
@Honnappa.Nagarahalli@arm.com Yes, I believe the tool will need an
update, however, I believe it should be a separate patch for that.
>> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
>> ---
>> lib/rcu/rte_rcu_qsbr.h | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index
>> d81bf5e8db..b0f1720ca1 100644
>> --- a/lib/rcu/rte_rcu_qsbr.h
>> +++ b/lib/rcu/rte_rcu_qsbr.h
>> @@ -37,6 +37,10 @@ extern "C" {
>> #include <rte_atomic.h>
>> #include <rte_ring.h>
>>
>> +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
>> +#include <inttypes.h>
>> +#endif
>> +
>> extern int rte_rcu_log_type;
>>
>> #if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
>> --
>> 2.25.1