From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 6240D47D1 for ; Fri, 15 Jul 2016 14:38:31 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id i5so28111826wmg.0 for ; Fri, 15 Jul 2016 05:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=07XpQEDBTTZft1maHgsEAZRDnCyQ+jozC30xosv8icg=; b=UnxOKx/7fLn4t3GeTU49yKhNgdqJq6/gYWA26T9DhDf2/XKiwZsqUXwW5m89/qSePM EgbwQKBfJ5rxnwy8XQgd/Trwg+D6cXx0k+lHD5qYPBifOyxI3d2amVnCvanM7x2Pl8Yl uwOQ6XhCXXGpp2+SWvb39W4S4lb9zVeY6p7nWbH/+wn7BnDG3gMnaxjVwvEacgXyxtcD fV/NUOzgJr3J9g+tas1CFowmcYvuAz+M6JUheR/2kdncdwmBZCJhmqNWXIvUmcTKJXON UVGHdn6UW8v5eM4ge2WSW047CIH8rZ7XjePUsrP2RIPo4tdSVlqLMjg3ZIypLXhGj2PZ WRIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=07XpQEDBTTZft1maHgsEAZRDnCyQ+jozC30xosv8icg=; b=mMDrkpLINz+jhqEYtRJSPuN3mNCRQKTQxUSVVILEBYs60cSLIzoQd7TlCutK1cZJrU HrASaBsJdVdl3/2k9fegOEEeKsuIes20f3Jct6plduH3MPVsNIFwuy2Qo87vDT8PCVs+ R+pas0Xz7LJ03B2zNojGWwikaIEuJsp7AHHyJMOfVwEMQwrM0ArQphtOqeiZ1xFD0IA+ zSeRBMEBapJ0+HZ5nhk+1BhEbH3x05/NQPcOli6XW1wZrVkRvZUN0ZaBMtdbUFHncZ+B WlrNrY9LKiYiccLGBZ9yMTmUrAUAbVwdZALHZHmPPDNOziyuMi5ifJc4OnomaIP69Z7q aMqA== X-Gm-Message-State: ALyK8tLez37Ne+82w1sbJPrgOQVHHr7Ci/qLK952S/xLlKbaRjMJwguxrO1pOhp7PyWu0Qoz X-Received: by 10.28.207.79 with SMTP id f76mr13544696wmg.69.1468586311132; Fri, 15 Jul 2016 05:38:31 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id c16sm1999110wme.4.2016.07.15.05.38.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jul 2016 05:38:29 -0700 (PDT) From: Thomas Monjalon To: Shreyansh jain , Jan Viktorin Cc: dev@dpdk.org, david.marchand@6wind.com Date: Fri, 15 Jul 2016 14:38:28 +0200 Message-ID: <1886837.lFmbahJrCS@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <5788BF88.3060607@nxp.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <20160714175707.43755987@jvn> <5788BF88.3060607@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 05/17] eal: introduce init macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 12:38:31 -0000 Hi guys, 2016-07-15 16:18, Shreyansh jain: > On Thursday 14 July 2016 09:27 PM, Jan Viktorin wrote: > > Please. The time is almost gone. 18/7/2016 is the release (according > > to the roadmap)... I have to fix it in my patchset, otherwise it > > does not build (after moving the .name from rte_pci_driver to > > rte_driver). > > I didn't consider 18/Jul. > Please go ahead. I will continue to send v7 _without_ the above change > so that your patchset doesn't break. This way you will not get blocked > because of me. [...] > > I'd like to preserve the clear semantics. That is DRIVER_REGISTER_PCI > > -> give a pci device. > > > > Has anybody a different opinion? David? Thomas? > > Yes please. > Or else, if nothing comes up soon, I will simply go ahead and change to > DRIVER_REGISTER_PCI(eth_driver.pci_drv) as this trivial issue shouldn't > hold back this series. I'm sorry I have no time to review these series shortly. I think it is too late to consider an integration in 16.07 unfortunately. I feel you are doing a great job and we can target to have these changes in the early days of 16.11 (in August). As this is a big refactoring, it is probably a good idea to integrate it in the beginning of the next release integration cycle.