From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f169.google.com (mail-we0-f169.google.com [74.125.82.169]) by dpdk.org (Postfix) with ESMTP id CA983B394 for ; Mon, 1 Sep 2014 13:11:36 +0200 (CEST) Received: by mail-we0-f169.google.com with SMTP id k48so5279755wev.28 for ; Mon, 01 Sep 2014 04:16:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=+2tueALPtFbAU298bSLRo/cRtkZC1Z9Fzj3S9K9PvFk=; b=mlXkaQOAyn+enU/LueEHzufyH3XH1GE4Xm4k8ODw0pUMfdROleI4huXRKXYPrYcy8i sCIY2pdlh0JciRr5ZcnsP137Dt15g4zF28nPElGIFWuS4OLDWkriGh/eAQbgGmnbdmGU nfrkg9dgZ2Pt7Xtmqtjbwft6q8MpuE1w3df+w/LcTXRxrfsarLeULJEebzUEeuRDADha vZYp9k8CeAMEbQpgraV0/40mJQ4aAH/9wgVcx2pYvhsyVkz1egJBRdWVaZQbe5plgOSu pWj0AZjr9NSgkLn7EiHLDESWyyrhm7Cuc6pe9lWkzXAh0aIt6tN+A5EKSBIWTaTs6vhV ulzg== X-Gm-Message-State: ALoCoQmZSyyj+NvgAuDI9LHZQmuKVO7FAzjI1uyPUeqqNLOeP/xBZ5u/v1y8lzEgByoWTgvG8pVq X-Received: by 10.180.20.196 with SMTP id p4mr20852533wie.56.1409570163867; Mon, 01 Sep 2014 04:16:03 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ew1sm1372091wjb.31.2014.09.01.04.16.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Sep 2014 04:16:03 -0700 (PDT) From: Thomas Monjalon To: "Sanford, Robert" Date: Mon, 01 Sep 2014 13:15:57 +0200 Message-ID: <1887530.KP3tPLkpR8@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: References: <20140725103627.4ca989b7@haswell.linuxnetplumber.net> <20140823081453.6e3ae5d7@uryu.home.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/2] igb_uio: fix compability on old kernel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Sep 2014 11:11:36 -0000 Hi Robert, 2014-08-26 11:08, Sanford, Robert: > >> This is what we came up with. It works for us. In our kernel headers' > >> linux/pci.h, pci_num_vf is enclosed within "#ifdef > >>CONFIG_PCI_IOV/#endif"; > >> pci_intx_mask_supported and pci_check_and_mask_intx are enclosed within > >> "#ifdef HAVE_PCI_SET_MWI/#endif". > >> > >> What do you think? > > > >Maybe we can just get rid of kernel version checks all together and > >just use the HAVE_ checks. > > > >I will test on stock 2.6.32. > > Sorry, I spoke too soon. Although it builds with the ifdefs, I just found > that it does not load. > "kernel: igb_uio: Unknown symbol irq_to_desc" Do you have some progress on this side? Release 1.7.1 should be closed tomorrow and your help would be greatly appreciated. Thanks -- Thomas