From: Thomas Monjalon <thomas@monjalon.net>
To: Robin Jarry <robin.jarry@6wind.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: fix build with python 3.8
Date: Wed, 11 Dec 2019 11:58:33 +0100 [thread overview]
Message-ID: <1888325.zmKG1gms2k@xps> (raw)
In-Reply-To: <20191210133329.53mejxbyz4m5v7gr@6wind.com>
10/12/2019 14:33, Robin Jarry:
> 2019-12-10, Thomas Monjalon:
> > 10/12/2019 13:00, Bruce Richardson:
> > > On Mon, Dec 09, 2019 at 10:00:00PM +0100, Thomas Monjalon wrote:
> > > > After upgrading to python-3.8.0, a syntax mismatch is revealed:
> > > >
> > > > doc/guides/conf.py:240: SyntaxWarning: "is not" with a literal.
> > > > Did you mean "!="?
> > > > if value is not '':
> > > >
> > > > Replacing "is not" with "!=" seems the right thing to do.
> > > >
> > >
> > > Since this is basically just checking for an empty string is
> > > "len(value) > 0" not more logical than either comparison against ''?
> >
> > Probably yes.
> > I don't know what is the best practice in Python. Robin, any clue?
>
> In most cases, it is shorter and cleaner to simply do:
>
> if value:
>
> which behind the scenes calls value.__bool__() (or value.__len__()).
>
> https://docs.python.org/3/reference/datamodel.html#object.__bool__
I guess it works also with python 2?
I am sending a v2 with this syntax, thanks.
next prev parent reply other threads:[~2019-12-11 10:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 21:00 Thomas Monjalon
2019-12-10 12:00 ` Bruce Richardson
2019-12-10 12:27 ` Thomas Monjalon
2019-12-10 13:33 ` Robin Jarry
2019-12-11 10:58 ` Thomas Monjalon [this message]
2019-12-11 11:01 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2019-12-11 11:15 ` Bruce Richardson
2019-12-12 22:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1888325.zmKG1gms2k@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=robin.jarry@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).