From: "Pei, Yulong" <yulong.pei@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] i40e: fix the issue dcb cannot be configured when FW version is 5.x
Date: Thu, 19 Nov 2015 06:16:08 +0000 [thread overview]
Message-ID: <188971FCDA171749BED5DA74ABF3E6F0021D903C@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1447664217-11569-1-git-send-email-jingjing.wu@intel.com>
Tested-by: Yulong Pei <Yulong.pei@intel.com>
-----Original Message-----
From: Wu, Jingjing
Sent: Monday, November 16, 2015 4:57 PM
To: dev@dpdk.org
Cc: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin <helin.zhang@intel.com>; Pei, Yulong <yulong.pei@intel.com>
Subject: [PATCH] i40e: fix the issue dcb cannot be configured when FW version is 5.x
When NVM version is updated to 5.x, DCB can not be configured. This issue is because of the FW version validation is not correct.
This patch fixed this issue.
Fixes: c8b9a3e3fe1b (i40e: support DCB mode)
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 2c51a0b..9003488 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -8316,7 +8316,8 @@ i40e_dcb_hw_configure(struct i40e_pf *pf,
uint32_t val;
/* Use the FW API if FW > v4.4*/
- if (!((hw->aq.fw_maj_ver == 4) && (hw->aq.fw_min_ver >= 4))) {
+ if (!(((hw->aq.fw_maj_ver == 4) && (hw->aq.fw_min_ver >= 4)) ||
+ (hw->aq.fw_maj_ver >= 5))) {
PMD_INIT_LOG(ERR, "FW < v4.4, can not use FW LLDP API"
" to configure DCB");
return I40E_ERR_FIRMWARE_API_VERSION;
--
2.4.0
next prev parent reply other threads:[~2015-11-19 6:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 8:56 Jingjing Wu
2015-11-19 6:16 ` Pei, Yulong [this message]
2015-11-23 22:20 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=188971FCDA171749BED5DA74ABF3E6F0021D903C@shsmsx102.ccr.corp.intel.com \
--to=yulong.pei@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).