From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6451F5A68 for ; Thu, 19 Nov 2015 07:16:12 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 18 Nov 2015 22:16:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,316,1444719600"; d="scan'208";a="603031802" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 18 Nov 2015 22:16:10 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 18 Nov 2015 22:16:10 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 18 Nov 2015 22:16:10 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.42]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.193]) with mapi id 14.03.0248.002; Thu, 19 Nov 2015 14:16:08 +0800 From: "Pei, Yulong" To: "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [PATCH] i40e: fix the issue dcb cannot be configured when FW version is 5.x Thread-Index: AQHRIEzD8jJE/YGFr0uF15jkCYajkJ6i4w0w Date: Thu, 19 Nov 2015 06:16:08 +0000 Message-ID: <188971FCDA171749BED5DA74ABF3E6F0021D903C@shsmsx102.ccr.corp.intel.com> References: <1447664217-11569-1-git-send-email-jingjing.wu@intel.com> In-Reply-To: <1447664217-11569-1-git-send-email-jingjing.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] i40e: fix the issue dcb cannot be configured when FW version is 5.x X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2015 06:16:12 -0000 Tested-by: Yulong Pei -----Original Message----- From: Wu, Jingjing=20 Sent: Monday, November 16, 2015 4:57 PM To: dev@dpdk.org Cc: Wu, Jingjing ; Zhang, Helin ; Pei, Yulong Subject: [PATCH] i40e: fix the issue dcb cannot be configured when FW versi= on is 5.x When NVM version is updated to 5.x, DCB can not be configured. This issue i= s because of the FW version validation is not correct. This patch fixed this issue. Fixes: c8b9a3e3fe1b (i40e: support DCB mode) Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.= c index 2c51a0b..9003488 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -8316,7 +8316,8 @@ i40e_dcb_hw_configure(struct i40e_pf *pf, uint32_t val; =20 /* Use the FW API if FW > v4.4*/ - if (!((hw->aq.fw_maj_ver =3D=3D 4) && (hw->aq.fw_min_ver >=3D 4))) { + if (!(((hw->aq.fw_maj_ver =3D=3D 4) && (hw->aq.fw_min_ver >=3D 4)) || + (hw->aq.fw_maj_ver >=3D 5))) { PMD_INIT_LOG(ERR, "FW < v4.4, can not use FW LLDP API" " to configure DCB"); return I40E_ERR_FIRMWARE_API_VERSION; -- 2.4.0