From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <yulong.pei@intel.com> Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id DAF1069FA for <dev@dpdk.org>; Mon, 29 Feb 2016 06:51:27 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 28 Feb 2016 21:51:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,519,1449561600"; d="scan'208";a="660957447" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 28 Feb 2016 21:51:27 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 28 Feb 2016 21:51:26 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 28 Feb 2016 21:51:26 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.136]) with mapi id 14.03.0248.002; Mon, 29 Feb 2016 13:51:24 +0800 From: "Pei, Yulong" <yulong.pei@intel.com> To: Panu Matilainen <pmatilai@redhat.com>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH] i40e: remove redundant compiler warning disablers Thread-Index: AQHRMOwiXboga5OIlUKF9RoaXEEGoJ9DCC3A Date: Mon, 29 Feb 2016 05:51:23 +0000 Message-ID: <188971FCDA171749BED5DA74ABF3E6F00353B34B@shsmsx102.ccr.corp.intel.com> References: <7f7e66dd4ed8453085b719799533365333fb1c54.1449491848.git.pmatilai@redhat.com> In-Reply-To: <7f7e66dd4ed8453085b719799533365333fb1c54.1449491848.git.pmatilai@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmNjMWFmYjktOGZmMy00MzZkLWI4YmMtYjk3YTEzOGVlNWJmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaDNaZHFLZlRDWHAwNUt5Zk5sOFlOVXh6VERVaWdkMVlnXC94dVwvNDd0U2dFPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] i40e: remove redundant compiler warning disablers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 29 Feb 2016 05:51:28 -0000 This patch caused build error with i686-native-linuxapp-gcc (gcc version i= s 4.8.3) > > i686-native-linuxapp-gcc compile error info: > > > > INSTALL-LIB librte_pmd_vmxnet3_uio.a > > /root/dpdk/drivers/net/i40e/base/i40e_common.c: In function > > =E2i40e_aq_set_lldp_mib=E2: > > /root/dpdk/drivers/net/i40e/base/i40e_common.c:3772:32: error: cast=20 > > from pointer to integer of different size [-Werror=3Dpointer-to-int-cas= t] > > cmd->address_high =3D CPU_TO_LE32(I40E_HI_WORD((u64)buff)); > > ^ > > /root/dpdk/drivers/net/i40e/base/i40e_common.c:3773:30: error: cast=20 > > from pointer to integer of different size [-Werror=3Dpointer-to-int-cas= t] > > cmd->address_low =3D CPU_TO_LE32(I40E_LO_DWORD((u64)buff)); > > ^ > > /root/dpdk/drivers/net/i40e/base/i40e_common.c: In function > > =E2i40e_aq_set_arp_proxy_config=E2: > > /root/dpdk/drivers/net/i40e/base/i40e_common.c:5817:33: error: cast=20 > > from pointer to integer of different size [-Werror=3Dpointer-to-int-cas= t] > > cmd->address_high =3D CPU_TO_LE32(I40E_HI_DWORD((u64)proxy_config)); > > ^ > > /root/dpdk/drivers/net/i40e/base/i40e_common.c:5818:30: error: cast=20 > > from pointer to integer of different size [-Werror=3Dpointer-to-int-cas= t] > > cmd->address_low =3D CPU_TO_LE32(I40E_LO_DWORD((u64)proxy_config)); > > ^ > > /root/dpdk/drivers/net/i40e/base/i40e_common.c: In function > > =E2i40e_aq_set_ns_proxy_table_entry=E2: > > /root/dpdk/drivers/net/i40e/base/i40e_common.c:5852:14: error: cast=20 > > from pointer to integer of different size [-Werror=3Dpointer-to-int-cas= t] > > CPU_TO_LE32(I40E_HI_DWORD((u64)ns_proxy_table_entry)); > > ^ > > /root/dpdk/drivers/net/i40e/base/i40e_common.c:5854:12: error: cast=20 > > from pointer to integer of different size [-Werror=3Dpointer-to-int-cas= t] > > CPU_TO_LE32(I40E_LO_DWORD((u64)ns_proxy_table_entry)); > > ^ > > /root/dpdk/drivers/net/i40e/base/i40e_common.c: In function > > =E2i40e_aq_set_clear_wol_filter=E2: > > /root/dpdk/drivers/net/i40e/base/i40e_common.c:5914:33: error: cast=20 > > from pointer to integer of different size [-Werror=3Dpointer-to-int-cas= t] > > cmd->address_high =3D CPU_TO_LE32(I40E_HI_DWORD((u64)filter)); > > ^ > > /root/dpdk/drivers/net/i40e/base/i40e_common.c:5915:30: error: cast=20 > > from pointer to integer of different size [-Werror=3Dpointer-to-int-cas= t] > > cmd->address_low =3D CPU_TO_LE32(I40E_LO_DWORD((u64)filter)); > > ^ > > cc1: all warnings being treated as errors > > make[6]: *** [i40e_common.o] Error 1 > > make[5]: *** [i40e] Error 2 > > make[5]: *** Waiting for unfinished jobs.... > > INSTALL-LIB librte_pmd_ixgbe.a > > AR librte_pmd_e1000.a > > INSTALL-LIB librte_pmd_e1000.a > > make[4]: *** [net] Error 2 > > make[3]: *** [drivers] Error 2 > > make[2]: *** [all] Error 2 > > make[1]: *** [pre_install] Error 2 > > make: *** [install] Error 2 -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen Sent: Monday, December 7, 2015 8:37 PM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH] i40e: remove redundant compiler warning disable= rs These may have been required at some point but current i40e base driver com= piles cleanly without them, at least with clang 3.7.0 and gcc 5.1.1. Signed-off-by: Panu Matilainen <pmatilai@redhat.com> --- drivers/net/i40e/Makefile | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile index 03= 3ee4a..4ffaf0d 100644 --- a/drivers/net/i40e/Makefile +++ b/drivers/net/i40e/Makefile @@ -53,23 +53,10 @@ CFLAGS_BASE_DRIVER =3D -wd593 -wd188 else ifeq ($(CC),= clang) CFLAGS_BASE_DRIVER +=3D -Wno-sign-compare CFLAGS_BASE_DRIVER +=3D= -Wno-unused-value -CFLAGS_BASE_DRIVER +=3D -Wno-unused-parameter -CFLAGS_B= ASE_DRIVER +=3D -Wno-strict-aliasing -CFLAGS_BASE_DRIVER +=3D -Wno-format -= CFLAGS_BASE_DRIVER +=3D -Wno-missing-field-initializers -CFLAGS_BASE_DRIVER= +=3D -Wno-pointer-to-int-cast -CFLAGS_BASE_DRIVER +=3D -Wno-format-nonlite= ral CFLAGS_BASE_DRIVER +=3D -Wno-unused-variable else CFLAGS_BASE_DRIVER= =3D -Wno-sign-compare CFLAGS_BASE_DRIVER +=3D -Wno-unused-value -CFLAGS_= BASE_DRIVER +=3D -Wno-unused-parameter -CFLAGS_BASE_DRIVER +=3D -Wno-strict= -aliasing -CFLAGS_BASE_DRIVER +=3D -Wno-format -CFLAGS_BASE_DRIVER +=3D -Wn= o-missing-field-initializers -CFLAGS_BASE_DRIVER +=3D -Wno-pointer-to-int-c= ast -CFLAGS_BASE_DRIVER +=3D -Wno-format-nonliteral -CFLAGS_BASE_DRIVER += =3D -Wno-format-security CFLAGS_BASE_DRIVER +=3D -Wno-unused-variable =20 ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1) -- 2.5.0