From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 68EEC9E3 for ; Fri, 28 Apr 2017 10:11:34 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Apr 2017 01:11:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,387,1488873600"; d="scan'208";a="1162066800" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 28 Apr 2017 01:11:32 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 28 Apr 2017 01:11:32 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 28 Apr 2017 01:11:32 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.224]) with mapi id 14.03.0319.002; Fri, 28 Apr 2017 16:11:29 +0800 From: "Pei, Yulong" To: "Wu, Jingjing" , "dev@dpdk.org" CC: "Richardson, Bruce" , "thomas@monjalon.net" Thread-Topic: [PATCH] app/testpmd: initalize port_numa and ring_numa Thread-Index: AQHSvMq1JDW7xaBiU0mix5me3j0ZHqHZ5JqAgACPSgA= Date: Fri, 28 Apr 2017 08:11:28 +0000 Message-ID: <188971FCDA171749BED5DA74ABF3E6F03B6C4FF1@shsmsx102.ccr.corp.intel.com> References: <1493018159-6882-1-git-send-email-yulong.pei@intel.com> <9BB6961774997848B5B42BEC655768F810D59D9A@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810D59D9A@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmI4Y2RhM2UtZjJhOS00NTQ5LTlhOTAtNjQ4NWQwNTJhMzU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InoxWUppcDhsSEN5T2IzZ0ZNWkMzbWRmdWVXRzM5UUF1Y3FIa0JjdEVENmM9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: initalize port_numa and ring_numa X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 08:11:34 -0000 Hi Jingjing, Thanks for the review, already sent v4 patch and fixes line in it. Best Regards Yulong Pei -----Original Message----- From: Wu, Jingjing=20 Sent: Friday, April 28, 2017 3:36 PM To: Pei, Yulong ; dev@dpdk.org Cc: Richardson, Bruce ; thomas@monjalon.net Subject: RE: [PATCH] app/testpmd: initalize port_numa and ring_numa > -----Original Message----- > From: Pei, Yulong > Sent: Monday, April 24, 2017 3:16 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Wu, Jingjing=20 > ; thomas@monjalon.net; Pei, Yulong=20 > > Subject: [PATCH] app/testpmd: initalize port_numa and ring_numa >=20 > Previous numa_support =3D 0 by default, it need to add --numa to testpmd= =20 > command line to enable numa, so port_numa and ring_numa were=20 > initalized at function launch_args_parse(), now testpmd change=20 > numa_support =3D 1 as default, so port_numa and ring_numa also need to=20 > initalize by default, otherwise port->socket_id will be probed to wrong v= alue. >=20 > Signed-off-by: Yulong Pei Thanks! Patch is fine. Could you add Fixes line for this patch? I think should be this commit? commit 999b2ee0fe4511c44462b29566f264e8d9326e1b Author: Bruce Richardson Date: Fri Mar 24 17:00:38 2017 +0000 app/testpmd: enable NUMA support by default There is little reason for NUMA support in testpmd to be off by default= , so enable it, and add in a new commandline parameter to disable it, if tha= t is wanted by users. Signed-off-by: Bruce Richardson