From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 473E2A04B5; Wed, 28 Oct 2020 21:32:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6735D4C9B; Wed, 28 Oct 2020 21:31:58 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 496BE4C97 for ; Wed, 28 Oct 2020 21:31:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603917114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RVKjAEjGpf5istBxJSRY6gAXB0x3Z0d+H6mSSHvtiCs=; b=OLpOq59PwL1SS5BwY50DaWpReBMwkPVwvp4NZv22V85S235UfsPhtYR3vem9RzesQswzFd yKdArQEut5M9iFUZ9ds0nh+5JbwVDLCOr1HNbuZmjWVKz1lqfSYFUw6ATDaDXAS0sAyHcp /rEZGi29nG997/F9kapODdGsuh8HG+g= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-95-bGR6s5SaPlG2SC_9JuuzLw-1; Wed, 28 Oct 2020 16:31:52 -0400 X-MC-Unique: bGR6s5SaPlG2SC_9JuuzLw-1 Received: by mail-oo1-f72.google.com with SMTP id r25so190009oop.0 for ; Wed, 28 Oct 2020 13:31:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=RVKjAEjGpf5istBxJSRY6gAXB0x3Z0d+H6mSSHvtiCs=; b=LVcCsBfk9y8OGZEtU4+dZ6bDmkJAS1YeKiXwKvJdnNNnAxhunfJEFUkarsqghLqBDp Y1wNepWkZVzXW6UKZW3bz3XrnIT7yndRkBP4l4tGYhHRYmjp781g4zKbjSu2mFXkRx52 FRwjqQyN7Atr4brCPMZUygRcpwTeLH8p38cOLiVnZWv6dUcTIwwBqrufa223LxXc5hUA zr6Dhkfu2ghWKTNp7+WSwll6tA/QsK65GL6C/2hOK9u+zHP/1cD4v7IrJ/s9ib7lqJgn XbfHJfpRsrPdGQms0R1ur7zo5mJsqlq/I86Acg2INs8ALjldbWP3KgqCSqmubmfsFYKM 5MAQ== X-Gm-Message-State: AOAM5309UtNUtY0oykqzT397Xw7T4Z18FUDT/JYbd22gSDEMFvFZZlNe Vhtw+9x9gL/EtjU9Kn8MwGPAT+c00NrbEJP/WVu/ZNjKZ+UK31AAA9+9/b2+GbVR8jgYDlYtvob b+Dw= X-Received: by 2002:a9d:2c29:: with SMTP id f38mr719112otb.245.1603917111757; Wed, 28 Oct 2020 13:31:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx31ZG3nGJ97VpMGInvzrkswDQv57I7xGdjCX1vE8o/j4+Z7i7qQNGquJ3SDtomwwKz/hTffQ== X-Received: by 2002:a9d:2c29:: with SMTP id f38mr719099otb.245.1603917111559; Wed, 28 Oct 2020 13:31:51 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id t15sm142835oih.33.2020.10.28.13.31.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Oct 2020 13:31:50 -0700 (PDT) To: "Chautru, Nicolas" , "dev@dpdk.org" , "akhil.goyal@nxp.com" Cc: "david.marchand@redhat.com" References: <1603496581-35966-1-git-send-email-nicolas.chautru@intel.com> <1603496581-35966-3-git-send-email-nicolas.chautru@intel.com> <667e9f79-6461-0d45-a60a-480e452a9277@redhat.com> From: Tom Rix Message-ID: <188de3eb-a1bf-b992-e24d-547c3f3721f2@redhat.com> Date: Wed, 28 Oct 2020 13:31:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v5 2/7] app/bbdev: add explicit check for counters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/26/20 9:29 AM, Chautru, Nicolas wrote: >> -----Original Message----- >> From: Tom Rix >> Sent: Monday, October 26, 2020 6:06 AM >> To: Chautru, Nicolas ; dev@dpdk.org; >> akhil.goyal@nxp.com >> Cc: david.marchand@redhat.com >> Subject: Re: [PATCH v5 2/7] app/bbdev: add explicit check for counters >> >> >> On 10/23/20 4:42 PM, Nicolas Chautru wrote: >>> Adding explicit check in ut that the stats counters have the expect >>> values. Was missing for coverage. >> missing from coverage >> >> ? > This was causing code coverage gap. Add 'code ' to make the context better. > >>> Signed-off-by: Nicolas Chautru >>> Acked-by: Aidan Goddard >>> Acked-by: Dave Burley >>> --- >>> app/test-bbdev/test_bbdev_perf.c | 17 +++++++++++++++++ >>> 1 file changed, 17 insertions(+) >>> >>> diff --git a/app/test-bbdev/test_bbdev_perf.c >>> b/app/test-bbdev/test_bbdev_perf.c >>> index 3554a77..b62848e 100644 >>> --- a/app/test-bbdev/test_bbdev_perf.c >>> +++ b/app/test-bbdev/test_bbdev_perf.c >>> @@ -4840,6 +4840,23 @@ typedef int (test_case_function)(struct >> active_device *ad, >>> (double)(time_st.deq_max_time * 1000000) / >>> rte_get_tsc_hz()); >>> >>> + struct rte_bbdev_stats stats = {0}; >> Other calls to get_bbdev_queue_stats do not initialize stats and likely should >>> + get_bbdev_queue_stats(ad->dev_id, queue_id, &stats); >> Should check the return here. >>> + if (op_type != RTE_BBDEV_OP_LDPC_DEC) { >> This logic seems off. >> >> Do you mean to check only enc stats with an enc op ? >> >> Similar for dec. > No that is intentional. That check would not be relavent for the LDPC_DEC tests as this may run more operations for the sake of HARQ preloading/retrieve. ok > >>> + TEST_ASSERT_SUCCESS(stats.enqueued_count != >> num_to_process, >>> + "Mismatch in enqueue count %10"PRIu64" >> %d", >>> + stats.enqueued_count, num_to_process); >>> + TEST_ASSERT_SUCCESS(stats.dequeued_count != >> num_to_process, >>> + "Mismatch in dequeue count %10"PRIu64" >> %d", >>> + stats.dequeued_count, num_to_process); >>> + } >>> + TEST_ASSERT_SUCCESS(stats.enqueue_err_count != 0, >>> + "Enqueue count Error %10"PRIu64"", >>> + stats.enqueue_err_count); >>> + TEST_ASSERT_SUCCESS(stats.dequeue_err_count != 0, >>> + "Dequeue count Error (%10"PRIu64"", >>> + stats.dequeue_err_count); >>> + >>> return TEST_SUCCESS; >>> #endif >>> }