From: Thomas Monjalon <thomas@monjalon.net>
To: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
Cc: dev@dpdk.org, yipeng1.wang@intel.com, sameh.gobriel@intel.com,
bruce.richardson@intel.com, konstantin.ananyev@intel.com,
stephen@networkplumber.org
Subject: Re: [dpdk-dev] [PATCH v5 5/5] test/thash: add performance tests for the Toeplitz hash
Date: Wed, 27 Oct 2021 10:29:13 +0200 [thread overview]
Message-ID: <1892628.myLnTpanUf@thomas> (raw)
In-Reply-To: <f443a8d0-7d00-af55-b80b-8c7d9505011d@intel.com>
26/10/2021 22:29, Medvedkin, Vladimir:
> Hi Thomas,
>
> Thanks for the review, I'll address your comments in v6.
> Please find my comment below
>
> On 25/10/2021 19:02, Thomas Monjalon wrote:
> > 21/10/2021 20:54, Vladimir Medvedkin:
> >> This patch adds performance tests for different implementations
> >> of the Toeplitz hash function.
> >
> > Please name them.
> >
> >> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> >
> > There are some garbage,
> >
> >> @@ -320,6 +321,7 @@ perf_test_names = [
> >> 'hash_readwrite_lf_perf_autotest',
> >> 'trace_perf_autotest',
> >> 'ipsec_perf_autotest',
> >> + 'thash_perf_autotest',
> >
> > here (tabs instead of space)
> >
> >> driver_test_names = [
> >> diff --git a/app/test/test_thash_perf.c b/app/test/test_thash_perf.c
> >> new file mode 100644
> >> index 0000000..fb66e20
> >> --- /dev/null
> >> +++ b/app/test/test_thash_perf.c
> >> @@ -0,0 +1,120 @@
> >> +/* SPDX-License-Identifier: BSD-3-Clause
> >> + * Copyright(c) 2021 Intel Corporation
> >> + */
> >> +
> >> +#include <stdio.h>
> >> +#include <stdint.h>
> >> +#include <stdlib.h>
> >> +#include <math.h>
> >> +
> >> +#include <rte_cycles.h>
> >> +#include <rte_malloc.h>
> >> +#include <rte_random.h>
> >> +#include <rte_thash.h>
> >> +
> >> +#include "test.h"
> >> +
> >> +#define ITERATIONS (1 << 15)
> >> +#define BATCH_SZ (1 << 10)
> >> +
> >> +#define IPV4_2_TUPLE_LEN (8)
> >> +#define IPV4_4_TUPLE_LEN (12)
> >> +#define IPV6_2_TUPLE_LEN (32)
> >> +#define IPV6_4_TUPLE_LEN (36)
> >> +
> >> +
> >> +static uint8_t default_rss_key[] = {
> >> + 0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2,
> >> + 0x41, 0x67, 0x25, 0x3d, 0x43, 0xa3, 0x8f, 0xb0,
> >> + 0xd0, 0xca, 0x2b, 0xcb, 0xae, 0x7b, 0x30, 0xb4,
> >> + 0x77, 0xcb, 0x2d, 0xa3, 0x80, 0x30, 0xf2, 0x0c,
> >> + 0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa,
> >> +};
> >> +
> >> +static void
> >> +run_thash_test(unsigned int tuple_len)
> >> +{
> >> + uint32_t *tuples[BATCH_SZ];
> >> + unsigned int i, j;
> >> + uint64_t start_tsc, end_tsc;
> >> + uint32_t len = RTE_ALIGN_CEIL(tuple_len, sizeof(uint32_t));
> >> + volatile uint32_t hash = 0;
> >> + uint32_t bulk_hash[BATCH_SZ] = { 0 };
> >> +
> >> + for (i = 0; i < BATCH_SZ; i++) {
> >> + tuples[i] = rte_zmalloc(NULL, len, 0);
> >> + for (j = 0; j < len / sizeof(uint32_t); j++)
> >> + tuples[i][j] = rte_rand();
> >> + }
> >> +
> >> + start_tsc = rte_rdtsc_precise();
> >> + for (i = 0; i < ITERATIONS; i++) {
> >> + for (j = 0; j < BATCH_SZ; j++) {
> >> + hash ^= rte_softrss(tuples[j], len / sizeof(uint32_t),
> >> + default_rss_key);
> >> + }
> >> + }
> >> + end_tsc = rte_rdtsc_precise();
> >> +
> >> + printf("Average rte_softrss() takes \t\t%.1f cycles for key len %d\n",
> >> + (double)(end_tsc - start_tsc) / (double)(ITERATIONS *
> >> + BATCH_SZ), len);
> >> +
> >> + start_tsc = rte_rdtsc_precise();
> >> + for (i = 0; i < ITERATIONS; i++) {
> >> + for (j = 0; j < BATCH_SZ; j++) {
> >> + hash ^= rte_softrss_be(tuples[j], len /
> >> + sizeof(uint32_t), default_rss_key);
> >> + }
> >> + }
> >> + end_tsc = rte_rdtsc_precise();
> >> +
> >> + printf("Average rte_softrss_be() takes \t\t%.1f cycles for key len %d\n",
> >> + (double)(end_tsc - start_tsc) / (double)(ITERATIONS *
> >> + BATCH_SZ), len);
> >
> > The function could stop here (one function per type of implementation).
> >
>
> Could you please clarify what do you mean?
> The function stops here if the machine do not support GFNI, and this is
> done intentionally. On machine without GFNI it tests only scalar
> implementations for every given length.
No I mean you can split in smaller functions.
> >> +
> >> + if (!rte_thash_gfni_supported())
> >> + return;
> >> +
> >> + uint64_t rss_key_matrixes[RTE_DIM(default_rss_key)];
> >> +
> >> + rte_thash_complete_matrix(rss_key_matrixes, default_rss_key,
> >> + RTE_DIM(default_rss_key));
> >> +
> >> + start_tsc = rte_rdtsc_precise();
> >> + for (i = 0; i < ITERATIONS; i++) {
> >> + for (j = 0; j < BATCH_SZ; j++)
> >> + hash ^= rte_thash_gfni(rss_key_matrixes,
> >> + (uint8_t *)tuples[j], len);
> >> + }
> >> + end_tsc = rte_rdtsc_precise();
> >> +
> >> + printf("Average rte_thash_gfni takes \t\t%.1f cycles for key len %d\n",
> >> + (double)(end_tsc - start_tsc) / (double)(ITERATIONS *
> >> + BATCH_SZ), len);
> >> +
> >> + start_tsc = rte_rdtsc_precise();
> >> + for (i = 0; i < ITERATIONS; i++)
> >> + rte_thash_gfni_bulk(rss_key_matrixes, len, (uint8_t **)tuples,
> >> + bulk_hash, BATCH_SZ);
> >> +
> >> + end_tsc = rte_rdtsc_precise();
> >> +
> >> + printf("Average rte_thash_gfni_x2 takes \t%.1f cycles for key len %d\n",
> >
> > and here, the function name is not updated.
> >
> >> + (double)(end_tsc - start_tsc) / (double)(ITERATIONS *
> >> + BATCH_SZ), len);
> >> +
> >
> > useless blank line
> >
> >> +}
next prev parent reply other threads:[~2021-10-27 8:29 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 16:03 [dpdk-dev] [PATCH 0/5] optimized Toeplitz hash implementation Vladimir Medvedkin
2021-09-06 16:03 ` [dpdk-dev] [PATCH 1/5] hash: add new toeplitz " Vladimir Medvedkin
2021-10-07 18:23 ` Ananyev, Konstantin
2021-10-08 11:19 ` Ananyev, Konstantin
2021-10-15 9:11 ` Medvedkin, Vladimir
2021-10-15 10:55 ` Ananyev, Konstantin
2021-10-15 13:09 ` Medvedkin, Vladimir
2021-09-06 16:03 ` [dpdk-dev] [PATCH 2/5] hash: enable gfni thash implementation Vladimir Medvedkin
2021-10-08 11:31 ` Ananyev, Konstantin
2021-10-15 9:13 ` Medvedkin, Vladimir
2021-09-06 16:03 ` [dpdk-dev] [PATCH 3/5] doc/hash: update documentation for the thash library Vladimir Medvedkin
2021-09-06 16:03 ` [dpdk-dev] [PATCH 4/5] test/thash: add tests for a new Toeplitz hash function Vladimir Medvedkin
2021-09-07 0:35 ` Stephen Hemminger
2021-09-08 13:59 ` Medvedkin, Vladimir
2021-09-06 16:03 ` [dpdk-dev] [PATCH 5/5] test/thash: add performance tests for the Toeplitz hash Vladimir Medvedkin
2021-10-15 9:30 ` [dpdk-dev] [PATCH v2 0/5] optimized Toeplitz hash implementation Vladimir Medvedkin
2021-10-20 18:20 ` [dpdk-dev] [PATCH v3 " Vladimir Medvedkin
2021-10-21 17:18 ` [dpdk-dev] [PATCH v4 " Vladimir Medvedkin
2021-10-21 18:54 ` [dpdk-dev] [PATCH v5 " Vladimir Medvedkin
2021-10-21 18:54 ` [dpdk-dev] [PATCH v5 1/5] hash: add new toeplitz " Vladimir Medvedkin
2021-10-25 17:05 ` Thomas Monjalon
2021-10-21 18:54 ` [dpdk-dev] [PATCH v5 2/5] hash: enable gfni thash implementation Vladimir Medvedkin
2021-10-21 18:54 ` [dpdk-dev] [PATCH v5 3/5] doc/hash: update documentation for the thash library Vladimir Medvedkin
2021-10-25 17:04 ` Thomas Monjalon
2021-10-26 20:30 ` Medvedkin, Vladimir
2021-10-21 18:54 ` [dpdk-dev] [PATCH v5 4/5] test/thash: add tests for a new Toeplitz hash function Vladimir Medvedkin
2021-10-21 18:54 ` [dpdk-dev] [PATCH v5 5/5] test/thash: add performance tests for the Toeplitz hash Vladimir Medvedkin
2021-10-25 17:02 ` Thomas Monjalon
2021-10-26 20:29 ` Medvedkin, Vladimir
2021-10-27 8:29 ` Thomas Monjalon [this message]
2021-10-27 15:48 ` Medvedkin, Vladimir
2021-10-25 17:27 ` Stephen Hemminger
2021-10-26 20:31 ` Medvedkin, Vladimir
2021-10-21 17:18 ` [dpdk-dev] [PATCH v4 1/5] hash: add new toeplitz hash implementation Vladimir Medvedkin
2021-10-21 17:18 ` [dpdk-dev] [PATCH v4 2/5] hash: enable gfni thash implementation Vladimir Medvedkin
2021-10-21 17:18 ` [dpdk-dev] [PATCH v4 3/5] doc/hash: update documentation for the thash library Vladimir Medvedkin
2021-10-21 17:18 ` [dpdk-dev] [PATCH v4 4/5] test/thash: add tests for a new Toeplitz hash function Vladimir Medvedkin
2021-10-21 17:18 ` [dpdk-dev] [PATCH v4 5/5] test/thash: add performance tests for the Toeplitz hash Vladimir Medvedkin
2021-10-20 18:20 ` [dpdk-dev] [PATCH v3 1/5] hash: add new toeplitz hash implementation Vladimir Medvedkin
2021-10-21 9:42 ` Ananyev, Konstantin
2021-10-21 17:17 ` Medvedkin, Vladimir
2021-10-20 18:20 ` [dpdk-dev] [PATCH v3 2/5] hash: enable gfni thash implementation Vladimir Medvedkin
2021-10-21 9:46 ` Ananyev, Konstantin
2021-10-20 18:20 ` [dpdk-dev] [PATCH v3 3/5] doc/hash: update documentation for the thash library Vladimir Medvedkin
2021-10-20 18:20 ` [dpdk-dev] [PATCH v3 4/5] test/thash: add tests for a new Toeplitz hash function Vladimir Medvedkin
2021-10-20 18:20 ` [dpdk-dev] [PATCH v3 5/5] test/thash: add performance tests for the Toeplitz hash Vladimir Medvedkin
2021-10-15 9:30 ` [dpdk-dev] [PATCH v2 1/5] hash: add new toeplitz hash implementation Vladimir Medvedkin
2021-10-15 16:58 ` Stephen Hemminger
2021-10-18 10:40 ` Ananyev, Konstantin
2021-10-19 1:15 ` Stephen Hemminger
2021-10-19 15:42 ` Medvedkin, Vladimir
2021-10-18 11:08 ` Medvedkin, Vladimir
2021-10-15 9:30 ` [dpdk-dev] [PATCH v2 2/5] hash: enable gfni thash implementation Vladimir Medvedkin
2021-10-15 9:30 ` [dpdk-dev] [PATCH v2 3/5] doc/hash: update documentation for the thash library Vladimir Medvedkin
2021-10-15 9:30 ` [dpdk-dev] [PATCH v2 4/5] test/thash: add tests for a new Toeplitz hash function Vladimir Medvedkin
2021-10-15 9:30 ` [dpdk-dev] [PATCH v2 5/5] test/thash: add performance tests for the Toeplitz hash Vladimir Medvedkin
2021-10-26 20:32 ` [dpdk-dev] [PATCH v6 0/4] optimized Toeplitz hash implementation Vladimir Medvedkin
2021-10-26 20:32 ` [dpdk-dev] [PATCH v6 1/4] hash: add new toeplitz " Vladimir Medvedkin
2021-10-26 20:32 ` [dpdk-dev] [PATCH v6 2/4] hash: add bulk " Vladimir Medvedkin
2021-10-26 20:32 ` [dpdk-dev] [PATCH v6 3/4] hash: enable gfni thash implementation Vladimir Medvedkin
2021-10-26 20:32 ` [dpdk-dev] [PATCH v6 4/4] test/thash: add performance tests for the Toeplitz hash Vladimir Medvedkin
2021-10-27 16:16 ` [dpdk-dev] [PATCH v7 0/4] optimized Toeplitz hash implementation Vladimir Medvedkin
2021-10-27 16:16 ` [dpdk-dev] [PATCH v7 1/4] hash: add new toeplitz " Vladimir Medvedkin
2021-10-27 16:16 ` [dpdk-dev] [PATCH v7 2/4] hash: add bulk " Vladimir Medvedkin
2021-10-27 16:16 ` [dpdk-dev] [PATCH v7 3/4] hash: enable gfni thash implementation Vladimir Medvedkin
2021-10-27 16:16 ` [dpdk-dev] [PATCH v7 4/4] test/thash: add performance tests for the Toeplitz hash Vladimir Medvedkin
2021-11-02 18:38 ` [dpdk-dev] [PATCH v8 0/4] optimized Toeplitz hash implementation Vladimir Medvedkin
2021-11-04 10:20 ` Thomas Monjalon
2021-11-02 18:38 ` [dpdk-dev] [PATCH v8 1/4] hash: add new toeplitz " Vladimir Medvedkin
2021-11-02 18:38 ` [dpdk-dev] [PATCH v8 2/4] hash: add bulk " Vladimir Medvedkin
2021-11-02 18:38 ` [dpdk-dev] [PATCH v8 3/4] hash: enable gfni thash implementation Vladimir Medvedkin
2021-11-02 18:38 ` [dpdk-dev] [PATCH v8 4/4] test/thash: add performance tests for the Toeplitz hash Vladimir Medvedkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1892628.myLnTpanUf@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=stephen@networkplumber.org \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).