From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 9F07A2BC9 for ; Thu, 10 Mar 2016 19:25:07 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id l68so40099275wml.1 for ; Thu, 10 Mar 2016 10:25:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=YsWRlfSg1lc7miX6kX3nkliDNjKi/kYIk5YPp0RVI4I=; b=C6qcoNWdQ6HuFfVoYOnV/LdKLJVEKQTdtmt/sKtpgvpp7zjoqomhRs/GSgVmDxAU6+ z3e9mEeyRd21z431DK/c/Wf8dzpzUNcDHeEp81voHhG2LXeJBhp7mr/HoU7Gtzi2GmAg oS93T9TQ5BYtDRMWVAm7wAheJH99/gxBmGfZEvhNQV/nPqjsmTsepdz1nHAv6Fw5I4DG lTNfj1ANDpDLJ1e5Op1oQ6FQvYiDPml6jWi5NGX667QxKgGvLyqcC9E/XZ+xCEKPpkTc 1yZzhmGzqUg/EAv1QH2J9t7HdU4qPTfne32ktCQzz0B7ythQjZ/DxzHRGLdQO126TZr/ mDkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=YsWRlfSg1lc7miX6kX3nkliDNjKi/kYIk5YPp0RVI4I=; b=cpV5sZPkhcbHc3zOAyoDA97zJS21j1rxgTcpdpYV44obJ6yd4c5eZvkqJCzsfdKlho T6NI5jEXD3Ea/MSz1ZZUordYuEOYw6UANN/uAT5wolfc82FjBlHuJ1sOLNT/+EkCoyGj 9vPhn+UaaOn2K8QFdZskRTqrm6ZYHlZC3JlY8+yuV3dmJf1H78/6btH01swrpHB/d5WW tQw8tUkHtOQrE5RYgySrOFc0NnCVt30ege5VBrtmV6Lb7ESrGKUhv5AGE9gMGAHT/n0s lLXKT8NIWvWp7kq9aSiHD7erPnXXdYHLHHgzarcX6Vb+c4kZ4ca9yRh6+JT50zCW7XZB iQNQ== X-Gm-Message-State: AD7BkJIX0JjCu8C7Pq7sucV6fsn+unEJzls70eeJKVWrC5TXitsSJh7kimwY7z5KbEZb9mHw X-Received: by 10.194.216.99 with SMTP id op3mr5588538wjc.26.1457634307525; Thu, 10 Mar 2016 10:25:07 -0800 (PST) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id h1sm3977409wme.8.2016.03.10.10.25.06 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 10 Mar 2016 10:25:06 -0800 (PST) From: Thomas Monjalon To: Marc Sune Date: Thu, 10 Mar 2016 19:23:25 +0100 Message-ID: <1894237.OM5rSysoGp@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1456961677-1116-1-git-send-email-marcdevel@gmail.com> References: <1456961677-1116-1-git-send-email-marcdevel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] cryptodev: fix RTE_PMD_DEBUG_TRACE redefinition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2016 18:25:07 -0000 2016-03-03 00:34, Marc Sune: > RTE_PMD_DEBUG_TRACE used RTE_FUNC_PTR_OR_ERR_RET was redefined > in rte_cryptodev_pmd.h which produced MACRO redefinition warnings > when including both rte_cryptodev_pmd.h and rte_ethdev.h. > > This commit moves MACRO definition to rte_cryptodev.c to prevent > this warning. It is not the right fix. This macro should probably be renamed with a crypto prefix or defined only once (same thing for ethdev). The function rte_pmd_debug_trace() and the macros RTE_PROC_PRIMARY_OR_ERR_RET, RTE_PROC_PRIMARY_OR_RET, RTE_FUNC_PTR_OR_ERR_RET, RTE_FUNC_PTR_OR_RET should not be in lib/librte_eal/common/include/rte_dev.h. The macros call RTE_PMD_DEBUG_TRACE which is defined elsewhere. The rte_log.h is probably a better place. But why these macros have no PMD prefix?