From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id CCBAD2C18 for ; Thu, 7 Mar 2019 12:33:29 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 81DAD36BB; Thu, 7 Mar 2019 06:33:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 07 Mar 2019 06:33:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=PEsTxVZmyjI38ivSOjX09UGvmWCPvEZWIodCQ2keM3A=; b=CWWCkaZlc2SZ g8QPjQX18nFjDR0vJfljBQc4EBTyFjRexKhFcz1yGyw+V1pMBq0IrPi/zq9FHDDb x6becfIHefb5pQPrARPFH8W2n/Y90yyvaOe+CMH/e8bumbM6he2GThbwubiqho/L Vz/0JKz6HiEOFKEwqZBBY5L6jDays1U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=PEsTxVZmyjI38ivSOjX09UGvmWCPvEZWIodCQ2keM 3A=; b=i7Wc9ig4PxFWTUKIniXd9mi6pZjsdeg3Qe5rMfVuTaD+G2n8UAJrPI54O TGDmOvkTnc7Aanr+Yeh5ekSlzFpkwr6oZhAL/fYd1iu7X0NUDWpFc9pdbFtLDLJC HxyLanMc5syCombCKRv8mghnVaPoBH/rX6Ueud/BG4G8YtMOFEaxbaGqL3Yw6Cfx FWVc9i5sPH7VUO79PGqPKwrrk7f2mBOxrN9rg5Xrn28T82w/OHuYtpqeteVX+Ohv TCW7AZ8PnsbrwNXYLma59T/21IYy9uAf+CZt+TvvZeMBZ91Bwt2/PWWWuwOAHgpY nb7i+0XznlQHmbg3VG/5/01G6H/iw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrfeekgdefudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepfihrohhnghdrqddqqdguvghvnecukfhppeejjedrudefgedrvddtfedrudek geenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnh gvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D1A98E4307; Thu, 7 Mar 2019 06:33:26 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: Anand Rawat , "dev@dpdk.org" , "Kadam, Pallavi" , "Menon, Ranjit" , "Shaw, Jeffrey B" Date: Thu, 07 Mar 2019 12:33:25 +0100 Message-ID: <18942651.9Y0FxRHys3@xps> In-Reply-To: <20190307102451.GB374484@bricha3-MOBL.ger.corp.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <2354479.T0gxW44koM@xps> <20190307102451.GB374484@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/6] eal: add header files to support windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2019 11:33:30 -0000 07/03/2019 11:24, Bruce Richardson: > On Thu, Mar 07, 2019 at 09:45:57AM +0100, Thomas Monjalon wrote: > > 07/03/2019 04:27, Anand Rawat: > > > On 3/6/2019 3:31 AM, Thomas Monjalon wrote: > > > > 06/03/2019 05:16, Anand Rawat: > > > >> Added header files to support windows on x86 platforms. > > > >> Updated rte_config to include rte_windows.h for windows > > > >> build. > > > > [...] > > > >> --- a/config/rte_config.h > > > >> +++ b/config/rte_config.h > > > >> +/* windows specific*/ > > > >> +#ifdef RTE_EXEC_ENV_WINDOWS > > > >> +#include > > > >> +#endif > > > > > > > > Include in the config file looks wrong. > > > > >> --- /dev/null > > > >> +++ b/lib/librte_eal/windows/eal/include/exec-env/rte_windows.h > > > > > > > > I think we could remove the sub-directory exec-env. > > > > Could we include this file from rte_common.h? > > > rte_windows.h defines types and substitution macros which are > > > needed to support common code on windows. So it should be > > > included as a global include for every library on windows. > > > rte_common.h is not included in all the source code and headers > > > we currently build for windows. > > > > I think it is not an issue adding some rte_common.h include > > here and there. > > > > I'd be hesitant about putting it in rte_common.h without knowing the > scope of the changes - "here and there" could end up being "everywhere". It's already almost everywhere, and I think it's normal, it is the meaning of "common". % git grep rte_common.h | wc -l 459 % git grep rte_common.h lib | fgrep .h: | wc -l 79 If some .c files doesn't have rte_common.h included directly or indirectly from other includes, it may be fixed. > Another alternative is to see if most/all the definitions could actually be > put in dpdk_conf and thereby go into the standard config.h file generated > at build time. Anything that couldn't be done via macros or defines in the > config could then look to be put maybe in rte_common.h or other locations, > perhaps. I think we should keep the semantic of what a config file is. I don't see the need of adding more than strict config in it.