DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 1/1] net/mlx5: fix flow shared action destroy error code
@ 2020-11-24 22:40 Thomas Monjalon
  2020-11-25  5:30 ` Tal Shnaiderman
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2020-11-24 22:40 UTC (permalink / raw)
  To: dev; +Cc: Matan Azrad, Shahaf Shuler, Viacheslav Ovsiienko, Andrey Vesnovaty

In the function rte_flow_shared_action_destroy(),
the errno ETOOMANYREFS has been replaced with EBUSY in the
commit dc328d1c555a ("ethdev: rename a flow shared action error code").

Another occurrence of ETOOMANYREFS, added later by mistake,
is replaced with EBUSY errno.

Fixes: fa7ad49e96b5 ("net/mlx5: fix shared RSS action update")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 253f598310..aa21ff9613 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -11541,7 +11541,7 @@ __flow_dv_action_rss_release(struct rte_eth_dev *dev, uint32_t idx,
 	queue = shared_rss->ind_tbl->queues;
 	remaining = mlx5_ind_table_obj_release(dev, shared_rss->ind_tbl, true);
 	if (remaining)
-		return rte_flow_error_set(error, ETOOMANYREFS,
+		return rte_flow_error_set(error, EBUSY,
 					  RTE_FLOW_ERROR_TYPE_ACTION,
 					  NULL,
 					  "shared rss indirection table has"
-- 
2.28.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH 1/1] net/mlx5: fix flow shared action destroy error code
  2020-11-24 22:40 [dpdk-dev] [PATCH 1/1] net/mlx5: fix flow shared action destroy error code Thomas Monjalon
@ 2020-11-25  5:30 ` Tal Shnaiderman
  2020-11-25 12:58   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Tal Shnaiderman @ 2020-11-25  5:30 UTC (permalink / raw)
  To: NBU-Contact-Thomas Monjalon, dev
  Cc: Matan Azrad, Shahaf Shuler, Slava Ovsiienko, Andrey Vesnovaty

> Subject: [dpdk-dev] [PATCH 1/1] net/mlx5: fix flow shared action destroy
> error code
> 
> External email: Use caution opening links or attachments
> 
> 
> In the function rte_flow_shared_action_destroy(), the errno
> ETOOMANYREFS has been replaced with EBUSY in the commit dc328d1c555a
> ("ethdev: rename a flow shared action error code").
> 
> Another occurrence of ETOOMANYREFS, added later by mistake, is replaced
> with EBUSY errno.
> 
> Fixes: fa7ad49e96b5 ("net/mlx5: fix shared RSS action update")
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c index 253f598310..aa21ff9613 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -11541,7 +11541,7 @@ __flow_dv_action_rss_release(struct
> rte_eth_dev *dev, uint32_t idx,
>         queue = shared_rss->ind_tbl->queues;
>         remaining = mlx5_ind_table_obj_release(dev, shared_rss->ind_tbl,
> true);
>         if (remaining)
> -               return rte_flow_error_set(error, ETOOMANYREFS,
> +               return rte_flow_error_set(error, EBUSY,
>                                           RTE_FLOW_ERROR_TYPE_ACTION,
>                                           NULL,
>                                           "shared rss indirection table has"
> --
> 2.28.0

Reviewed-by: Tal Shnaiderman <talshn@nvidia.com>
Tested-by: Tal Shnaiderman <talshn@nvidia.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH 1/1] net/mlx5: fix flow shared action destroy error code
  2020-11-25  5:30 ` Tal Shnaiderman
@ 2020-11-25 12:58   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2020-11-25 12:58 UTC (permalink / raw)
  To: Andrey Vesnovaty, Tal Shnaiderman
  Cc: dev, Matan Azrad, Slava Ovsiienko, asafp

> > In the function rte_flow_shared_action_destroy(), the errno
> > ETOOMANYREFS has been replaced with EBUSY in the commit dc328d1c555a
> > ("ethdev: rename a flow shared action error code").
> > 
> > Another occurrence of ETOOMANYREFS, added later by mistake, is replaced
> > with EBUSY errno.
> > 
> > Fixes: fa7ad49e96b5 ("net/mlx5: fix shared RSS action update")
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Reviewed-by: Tal Shnaiderman <talshn@nvidia.com>
> Tested-by: Tal Shnaiderman <talshn@nvidia.com>

Applied



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-25 12:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-24 22:40 [dpdk-dev] [PATCH 1/1] net/mlx5: fix flow shared action destroy error code Thomas Monjalon
2020-11-25  5:30 ` Tal Shnaiderman
2020-11-25 12:58   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git