From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 9DD211BD37 for ; Mon, 14 May 2018 01:44:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3607225E48; Sun, 13 May 2018 19:44:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 13 May 2018 19:44:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=lkacJ2ZqHc/UK5hLx7W2vAUvMs xgJ/BcsezQek7orEk=; b=MVClErBPfOvL4Uwy86mH1WiKJd1a5+o/EOeuSD+BDG mfEQVdGwWVoOH9k/ZEsb9Hnpb2wiFRl1nMQKkZJajqsauYxfOpcoFWkn43s8XwRo ePEmPkQBztYRdQKe8ppi9JY6Jsn7ZB19cKhlPh79s+UwAPU/KN15Nnxfa60vrlbD c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=lkacJ2 ZqHc/UK5hLx7W2vAUvMsxgJ/BcsezQek7orEk=; b=e3f4zeT2a4qFgOTd10dzaC CPvL1ahcv0k2Hj2xKKJoDC1oKYesaRNX2qerTsgCeKaIUGhm9/m4aEJO6YUG/ilA p9j4uQb7IhsvQV/GeMA3kfZ5XAc7U5dIT9iA3wgQ/xkxWebY8qi4G+ZjXaxfCQnf elnBSZob0oRNv0CsDznpUDvqdPjm/pMKf7nVYfSSFL9c0auVFJ25cWCEREFwPPr7 BvYtTdrfxhSHwhZo4phToqvNGsf3UsQIhBe4EnuFdV1BhhOCja4Q0d2fq6kz0GkR ARFMkYYhZV4SnxV+NEGmOVD5USyfSf8Cyfmc8eXRk0yglJjTwX7bFUY2jMQ+komA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6DC19E444A; Sun, 13 May 2018 19:44:57 -0400 (EDT) From: Thomas Monjalon To: Andy Green Cc: dev@dpdk.org, bruce.richardson@intel.com, olivier.matz@6wind.com Date: Mon, 14 May 2018 01:44:56 +0200 Message-ID: <1896621.ibENEg8Kdi@xps> In-Reply-To: <2c8be5ff-70ef-6081-31f5-bcbb8a0b1a18@warmcat.com> References: <152609021699.121661.5295227351721865436.stgit@localhost.localdomain> <1908380.h0rCPQG6nq@xps> <2c8be5ff-70ef-6081-31f5-bcbb8a0b1a18@warmcat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 08/24] rte_ring_generic.h: stack declarations before code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 May 2018 23:44:58 -0000 14/05/2018 01:21, Andy Green: > > On 05/14/2018 12:47 AM, Thomas Monjalon wrote: > > 12/05/2018 03:59, Andy Green: > >> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: > >> In function '__rte_ring_move_prod_head': > >> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:76:3: > >> warning: ISO C90 forbids mixed declarations and code > >> [-Wdeclaration-after-statement] > >> const uint32_t cons_tail = r->cons.tail; > >> ^~~~~ > >> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: > >> In function '__rte_ring_move_cons_head': > >> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:147:3: > >> warning: ISO C90 forbids mixed declarations and code > >> [-Wdeclaration-after-statement] > >> const uint32_t prod_tail = r->prod.tail; > > > > The fix line is: > > Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation") > > OK... people can just use git blame at the time they want to know this > though. No, we need it to automatically detect which commits should be backported, and in which branch. We also add Cc: stable@dpdk.org to confirm explicitly that is must be backported.