From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id AC223595B for ; Thu, 13 Nov 2014 10:53:21 +0100 (CET) Received: by mail-wg0-f48.google.com with SMTP id y19so5635036wgg.7 for ; Thu, 13 Nov 2014 02:03:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=+4Je3mUqT6SkWYCB8qn1jaRDH057m1YBImYhWzSbMDc=; b=Bmt1Bzf/l1maD33ySe8Gi62ZkHRksxL1qb99UBB7o6a4aw4FTQR3E88E+G0SUH9Jcg jzda0vRAl20rZY4XoPxJHRQ3UQ5CD++1O7ZSMUK8Zg3JXxnw7lfzmMCs6x197IRPu4QX P+PpQxDve5tbVynSwS9/vIJKFc/47iAVoduFkiuzfmIvV8K/EJI9jGFXI3qkVEdwKCtg 22CeZ+nQtfWukQBBxrmpUIriBbwl4+tEt7o7jvwPbtWSfqqs3F21d9utpQv568AZ2IC2 EBAAxnWtWiQTbSuc4sdyBxBc0MkM8yHfWk9dGoFo8C9NQ4wQFf8UYVb6dpIxIpKcV/ao uUBQ== X-Gm-Message-State: ALoCoQluDWz693zi29/gol9IOflALav4YCNrh+IxWZ4ntHt6kvP3E9HxuYugA8t9z9ugfAe+2Kz1 X-Received: by 10.194.121.34 with SMTP id lh2mr2460929wjb.72.1415872999716; Thu, 13 Nov 2014 02:03:19 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id s10sm25043758wix.14.2014.11.13.02.03.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Nov 2014 02:03:18 -0800 (PST) Date: Thu, 13 Nov 2014 02:03:18 -0800 (PST) X-Google-Original-Date: Thu, 13 Nov 2014 11:03 +0100 From: Thomas Monjalon To: Neil Horman , dev@dpdk.org, John Linville Message-ID: <1898542.t3c6y266ZQ@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <20141008191403.GB13306@hmsreliant.think-freely.org> References: <1405024369-30058-1-git-send-email-linville@tuxdriver.com> <4230474.fJnSGQJdQd@xps13> <20141008191403.GB13306@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Nov 2014 09:53:21 -0000 Hi Neil and John, I would like to wake up this very old thread. 2014-10-08 15:14, Neil Horman: > On Wed, Oct 08, 2014 at 05:57:46PM +0200, Thomas Monjalon wrote: > > 2014-09-29 11:05, Bruce Richardson: > > > On Fri, Sep 26, 2014 at 10:08:55AM -0400, Neil Horman wrote: > > > > On Fri, Sep 26, 2014 at 11:28:05AM +0200, Thomas Monjalon wrote: > > > > > 3) There is no test associated with this PMD. > > > > That would have been a great comment to make a few months back, though whats > > > > wrong with testpmd here? That seems to be the same test that every other pmd > > > > uses. What exactly are you looking for? > > > > I was thinking of testing behaviour with different kernel configurations and > > unit tests for --vdev options. But it's not a major blocker. > > > Thats fine with me. If theres a set of unit tests that you have documentation > for, I'm sure we would be happy to run them. I presume you just want all the > pmd vdev option exercised? Any specific sets of kernel configurations? I don't really know which tests are needed. It could be a mix of unit tests and functionnal tests described in a test plan. The goal is to be able to validate the behaviour and check there is no regression. Ideally some corner cases could be described. I'm OK to integrate it as is. But future maintenance will probably need such inputs for validation tests. > > If RedHat is committed for its maintenance, it could integrated in release 1.8. > > But I'd like it to be renamed as pmd_af_packet (or a better name) instead of > > pmd_packet. > > > John L. is on his way to plumbers at the moment, so is unable to comment, but > I'll try to get a few cycles to change the name of the PMD around. And yes, I > thought that maintenance was implicit. He's the author, of course he'll take > care of it :). And I'll be glad to help Do you have time in coming days to rebase and rename this PMD for inclusion in 1.8.0 release? Thanks -- Thomas