From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Robin Zhang <robinx.zhang@intel.com>, dev@dpdk.org
Cc: beilei.xing@intel.com, jingjing.wu@intel.com,
qiming.yang@intel.com, stevex.yang@intel.com
Subject: Re: [dpdk-dev] [PATCH 8/8] net/iavf: support check DD bit of a RX descriptor
Date: Thu, 8 Oct 2020 16:05:32 +0100 [thread overview]
Message-ID: <189b10b8-b58c-9fed-b5c4-f8b6acfa3a85@intel.com> (raw)
In-Reply-To: <20200927072626.28374-9-robinx.zhang@intel.com>
On 9/27/2020 8:26 AM, Robin Zhang wrote:
> Add implementation of inline API rx_descriptor_done in iavf PMD.
>
> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
> ---
> drivers/net/iavf/iavf_ethdev.c | 1 +
> drivers/net/iavf/iavf_rxtx.c | 26 ++++++++++++++++++++++++++
> drivers/net/iavf/iavf_rxtx.h | 1 +
> 3 files changed, 28 insertions(+)
>
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index 836c09f58..b7a819a0e 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -1417,6 +1417,7 @@ iavf_dev_init(struct rte_eth_dev *eth_dev)
> /* assign ops func pointer */
> eth_dev->dev_ops = &iavf_eth_dev_ops;
> eth_dev->rx_queue_count = iavf_dev_rxq_count;
> + eth_dev->rx_descriptor_done = iavf_dev_rx_desc_done;
> eth_dev->rx_descriptor_status = iavf_dev_rx_desc_status;
> eth_dev->tx_descriptor_status = iavf_dev_tx_desc_status;
Hi Robin,
'rx_descriptor_done' dev_ops is deprecated, 'rx_descriptor_status' should
provide same information?
Is there a specific reason/need to implement 'rx_descriptor_done'? If not I will
drop this patch.
next prev parent reply other threads:[~2020-10-08 15:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 7:26 [dpdk-dev] [PATCH 0/8] feature porting from i40evf to iavf Robin Zhang
2020-09-27 7:26 ` [dpdk-dev] [PATCH 1/8] net/iavf: use link status helper functions Robin Zhang
2020-09-27 7:26 ` [dpdk-dev] [PATCH 2/8] net/iavf: set min and max MTU for VF Robin Zhang
2020-09-27 7:26 ` [dpdk-dev] [PATCH 3/8] net/iavf: re-program promiscuous mode on VF interface Robin Zhang
2020-09-27 7:26 ` [dpdk-dev] [PATCH 4/8] net/iavf: optimize promiscuous ops Robin Zhang
2020-09-27 7:26 ` [dpdk-dev] [PATCH 5/8] net/iavf: add workaround promiscuous disable Robin Zhang
2020-09-27 7:26 ` [dpdk-dev] [PATCH 6/8] net/iavf: cleanup Tx buffers Robin Zhang
2020-09-27 7:26 ` [dpdk-dev] [PATCH 7/8] net/iavf: add extended stats Robin Zhang
2020-09-27 7:26 ` [dpdk-dev] [PATCH 8/8] net/iavf: support check DD bit of a RX descriptor Robin Zhang
2020-10-08 15:05 ` Ferruh Yigit [this message]
[not found] ` <fe7a8f1f1a1f45908c4094ccfc6b547d@intel.com>
2020-10-12 8:32 ` Ferruh Yigit
2020-10-13 5:58 ` Zhang, Qi Z
2020-10-08 12:23 ` [dpdk-dev] [PATCH 0/8] feature porting from i40evf to iavf Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=189b10b8-b58c-9fed-b5c4-f8b6acfa3a85@intel.com \
--to=ferruh.yigit@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qiming.yang@intel.com \
--cc=robinx.zhang@intel.com \
--cc=stevex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).