From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E331A04BC; Thu, 8 Oct 2020 17:07:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B47081C1A3; Thu, 8 Oct 2020 17:06:48 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id B8D3A1C190 for ; Thu, 8 Oct 2020 17:06:45 +0200 (CEST) IronPort-SDR: FQ3v8tIqN9tpevLgOApnjakbyP8XNbwPYAq+Ai5Mn2N5G4lligUxoKhf+0jzlo9N8qZfGqZ14c wuKiWMMWWxXw== X-IronPort-AV: E=McAfee;i="6000,8403,9768"; a="229536026" X-IronPort-AV: E=Sophos;i="5.77,351,1596524400"; d="scan'208";a="229536026" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2020 08:05:38 -0700 IronPort-SDR: elQ9FDWzJYPaLFiWePArfaYyryiAkFdraNNXvz2erFXTpr8JZuSfrIJEPv6UOIY0lrEqRg30+Y lDtYDBbZ/XSw== X-IronPort-AV: E=Sophos;i="5.77,351,1596524400"; d="scan'208";a="312235851" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.226.103]) ([10.213.226.103]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2020 08:05:36 -0700 To: Robin Zhang , dev@dpdk.org Cc: beilei.xing@intel.com, jingjing.wu@intel.com, qiming.yang@intel.com, stevex.yang@intel.com References: <20200927072626.28374-1-robinx.zhang@intel.com> <20200927072626.28374-9-robinx.zhang@intel.com> From: Ferruh Yigit Message-ID: <189b10b8-b58c-9fed-b5c4-f8b6acfa3a85@intel.com> Date: Thu, 8 Oct 2020 16:05:32 +0100 MIME-Version: 1.0 In-Reply-To: <20200927072626.28374-9-robinx.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 8/8] net/iavf: support check DD bit of a RX descriptor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/27/2020 8:26 AM, Robin Zhang wrote: > Add implementation of inline API rx_descriptor_done in iavf PMD. > > Signed-off-by: Robin Zhang > --- > drivers/net/iavf/iavf_ethdev.c | 1 + > drivers/net/iavf/iavf_rxtx.c | 26 ++++++++++++++++++++++++++ > drivers/net/iavf/iavf_rxtx.h | 1 + > 3 files changed, 28 insertions(+) > > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c > index 836c09f58..b7a819a0e 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -1417,6 +1417,7 @@ iavf_dev_init(struct rte_eth_dev *eth_dev) > /* assign ops func pointer */ > eth_dev->dev_ops = &iavf_eth_dev_ops; > eth_dev->rx_queue_count = iavf_dev_rxq_count; > + eth_dev->rx_descriptor_done = iavf_dev_rx_desc_done; > eth_dev->rx_descriptor_status = iavf_dev_rx_desc_status; > eth_dev->tx_descriptor_status = iavf_dev_tx_desc_status; Hi Robin, 'rx_descriptor_done' dev_ops is deprecated, 'rx_descriptor_status' should provide same information? Is there a specific reason/need to implement 'rx_descriptor_done'? If not I will drop this patch.