From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BA0FA034C; Tue, 18 Aug 2020 10:21:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C5B681C020; Tue, 18 Aug 2020 10:21:50 +0200 (CEST) Received: from qrelay163.mxroute.com (qrelay163.mxroute.com [172.82.139.163]) by dpdk.org (Postfix) with ESMTP id 1F48D1C014 for ; Tue, 18 Aug 2020 10:21:48 +0200 (CEST) Received: from filter003.mxroute.com ([168.235.111.26] 168-235-111-26.cloud.ramnode.com) (Authenticated sender: mN4UYu2MZsgR) by qrelay163.mxroute.com (ZoneMTA) with ESMTPA id 17400a8f3e50009e4b.001 for ; Tue, 18 Aug 2020 08:21:46 +0000 X-Zone-Loop: cd22ccb08020f6e9497f0f0fc6663da983cdea7dfb7a X-Originating-IP: [168.235.111.26] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter003.mxroute.com (Postfix) with ESMTPS id 15B5A60027; Tue, 18 Aug 2020 08:21:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0e6DXRa27bLIhZ4GGyNDIh/rUFX4e+OSfa1dUK9fq2I=; b=ZfJU7HRCA7BPKMfibrZ41jx30o AjVYXSkZc68D6pOCHbAGPHx+L03XKV/3zw0VHnu/tNNdP+GIWEpJFmq51Q6yOI1xDSE+qd2bn+VEV wTSm8MVbkUx4HTSc/HSWTECvvIitHw7t7uBrFLn6m2h2lqN95iFCjagOHTINFCxWxl5AtRX5ml8SJ PNU9Jc8qPftBjf+XjM4T6IT7B8hZLhfI0M1hUMVkr3xXIJUsSGfn4qbCLjUD0gxm0SNY8a+sC5BhP jA0twZ3aD8fKWAxQ3dlucgwOSdkcY+zThfQdknCF2fTa2UdnjIR9KdEtD9QfpKqewKJzcc8TRVEJY KJDX21tA==; To: Ferruh Yigit , Cristian Dumitrescu , Neil Horman Cc: dev@dpdk.org References: <20200817101819.1532616-1-ferruh.yigit@intel.com> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: <18af3592-97ab-6edb-18ea-828472624410@ashroe.eu> Date: Tue, 18 Aug 2020 09:21:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200817101819.1532616-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH] meter: remove experimental alias X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 17/08/2020 11:18, Ferruh Yigit wrote: > Remove ABI versioning for APIs: > 'rte_meter_trtcm_rfc4115_profile_config()' > 'rte_meter_trtcm_rfc4115_config()' > > The alias was introduced in > commit 60197bda97a0 ("meter: provide experimental alias for matured API") > > Signed-off-by: Ferruh Yigit > --- > lib/librte_meter/rte_meter.c | 73 ++------------------------ > lib/librte_meter/rte_meter_version.map | 7 --- > 2 files changed, 3 insertions(+), 77 deletions(-) > > diff --git a/lib/librte_meter/rte_meter.c b/lib/librte_meter/rte_meter.c > index 149cf58bdd..da01429a8b 100644 > --- a/lib/librte_meter/rte_meter.c > +++ b/lib/librte_meter/rte_meter.c > @@ -9,7 +9,6 @@ > #include > #include > #include > -#include > > #include "rte_meter.h" > > @@ -120,15 +119,8 @@ rte_meter_trtcm_config(struct rte_meter_trtcm *m, > return 0; > } > > -/* > - * ABI aliasing done for 'rte_meter_trtcm_rfc4115_profile_config' > - * to support both EXPERIMENTAL and DPDK_21 versions > - * This versioning will be removed on next ABI version (v20.11) > - * and '__rte_meter_trtcm_rfc4115_profile_config' will be restrored back to > - * 'rte_meter_trtcm_rfc4115_profile_config' without versioning. > - */ > -static int > -__rte_meter_trtcm_rfc4115_profile_config( > +int > +rte_meter_trtcm_rfc4115_profile_config( > struct rte_meter_trtcm_rfc4115_profile *p, > struct rte_meter_trtcm_rfc4115_params *params) > { > @@ -153,42 +145,7 @@ __rte_meter_trtcm_rfc4115_profile_config( > } > > int > -rte_meter_trtcm_rfc4115_profile_config_s( > - struct rte_meter_trtcm_rfc4115_profile *p, > - struct rte_meter_trtcm_rfc4115_params *params); > -int > -rte_meter_trtcm_rfc4115_profile_config_s( > - struct rte_meter_trtcm_rfc4115_profile *p, > - struct rte_meter_trtcm_rfc4115_params *params) > -{ > - return __rte_meter_trtcm_rfc4115_profile_config(p, params); > -} > -BIND_DEFAULT_SYMBOL(rte_meter_trtcm_rfc4115_profile_config, _s, 21); > -MAP_STATIC_SYMBOL(int rte_meter_trtcm_rfc4115_profile_config(struct rte_meter_trtcm_rfc4115_profile *p, > - struct rte_meter_trtcm_rfc4115_params *params), rte_meter_trtcm_rfc4115_profile_config_s); > - > -int > -rte_meter_trtcm_rfc4115_profile_config_e( > - struct rte_meter_trtcm_rfc4115_profile *p, > - struct rte_meter_trtcm_rfc4115_params *params); > -int > -rte_meter_trtcm_rfc4115_profile_config_e( > - struct rte_meter_trtcm_rfc4115_profile *p, > - struct rte_meter_trtcm_rfc4115_params *params) > -{ > - return __rte_meter_trtcm_rfc4115_profile_config(p, params); > -} > -VERSION_SYMBOL_EXPERIMENTAL(rte_meter_trtcm_rfc4115_profile_config, _e); > - > -/* > - * ABI aliasing done for 'rte_meter_trtcm_rfc4115_config' > - * to support both EXPERIMENTAL and DPDK_21 versions > - * This versioning will be removed on next ABI version (v20.11) > - * and '__rte_meter_trtcm_rfc4115_config' will be restrored back to > - * 'rte_meter_trtcm_rfc4115_config' without versioning. > - */ > -static int > -__rte_meter_trtcm_rfc4115_config( > +rte_meter_trtcm_rfc4115_config( > struct rte_meter_trtcm_rfc4115 *m, > struct rte_meter_trtcm_rfc4115_profile *p) > { > @@ -203,27 +160,3 @@ __rte_meter_trtcm_rfc4115_config( > > return 0; > } > - > -int > -rte_meter_trtcm_rfc4115_config_s(struct rte_meter_trtcm_rfc4115 *m, > - struct rte_meter_trtcm_rfc4115_profile *p); > -int > -rte_meter_trtcm_rfc4115_config_s(struct rte_meter_trtcm_rfc4115 *m, > - struct rte_meter_trtcm_rfc4115_profile *p) > -{ > - return __rte_meter_trtcm_rfc4115_config(m, p); > -} > -BIND_DEFAULT_SYMBOL(rte_meter_trtcm_rfc4115_config, _s, 21); > -MAP_STATIC_SYMBOL(int rte_meter_trtcm_rfc4115_config(struct rte_meter_trtcm_rfc4115 *m, > - struct rte_meter_trtcm_rfc4115_profile *p), rte_meter_trtcm_rfc4115_config_s); > - > -int > -rte_meter_trtcm_rfc4115_config_e(struct rte_meter_trtcm_rfc4115 *m, > - struct rte_meter_trtcm_rfc4115_profile *p); > -int > -rte_meter_trtcm_rfc4115_config_e(struct rte_meter_trtcm_rfc4115 *m, > - struct rte_meter_trtcm_rfc4115_profile *p) > -{ > - return __rte_meter_trtcm_rfc4115_config(m, p); > -} > -VERSION_SYMBOL_EXPERIMENTAL(rte_meter_trtcm_rfc4115_config, _e); > diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_meter/rte_meter_version.map > index e2a2607f28..b67f860b15 100644 > --- a/lib/librte_meter/rte_meter_version.map > +++ b/lib/librte_meter/rte_meter_version.map > @@ -10,10 +10,3 @@ DPDK_21 { > > local: *; > }; > - > -EXPERIMENTAL { > - global: > - > - rte_meter_trtcm_rfc4115_config; > - rte_meter_trtcm_rfc4115_profile_config; > -}; > Acked-by: Ray Kinsella