* [dpdk-dev] [PATCH] ethdev: remove unused variable
@ 2019-02-14 16:29 Thomas Monjalon
2019-02-14 17:34 ` Andrew Rybchenko
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2019-02-14 16:29 UTC (permalink / raw)
To: Ferruh Yigit, Andrew Rybchenko; +Cc: dev, stable
When removing the old attach function, the racy variable for getting
the last port id became unused.
Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
lib/librte_ethdev/rte_ethdev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 3b1d1a560..a2b63951f 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -48,7 +48,6 @@ int rte_eth_dev_logtype;
static const char *MZ_RTE_ETH_DEV_DATA = "rte_eth_dev_data";
struct rte_eth_dev rte_eth_devices[RTE_MAX_ETHPORTS];
-static uint16_t eth_dev_last_created_port;
/* spinlock for eth device callbacks */
static rte_spinlock_t rte_eth_dev_cb_lock = RTE_SPINLOCK_INITIALIZER;
@@ -445,8 +444,6 @@ eth_dev_get(uint16_t port_id)
eth_dev->data = &rte_eth_dev_shared_data->data[port_id];
- eth_dev_last_created_port = port_id;
-
return eth_dev;
}
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: remove unused variable
2019-02-14 16:29 [dpdk-dev] [PATCH] ethdev: remove unused variable Thomas Monjalon
@ 2019-02-14 17:34 ` Andrew Rybchenko
2019-02-18 17:40 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Rybchenko @ 2019-02-14 17:34 UTC (permalink / raw)
To: Thomas Monjalon, Ferruh Yigit; +Cc: dev, stable
On 2/14/19 7:29 PM, Thomas Monjalon wrote:
> When removing the old attach function, the racy variable for getting
> the last port id became unused.
>
> Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: remove unused variable
2019-02-14 17:34 ` Andrew Rybchenko
@ 2019-02-18 17:40 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2019-02-18 17:40 UTC (permalink / raw)
To: Andrew Rybchenko, Thomas Monjalon; +Cc: dev, stable
On 2/14/2019 5:34 PM, Andrew Rybchenko wrote:
> On 2/14/19 7:29 PM, Thomas Monjalon wrote:
>> When removing the old attach function, the racy variable for getting
>> the last port id became unused.
>>
>> Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-18 17:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-14 16:29 [dpdk-dev] [PATCH] ethdev: remove unused variable Thomas Monjalon
2019-02-14 17:34 ` Andrew Rybchenko
2019-02-18 17:40 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).