From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 464ECA09FD; Fri, 18 Dec 2020 19:42:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 92ED1CAD1; Fri, 18 Dec 2020 19:42:34 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1EF7ADE0 for ; Fri, 18 Dec 2020 19:42:32 +0100 (CET) IronPort-SDR: 2G0Yowg8iF2//WSoc2bFX1XXV4COMMLBtX7C066PzMogZSmW+nVM/CgOhsBiFt2o65wcs2ehKA hOKuJNZ5DTTA== X-IronPort-AV: E=McAfee;i="6000,8403,9839"; a="162535546" X-IronPort-AV: E=Sophos;i="5.78,431,1599548400"; d="scan'208,217";a="162535546" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2020 10:42:31 -0800 IronPort-SDR: cKt/KS11R4XLd1M1yE3KsXYqU32dBKrHtTxL6NU8XFddDdf9VDM+79dkfYIGLkV2WIBBs6gIXy nSCY8HTgIB5A== X-IronPort-AV: E=Sophos;i="5.78,431,1599548400"; d="scan'208,217";a="354144218" Received: from pkadam-mobl1.amr.corp.intel.com (HELO [10.212.192.23]) ([10.212.192.23]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2020 10:42:30 -0800 To: Thomas Monjalon Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com, talshn@nvidia.com, ferruh.yigit@intel.com, bruce.richardson@intel.com, beilei.xing@intel.com, jia.guo@intel.com References: <20201205011020.6276-1-pallavi.kadam@intel.com> <20201217225909.3580-1-pallavi.kadam@intel.com> <20201217225909.3580-3-pallavi.kadam@intel.com> <25941361.SrvSYD6x84@thomas> From: "Kadam, Pallavi" Message-ID: <18c56887-cfc1-2905-4f62-ab978cf8dc62@intel.com> Date: Fri, 18 Dec 2020 10:42:30 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <25941361.SrvSYD6x84@thomas> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 2/2] build: i40e PMD on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, On 12/18/2020 3:27 AM, Thomas Monjalon wrote: > 17/12/2020 23:59, Pallavi Kadam: >> Adds temp folder mlx5/windows as it is required to build this patch >> without any build error. This folder will be removed once mlx5 PMD >> patches are merged. > Why is it required? The patch [1] already supports Windows build for mlx5 PMD. However, there is no Windows folder in the current main branch and this gives following error when building with meson after entire "net" dir is enabled: drivers\net\mlx5\meson.build:56:0: ERROR: Non-existent build file 'drivers\\net/mlx5\\windows\\meson.build' [1]http://patches.dpdk.org/patch/70839/ > >> +if is_windows >> + build = false >> + reason = 'Not supported on Windows' >> + subdir_done() >> +endif > As you can see in other files, the reason starts always with a lowercase letter. > Please replace the first capital letter. Ok. I'll replace first capital letter in v3. Thanks! > >