From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A6D1A0C41; Wed, 15 Sep 2021 18:53:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5340641149; Wed, 15 Sep 2021 18:53:33 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 232C04068F for ; Wed, 15 Sep 2021 18:53:30 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="201879122" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="201879122" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 09:53:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="471006546" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga007.fm.intel.com with ESMTP; 15 Sep 2021 09:53:30 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 09:53:29 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 15 Sep 2021 09:53:29 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 15 Sep 2021 09:53:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DMZawjqrnX+to8sWFygYuxgSMXHaYIdbX2BewF4R0X9MQbxmuCJjY4t0BPxx637Pj8CHCRu3Xm1TTkW6Qaevv2LNZlLZUxglTZvZpV9CgNNuJUcomwZcLtVb/WjpAt+AKnqM7oWDDreJz2l0lOAWUgs34Pr9ZuBPVpFPT/lbAXjQuweF8bLjW8vxnX8+uNSqF9OJ9dst8r5J5kV73yncAKt9H60+9UfAbtKuH9axQZNdknC9Tlh9F/QsPWOMKKQ/sNH/sEvxiSpbXJkQ6b+jiaS8bR9zK7PcjBDhxcgmpp4roX6o4OdIB3RMK4WUocivB6vx3acHvPijp7xsSjGNZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4gJuppAHBXDhuP2OmQsKdJLk4hjlVmecQVg7HrPu/6I=; b=GJQ3UpxexstjlS2ueLUhNlTwfL8kwR8VQlpxhOwHMZGjXcKYdb5DbR0vewokJQNEmenxSbUAwaHnQZu2JZqqpcOV0S7u4mEWei8lFie3mKGCklo5BIUtH6YaSrtobYK2NLp6G2l5j8AvByaflGzJv7UqVrdddLmsVj1A0uFD6wyUBOhJuKkz8vbeKkNuPGc69QPxHAtOgAd+ovVPkTm+UaoZluqX7+Xb06KR87AfY6VWyyIpZvcLzz/PFByFZpkv9C/L6lzvQVMLjJ/pxuVskac7gBSZqHhVqLjnYavw4ntLnebdU4bofTv9SC8uEmEXQfWUfkZ5O+QHenwI8mQu5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4gJuppAHBXDhuP2OmQsKdJLk4hjlVmecQVg7HrPu/6I=; b=gUVpK1EZ3SlJs19oR73pVV9eUMWlmsvHXr19MffN5qAAVNOy5brQuaYqufj7XeOKLfpZbFws4qPc/fV/tZBv+paWQf3TN42YcQSqumsPXVNri9mF4IdFVfglngV0zScyHUaUT4glxzbBA8080bjB8LQTOsR8s9DZUtwzr9u/yPI= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4887.namprd11.prod.outlook.com (2603:10b6:510:30::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Wed, 15 Sep 2021 16:53:28 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4500.019; Wed, 15 Sep 2021 16:53:28 +0000 To: Jiawen Wu , References: <20210908083758.312055-1-jiawenwu@trustnetic.com> <20210908083758.312055-13-jiawenwu@trustnetic.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <18d3a4b8-f649-306b-2824-a45c6d2013cf@intel.com> Date: Wed, 15 Sep 2021 17:53:22 +0100 In-Reply-To: <20210908083758.312055-13-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6P195CA0008.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::18) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6P195CA0008.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16 via Frontend Transport; Wed, 15 Sep 2021 16:53:27 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f6d9c145-5216-438c-a8ff-08d97869572f X-MS-TrafficTypeDiagnostic: PH0PR11MB4887: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:913; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L+Eeo7Vn5ZUkns4+spguphvL0UjVyXDMoZqusITyWAaTy0vH3624AVPF0A9KNhJGi+82LdL/+vzaEcI8KinNUzW1CfkJkJJ7gpXjlg6PIk20jPT9iJ4rSnh43i9peR0tkI1U6beBbfVnlG7l1G+/PUuCLKR3y6ZBtOcBbGjr9IXUEI4CQG4RkRVgdEP6Po8dTy+EBNJ05KOOxKcFyrLhTqnL3N7dncQmkjYlu4Szq9vu9HEUrdVoDE3Mm7uPSwPICeNIlkNIBYQc0mMSbAJz2pqdbFQjz01gIvzGB+gZdUhaGZuaeeHCLH4zBajsGTyfWvOBcB+Y5ukZcaVNX+LFgF6l83b5WB7OXl7LDGqRPLpmOsc8uYzyo3VAnt9hSPzC80Kgg2RqfA1XuVO1i/UdASlM5dmHEapWRxn5MdWtBi4AiLfjtdeNJrbu/I22X+YgLV53fmaTjb0yi6/imls9VhmZkNF+iMZgqTL7oLucmBrZERRrq+RLcAbupqb6EkjjmX8g+NB8DwcaxY6be1hh8lc6cSskIWF2ThJG5GfCFss8Rh8RHFBAxqzAewROG8pIUJlfZ5UhefYzkS2NktMlAPZFF5ffDuyz12Fs8Gisks73UjXqeGW32Oqwif3DZdwWIs0R0YftCWmr7PWCiUDsh+MoTrDMKv1KqKuw/KZEEWKppAvZOPWClwhxEsqYagqjvgSYu+TFa63OV1u4+tm5Gw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66946007)(66476007)(956004)(66556008)(2616005)(31696002)(86362001)(38100700002)(36756003)(8936002)(4744005)(2906002)(53546011)(8676002)(5660300002)(26005)(186003)(316002)(31686004)(6486002)(6666004)(16576012)(44832011)(508600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SG92UUNRdFl1Tlg3M29wMmVBZ1NWa3pFa0FwMU1sd2x3TlkybUVQZ2drZHl4?= =?utf-8?B?Mk5pd0dzaE0rU2FWcE9XR04xQ1R2SS80ZFM1Znl4bkVIcUlIVTNUcFBRK2FZ?= =?utf-8?B?cGVBNE1WR0RPemd6OW1SSTU2OFJvTUlpT0RnVHJQb1VMMEpEMi8wSG5nNk15?= =?utf-8?B?SXlwS1lRNWZHUUVZMm9tLy90SVVMY2NwTkdtTk1HbkZYRDB3d0NYay90Tzlo?= =?utf-8?B?bHhpRGZmSUgwRnlValhKSmRKbHVpVzFJbmdwcGU3V1NJV2hJTGUvd2MwZ1ZV?= =?utf-8?B?VEZ5cXhUeDRVcFcvL1cvaU05QnAvVjBlU3VNWEdtYmFWM3ErZXZSSllMV3M3?= =?utf-8?B?VTVGeExzUkNsdGIxczRkbzNnNWluQlNZY1hoeFJsRUc4VGNGRnlBd2ZoRUNm?= =?utf-8?B?a2RodW9GQkg2Y3o3MDkxRVVEdHJ4aXJzWkJWUFFFU3VHRkE4b0ZsM3dPZEU4?= =?utf-8?B?TTZ3QURMcXF6RTNyNno1Ny8rQXpmb3phQ29MYjN6eTBWWWt0NExCeGI0RUs5?= =?utf-8?B?dlRQM2pxL1p2dCtLRjh4Z0FKUEVoU1NVMWRHb2szYnd1cnFZT2hCaDMwMzNO?= =?utf-8?B?bCtxMjZJdHVTcDdNUlhsd24zcElTbW9LQXROa0pUYzF4V2NXaHlLcDZmZFBZ?= =?utf-8?B?T3NmY1lKdUxIQU9GM2U3TzdYWnlhZjRGRm5iRktZRGVQb2RmdXNqUTI2SjVT?= =?utf-8?B?U0dUUUx0RWNieW1zSG0yNjNjSThwellBdmpJQzhTcXdEYkQzTVBxYVBYVFFr?= =?utf-8?B?Y08rNEtaa1J6Yi9SRmdpc0IwUXdCK2NwSitVWDdYZkdUUzhtcHNjd1R4N1VV?= =?utf-8?B?ZTNQUmhwQVhpOXhORHdqZU9UWVVjZ0J6SnRHZ1VydFRTa0JyaU5DUWNJRlJG?= =?utf-8?B?aFN1TDF0clZja1JpcWRKUDBuSEVad3FtT0tuZ3JRWTcreWxsNDhUbXk5YVBx?= =?utf-8?B?Z1AzdllCYWtEVFQ2dVFwWnJtWHkrbENQMHNIVlVQVVdLT2FMU3lGSjBXdWkz?= =?utf-8?B?dzlmMEVUbzNwRVhEaTZ5R1haUEJ2eFh5QVBFbHg5bTl5cFFTQ1llUEduUlIw?= =?utf-8?B?M2J2TkZqL1lPdVBVNTdFY0dkUTR5V3h4WDdMSnNPVGg0OWNrZ21hUjY1aVUz?= =?utf-8?B?SGx2SStrVU5GbVF1VmFESkpWSlRTK3UxQTVZTG1HU1Zra1VIQTVTb0dyRUFz?= =?utf-8?B?YldlYzZlMkdwc1k3Nk03LyswYXhMUkNqUStwSEFmUjFqRmdPUlJJWkNKU3V0?= =?utf-8?B?QXNycjN0VGNUWXFIZmZLendWckM3b1pUL3duVnRKeVc2UllJUzFmVWsrWFpK?= =?utf-8?B?QWduak9VYXdNTnQ0bGFUcWtCdy81ek5CMDI5YVkwZm15Vm9sUGRqV05lUlZE?= =?utf-8?B?Yi96OHNmUVNnWHBLS3dzd3Q5Wm55SHEwQlNralpySzZDaThVZFVFZmdvS1Nw?= =?utf-8?B?VlJ6NFZFdXJRZGFSV3psd3gxektvbU9raHEwaS9XeXpqeEhRNWxjcjYxdWVz?= =?utf-8?B?Y080cW9MMFl6bFVOK3FlVjVPRlppWWlWYm9xbnFXTFpSU0packp6TTVRK3NG?= =?utf-8?B?TWZrYTR2ZytXNTZxS0RlSGtJQytLL3dxb3lDOElldkhYY2h0c1RZZ0d1V1pt?= =?utf-8?B?a2pWcHZvWDVURGJjMnRQb2MraEdsSVpTNkJIbHM2WXpDU051U1QyYUxENm1n?= =?utf-8?B?VjNQQmRQUDlBYlhVbkxPS2ZBaWlnU3Qrd1BxRWNlcUpiTnFqQlIyK3hoSit0?= =?utf-8?Q?Ju2yL3oPtqQfac7h0kmSSAIY788/MEDms9tFpui?= X-MS-Exchange-CrossTenant-Network-Message-Id: f6d9c145-5216-438c-a8ff-08d97869572f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 16:53:28.1297 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wFkoJYvnb7zoKELAgEouK2yx7hwP287o+g7sEF3hb8eK+A8e73WUu+4uO9KFiYaVmSpP++mrfiDT6RbzyMlAsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4887 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 12/32] net/ngbe: support getting FW version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Add firmware version get operation. > > Signed-off-by: Jiawen Wu <...> > +static int > +ngbe_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size) > +{ > + struct ngbe_hw *hw = ngbe_dev_hw(dev); > + int ret; > + > + ret = snprintf(fw_version, fw_size, "0x%08x", hw->eeprom_id); > + > + if (ret < 0) > + return -EINVAL; > + > + ret += 1; /* add the size of '\0' */ > + if (fw_size < (size_t)ret) > + return ret; > + else > + return 0; You can drop 'else' leg of the branch. > + > + return 0; > +} > + <...>