DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Nicolas Chautru <nicolas.chautru@intel.com>,
	dev@dpdk.org, akhil.goyal@nxp.com, thomas@monjalon.net,
	David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [20.11, PATCH v2] baseband/fpga_5gnr_fec: add companion PF config App
Date: Fri, 31 Jul 2020 12:35:36 +0200	[thread overview]
Message-ID: <18daf845-298b-43c9-2e2a-316d64cec9fd@redhat.com> (raw)
In-Reply-To: <1594930811-12873-2-git-send-email-nicolas.chautru@intel.com>

Hi Nicolas,

On 7/16/20 10:20 PM, Nicolas Chautru wrote:
> Adding companion application to configure HW Device from the PF.
> Then the device can be accessed through BBDEV from VF (or PF).
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>  doc/guides/bbdevs/fpga_5gnr_fec.rst                |  80 +++--
>  .../baseband/fpga_5gnr_fec/pf_config_app/Makefile  |  36 +++
>  .../fpga_5gnr_fec/pf_config_app/config_app.c       | 333 +++++++++++++++++++
>  .../pf_config_app/fpga_5gnr_cfg_app.c              | 351 +++++++++++++++++++++
>  .../pf_config_app/fpga_5gnr_cfg_app.h              | 102 ++++++
>  .../pf_config_app/fpga_5gnr_cfg_parser.c           | 187 +++++++++++
>  .../pf_config_app/fpga_5gnr_config.cfg             |  18 ++
>  7 files changed, 1087 insertions(+), 20 deletions(-)
>  create mode 100644 drivers/baseband/fpga_5gnr_fec/pf_config_app/Makefile
>  create mode 100644 drivers/baseband/fpga_5gnr_fec/pf_config_app/config_app.c
>  create mode 100644 drivers/baseband/fpga_5gnr_fec/pf_config_app/fpga_5gnr_cfg_app.c
>  create mode 100644 drivers/baseband/fpga_5gnr_fec/pf_config_app/fpga_5gnr_cfg_app.h
>  create mode 100644 drivers/baseband/fpga_5gnr_fec/pf_config_app/fpga_5gnr_cfg_parser.c
>  create mode 100644 drivers/baseband/fpga_5gnr_fec/pf_config_app/fpga_5gnr_config.cfg

I think having the pf_config_app in the driver directory is not a good
idea, this is not the place for applications.

Also, it is not integrated in the DPDK build system, so it cannot
benefit from the CI. Having an external dependency that is not packaged
in distributions will not help to have it integrated in the build

I see some alternatives:
1. Move it in another directory in the main DPDK repo, but it is not a
DPDK example, not a dev tool and not a build tool, so it would need a
new directory.
2. Create a BBDEV tools repository on dpdk.org (It would require
techboard approval).
3. Host it in a dedicated repository on Intel's github
4. Move it into some Intel FPGA tools repository

I think option 3 would be the best to get it packaged into
distributions as it has no build dependency with any DPDK library.
You could maybe add inih library as a git sub-repository within this
repo. Other advantage is you wouldn't depend on DPDK release cycles to
get fixes merged.

Regarding the tool itself, I understand from the commit message that the
tool has a dependency on the BBDEV PMD version, but the tool run on the
host while the PMD driver is used in the guest/container. So having it
in the driver directory will not really help, as host DPDK (if any) and
guest DPDK may come from different parties.

One question I have is whether this is the tool itself that has a
dependency on the PMD, or just the config file?


  reply	other threads:[~2020-07-31 10:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 20:20 [dpdk-dev] [20.11, PATCH v2] BBDEV FPGA PF Config app Nicolas Chautru
2020-07-16 20:20 ` [dpdk-dev] [20.11, PATCH v2] baseband/fpga_5gnr_fec: add companion PF config App Nicolas Chautru
2020-07-31 10:35   ` Maxime Coquelin [this message]
2020-07-31 15:17     ` Chautru, Nicolas
2020-08-03  8:25       ` Maxime Coquelin
2020-08-03 16:18         ` Chautru, Nicolas
2020-08-04  8:49           ` Maxime Coquelin
2020-08-05  8:51             ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18daf845-298b-43c9-2e2a-316d64cec9fd@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=akhil.goyal@nxp.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=nicolas.chautru@intel.com \
    --cc=thomas@monjalon.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).