From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 040F5271 for ; Wed, 20 Dec 2017 02:51:47 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2017 17:51:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,429,1508828400"; d="scan'208";a="13218271" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.69]) ([10.241.225.69]) by FMSMGA003.fm.intel.com with ESMTP; 19 Dec 2017 17:51:46 -0800 To: Stephen Hemminger , dev@dpdk.org References: <20171219063840.18981-1-stephen@networkplumber.org> <20171219063840.18981-3-stephen@networkplumber.org> From: Ferruh Yigit Message-ID: <18dc54df-4a30-da3c-209c-9794f01f8ab3@intel.com> Date: Tue, 19 Dec 2017 17:51:46 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171219063840.18981-3-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 02/11] bnx2x: implement dynamic logging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 01:51:48 -0000 On 12/18/2017 10:38 PM, Stephen Hemminger wrote: > Replace compile time option for init and driver log with > dynamic value. > > Signed-off-by: Stephen Hemminger > --- > config/common_base | 2 -- > doc/guides/nics/bnx2x.rst | 8 -------- > drivers/net/bnx2x/bnx2x_ethdev.c | 15 +++++++++++++++ > drivers/net/bnx2x/bnx2x_logs.h | 17 ++++++----------- > 4 files changed, 21 insertions(+), 21 deletions(-) > > diff --git a/config/common_base b/config/common_base > index f775ec96184c..82d1f9ac47ef 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -244,8 +244,6 @@ CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=8 > # Compile burst-oriented Broadcom PMD driver > # > CONFIG_RTE_LIBRTE_BNX2X_PMD=n > -CONFIG_RTE_LIBRTE_BNX2X_DEBUG=n There are a few "#ifdef RTE_LIBRTE_BNX2X_DEBUG" usage remains in the code which is causing build error.