From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 8B8ECA0C4B;
Sun, 12 Sep 2021 14:42:28 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 0F81C40041;
Sun, 12 Sep 2021 14:42:28 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [216.205.24.124])
by mails.dpdk.org (Postfix) with ESMTP id C12054003D
for <dev@dpdk.org>; Sun, 12 Sep 2021 14:42:26 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1631450545;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=DdU7nW3kOIREFzTCwVwetdGStlPaDpNKdo+kuDd2UuY=;
b=dYNZrxv1YCeqeDHTzEQChA+sTWVZVWWv1+i6pAqo4WyxkeWtFp5BFa+sRdNvIsOJ6ieIrz
++sygHaytpUuhpttiNtEJgpODmuupe1SasKPp11XI55YJIulQfP+cLwMc282PR6vCa66Bb
xMVKYeV2z2W9DPVYMTMSUmn1/zPydyU=
Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com
[209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-407-aOz14nqyMoGTr8XSNivdsQ-1; Sun, 12 Sep 2021 08:42:24 -0400
X-MC-Unique: aOz14nqyMoGTr8XSNivdsQ-1
Received: by mail-qk1-f199.google.com with SMTP id
21-20020a370815000000b003d5a81a4d12so38843193qki.3
for <dev@dpdk.org>; Sun, 12 Sep 2021 05:42:24 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:subject:to:cc:references:from:message-id:date
:user-agent:mime-version:in-reply-to:content-transfer-encoding
:content-language;
bh=DdU7nW3kOIREFzTCwVwetdGStlPaDpNKdo+kuDd2UuY=;
b=wnv81/8a8l9ItXVIWlppsIwCg4UdWjPDy/EVRjI+uq5Kg0oNJsmuq2dOGMq0NokDt7
nTbNBGd4p3Sc0ccZibgTOUXGTqov0jAM/7eyMh8BmWgy5xFpwXM1dAHjdkiJkvJdevbO
f+wIZZ4Ptsx1d9nYdVgHhwcNjG7sB4Qav7BOqlzAL3aNlqxUZ2MQqQg2eaGqhu7hasZX
3KqXt3mLi5Ba8iQBab1E+mOfzKWof/J3mgEudVsuwaaJ8qSUD2YT/oksa8N3Um5EIn2G
Cy8Hui6y2JMeIo4O3RwZThIJwbETBnaauDw7CByYh3dCQcI8IyEIoMf8QY17XsMrHOWF
1yCg==
X-Gm-Message-State: AOAM530sYiPz6IwkCWcef9jjz9kkI96ynOreRQgvd0lpuPv2EzxzRqv6
C70y6Tk6X90OAfEiyFwHnCmElavUoM6CTKMKDPiEyD1FszSZuc5ibhHGmYZBfD3U20wPnb9yrsw
Li1I=
X-Received: by 2002:ac8:4744:: with SMTP id k4mr5245739qtp.247.1631450544216;
Sun, 12 Sep 2021 05:42:24 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJw95qfcJWoCOInNqP0uCUqrqjPWS/7NqNvVukVKy6wwfsZQLtK0t2d+3+xmOwDxWbSwVeHXJg==
X-Received: by 2002:ac8:4744:: with SMTP id k4mr5245724qtp.247.1631450544036;
Sun, 12 Sep 2021 05:42:24 -0700 (PDT)
Received: from localhost.localdomain (075-142-250-213.res.spectrum.com.
[75.142.250.213])
by smtp.gmail.com with ESMTPSA id c20sm3053662qkk.121.2021.09.12.05.42.22
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Sun, 12 Sep 2021 05:42:23 -0700 (PDT)
To: Nicolas Chautru <nicolas.chautru@intel.com>, dev@dpdk.org,
gakhil@marvell.com
Cc: thomas@monjalon.net, hemant.agrawal@nxp.com, mingshan.zhang@intel.com,
arun.joshi@intel.com
References: <1631063741-28631-1-git-send-email-nicolas.chautru@intel.com>
<1631063741-28631-5-git-send-email-nicolas.chautru@intel.com>
From: Tom Rix <trix@redhat.com>
Message-ID: <18ecbcc0-6aaa-3d52-e6bb-5bedf2755155@redhat.com>
Date: Sun, 12 Sep 2021 05:42:21 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <1631063741-28631-5-git-send-email-nicolas.chautru@intel.com>
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v3 4/6] baseband/acc100: add support for 4G
CRC drop
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 9/7/21 6:15 PM, Nicolas Chautru wrote:
> This implements in PMD the option to drop the CB CRC
> after 4G decoding to help transport block concatenation.
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
> doc/guides/bbdevs/acc100.rst | 1 +
> doc/guides/rel_notes/release_21_11.rst | 4 ++++
> drivers/baseband/acc100/rte_acc100_pmd.c | 12 +++++++++---
> 3 files changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/doc/guides/bbdevs/acc100.rst b/doc/guides/bbdevs/acc100.rst
> index ff0fa4b..9fff6ab 100644
> --- a/doc/guides/bbdevs/acc100.rst
> +++ b/doc/guides/bbdevs/acc100.rst
> @@ -58,6 +58,7 @@ ACC100 5G/4G FEC PMD supports the following BBDEV capabilities:
> - ``RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN`` : set if negative LLR encoder i/p is supported
> - ``RTE_BBDEV_TURBO_POS_LLR_1_BIT_IN`` : set if positive LLR encoder i/p is supported
> - ``RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP`` : keep CRC24B bits appended while decoding
> + - ``RTE_BBDEV_TURBO_DEC_CRC_24B_DROP`` : option to drop the code block CRC after decoding
> - ``RTE_BBDEV_TURBO_EARLY_TERMINATION`` : set early termination feature
> - ``RTE_BBDEV_TURBO_DEC_SCATTER_GATHER`` : supports scatter-gather for input/output data
> - ``RTE_BBDEV_TURBO_HALF_ITERATION_EVEN`` : set half iteration granularity
> diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst
> index 8ca59b7..f7843bc 100644
> --- a/doc/guides/rel_notes/release_21_11.rst
> +++ b/doc/guides/rel_notes/release_21_11.rst
> @@ -59,6 +59,10 @@ New Features
>
> Added support for more comprehensive CRC options.
>
> +* **Updated the ACC100 bbdev PMD.**
> +
> + Added support for more comprehensive CRC options.
> +
> Removed Items
> -------------
>
> diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
> index 68ba523..2e9ce92 100644
> --- a/drivers/baseband/acc100/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc100/rte_acc100_pmd.c
> @@ -980,6 +980,7 @@
> RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN |
> RTE_BBDEV_TURBO_MAP_DEC |
> RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP |
> + RTE_BBDEV_TURBO_DEC_CRC_24B_DROP |
> RTE_BBDEV_TURBO_DEC_SCATTER_GATHER,
> .max_llr_modulus = INT8_MAX,
> .num_buffers_src =
> @@ -1708,8 +1709,12 @@
> }
>
> if ((op->turbo_dec.code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK)
> - && !check_bit(op->turbo_dec.op_flags,
> - RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP))
> + && !check_bit(op->turbo_dec.op_flags,
> + RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP))
> + crc24_overlap = 24;
> + if ((op->turbo_dec.code_block_mode == RTE_BBDEV_CODE_BLOCK)
> + && check_bit(op->turbo_dec.op_flags,
> + RTE_BBDEV_TURBO_DEC_CRC_24B_DROP))
> crc24_overlap = 24;
ok if this isn't combined.
the bug moved to its own patch.
Looks good.
Reviewed-by: Tom Rix <trix@redhat.com>
>
> /* Calculates circular buffer size.
> @@ -1744,7 +1749,8 @@
>
> next_triplet = acc100_dma_fill_blk_type_out(
> desc, h_output, *h_out_offset,
> - k >> 3, next_triplet, ACC100_DMA_BLKID_OUT_HARD);
> + k >> 3, next_triplet,
> + ACC100_DMA_BLKID_OUT_HARD);
> if (unlikely(next_triplet < 0)) {
> rte_bbdev_log(ERR,
> "Mismatch between data to process and mbuf data length in bbdev_op: %p",