From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Andrew Boyer <andrew.boyer@amd.com>, dev@dpdk.org
Cc: Neel Patel <neel.patel@amd.com>,
R Mohamed Shah <mohamedshah.r@amd.com>,
Alfredo Cardigliano <cardigliano@ntop.org>
Subject: Re: [PATCH 3/3] net/ionic: add vdev support for embedded applications
Date: Mon, 19 Feb 2024 15:24:10 +0000 [thread overview]
Message-ID: <18ed6352-d693-4848-80f9-1665f5ef744a@amd.com> (raw)
In-Reply-To: <20240216170704.55523-4-andrew.boyer@amd.com>
On 2/16/2024 5:07 PM, Andrew Boyer wrote:
> Add support for running DPDK applications directly on AMD Pensando
> embedded HW. The platform exposes the device BARs through UIO. The
> UIO code in the common/ionic library walks the sysfs filesystem
> to identify the relevant BARs and map them into process memory.
>
> The SoCs are named 'Capri' and 'Elba'.
>
> The vdev device interface code is located in ionic_dev_vdev.c.
>
> Some datapath operations are #ifdef-ed out to save on resources when
> running in embedded mode.
>
> Some controlpath operations are skipped by the ionic_is_embedded()
> helper function.
>
> Before ringing the doorbell, use an ARM 'dsb st' barrier. The normal
> barrier inside rte_write64() is insufficient on these devices due to
> a chip errata.
>
> Signed-off-by: Andrew Boyer <andrew.boyer@amd.com>
> Signed-off-by: Neel Patel <neel.patel@amd.com>
> Signed-off-by: R Mohamed Shah <mohamedshah.r@amd.com>
> Signed-off-by: Alfredo Cardigliano <cardigliano@ntop.org>
<...>
> +static struct rte_vdev_driver rte_vdev_ionic_pmd = {
> + .probe = eth_ionic_vdev_probe,
> + .remove = eth_ionic_vdev_remove,
> +};
> +
> +RTE_PMD_REGISTER_VDEV(net_ionic, rte_vdev_ionic_pmd);
> +
> +static void
> +vdev_ionic_scan_cb(__rte_unused void *arg)
> +{
> + ionic_uio_scan_mnet_devices();
> +}
> +
> +RTE_INIT(vdev_ionic_custom_add)
> +{
> + rte_vdev_add_custom_scan(vdev_ionic_scan_cb, NULL);
> +}
Hi Andrew,
My understanding is 'rte_vdev_add_custom_scan()' to add a vdev
automatically (via rte_devargs_add()) before vdev scan starts.
As far as I can see you are not doing this, why callback is added?
Why not call 'ionic_uio_scan_mnet_devices()' within the
'eth_ionic_vdev_probe()'?
next prev parent reply other threads:[~2024-02-19 15:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 17:07 [PATCH 0/3] net/ionic, common/ionic: add vdev support Andrew Boyer
2024-02-16 17:07 ` [PATCH 1/3] common/ionic: create common code library for ionic Andrew Boyer
2024-02-16 17:07 ` [PATCH 2/3] net/ionic: remove duplicate barriers Andrew Boyer
2024-02-19 22:16 ` Wathsala Wathawana Vithanage
2024-02-20 2:02 ` Wathsala Wathawana Vithanage
2024-02-20 18:31 ` Boyer, Andrew
2024-02-16 17:07 ` [PATCH 3/3] net/ionic: add vdev support for embedded applications Andrew Boyer
2024-02-19 15:24 ` Ferruh Yigit [this message]
2024-02-19 22:02 ` Boyer, Andrew
2024-02-20 2:02 ` Honnappa Nagarahalli
2024-02-21 1:16 ` Boyer, Andrew
2024-02-20 8:28 ` Ferruh Yigit
2024-02-20 14:39 ` Honnappa Nagarahalli
2024-02-16 19:39 ` [PATCH 0/3] net/ionic, common/ionic: add vdev support Ferruh Yigit
2024-02-20 20:42 ` [PATCH v2 " Andrew Boyer
2024-02-20 20:42 ` [PATCH v2 1/3] common/ionic: create common code library for ionic Andrew Boyer
2024-02-20 20:42 ` [PATCH v2 2/3] net/ionic: remove duplicate barriers Andrew Boyer
2024-02-20 20:42 ` [PATCH v2 3/3] net/ionic: add vdev support for embedded applications Andrew Boyer
2024-02-23 1:52 ` Honnappa Nagarahalli
2024-02-21 16:36 ` [PATCH v2 0/3] net/ionic, common/ionic: add vdev support Ferruh Yigit
2024-02-23 13:48 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18ed6352-d693-4848-80f9-1665f5ef744a@amd.com \
--to=ferruh.yigit@amd.com \
--cc=andrew.boyer@amd.com \
--cc=cardigliano@ntop.org \
--cc=dev@dpdk.org \
--cc=mohamedshah.r@amd.com \
--cc=neel.patel@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).