From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82C32A04AC; Tue, 1 Sep 2020 10:09:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D28DA137D; Tue, 1 Sep 2020 10:09:35 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 88276E07 for <dev@dpdk.org>; Tue, 1 Sep 2020 10:09:34 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id C9B585C0196; Tue, 1 Sep 2020 04:09:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 01 Sep 2020 04:09:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= NVNYppKgtAdpqKq3ujOWcl7CKD5zY9K7MUDu1t9neqA=; b=W7A67Qy2M3+7HcEA 8OYjuAHG7LXsYMl8tJf6AVakw/Rb/Yd2MRWI5CmMFWnav85s0+0m+v0pKem2AI48 q/K5zOx5/6oQGTlDsWsm1wS64YBDaTZIFfwmuv64MtnE5b/fO4fkUn1DmPWLpDmW /qJKlMU+zIGnjswOeWkBNlZPodHcvbWwhGpwh4SjmHmgwpsPWSHGGxnu9bwQSn0k mQivOAMAXwbicbISP9/cte5/uCkcyDcEacslyo94sxAIDF/ZHEmxBy0gQ8L/5CFp GKcVVJnvieSL1pFce2bQ9KIlrv+DhOm3tuOIZw8feev7YpnlJNFSe1iqsUZqJa9e S/71lg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=NVNYppKgtAdpqKq3ujOWcl7CKD5zY9K7MUDu1t9ne qA=; b=CAdE+CVXOp1d18TszWsWws85N4v2TL5xxxWMeSMHMh60AONip4oKJKoZV qciXg4hXjAUKsCZ7DocefYLK9Hw7ghXem70+2nkFNkRJ72PZaDq6Vt0u7wkhNcya umpT6i1gFO0cFIb0TQaP17a1MF6yCyuWqU+s+Qa01RiaMgX6TkPe8GFZJhtRXdoG 7o2EG35laIGJmKJyiqIzkR4HGs+9RK6MLbwyQw4bQqvWtGnLNJIFnoipwdwKw90C E34FVWbqT222xsYym3WqHkYLDolqEypjX4FzfsWHnyn7m+0UEdv9PUGCtngghmYr Uy+TRBbuhetqwP20nS22I84X83DuQ== X-ME-Sender: <xms:uwFOX8pGHveS4cLSlYXYEWb-y3xrZlctIRb__q6FZ3nkJYic9mNMIw> <xme:uwFOXyq8qyFd2qssgJuiCNOW4pWPBA5VaDoZtIQI5nWKG4JVjfd-jVhH7H9tlImcV -ODDdBbuBsk9_F6Ng> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudefjedgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: <xmx:vAFOXxMyRXu-Y9BEsdLsN6H9p6c8FilY7ACuPlWuHS07X6o5HWGdCg> <xmx:vAFOXz7Q2o9yHCco5oBZCqaGjmgk3MlawIvsoGuBiF52rJUwUep5YA> <xmx:vAFOX74irtC3OdZT1S52FqgsmADxQ9dZ3ukYmOIAGnZPOk8d6HlTzw> <xmx:vQFOX4vyMnoTPq65PVZNOPc4Y8Rm96b94YLvt_FPDyw6EHMGs1N4dA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0C6D63060067; Tue, 1 Sep 2020 04:09:30 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Nipun Gupta <nipun.gupta@nxp.com>, Stephen Hemminger <stephen@networkplumber.org>, orika@mellanox.com Cc: dev@dpdk.org, ferruh.yigit@intel.com, arybchenko@solarflare.com, hemant.agrawal@nxp.com, Rohit Raj <rohit.raj@nxp.com>, olivier.matz@6wind.com Date: Tue, 01 Sep 2020 10:09:29 +0200 Message-ID: <1900043.OHW9WeN1RR@thomas> In-Reply-To: <20200831100019.11e5c916@hermes.lan> References: <20200831075333.10135-1-nipun.gupta@nxp.com> <20200831100019.11e5c916@hermes.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: add rx offload to drop error packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 31/08/2020 19:00, Stephen Hemminger: > On Mon, 31 Aug 2020 13:23:33 +0530 > Nipun Gupta <nipun.gupta@nxp.com> wrote: > > > This change adds a RX offload capability where hardware can drop the > > packets in case there is an error in the packet such as L3 checksum > > error or L4 checksum. > > > > Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com> > > Signed-off-by: Rohit Raj <rohit.raj@nxp.com> > > --- > > +#define DEV_RX_OFFLOAD_ERR_PKT_DROP 0x00100000 Please add RTE_ prefix, even if older macros don't have it. We could (in a separate effort) alias old ones with RTE_ prefixed names. > Could/should this be an rte_flow action as well? I feel rte_flow API is not appropriate here. Ori, any opinion?