From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id 5F1B511C5
 for <dev@dpdk.org>; Thu,  2 Jul 2015 14:55:04 +0200 (CEST)
Received: by wgck11 with SMTP id k11so62548949wgc.0
 for <dev@dpdk.org>; Thu, 02 Jul 2015 05:55:04 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=9HctcMCxEJFJqtoZhgAYfGbpT+yW7bTeFyyOFXKLnwc=;
 b=bgfNxnMfg9AEwiNphOZfikl5cgrU6yza2JAiM8gif6pnpxILH2HsrUXdN7RudFmfUH
 hg2BdmBCfYISeWeaHqEf36ifXbdz+H8t1AEERUvs/8z12iF/nt+2KSACrAKqcl+Kbh5N
 gB8MqlZGUCC0RmwUIVWaBG6rI7RT0qhYaRhbZEHxkYNnYENPCJ57Yr9Sts9I/97Y9FRs
 ySnuQsrYlNDwLXN9b9+kXB++Sw9qIiZVoMxwQEw2FaVk++PfbXZRkUZuSnvwzHMnEuyr
 LgHzLcLo6Fpat4RQJpOUtXtEHH0UJPGMKkmunijf676ymGlE6MhONcFtVLpUT7T/X0js
 MVyA==
X-Gm-Message-State: ALoCoQmBr7a3Q+CLsTh2iCEsz4xlOUWUr2LHhG46hteiBoAad4Sbyjzc08GRLejdVtjcc/YkM9OZ
X-Received: by 10.180.36.129 with SMTP id q1mr16645451wij.10.1435841704179;
 Thu, 02 Jul 2015 05:55:04 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.151.210])
 by mx.google.com with ESMTPSA id ll7sm3009466wjc.16.2015.07.02.05.55.02
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 02 Jul 2015 05:55:03 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu, 02 Jul 2015 14:53:55 +0200
Message-ID: <1900222.tNFK0Pm7Pr@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <D1B1F14C.91D1C%harish.patil@qlogic.com>
References: <1434498700-8522-1-git-send-email-stephen@networkplumber.org>
 <D1B1F14C.91D1C%harish.patil@qlogic.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH 0/4 v5] bnx2x: poll mode driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jul 2015 12:55:04 -0000

2015-06-26 00:57, Harish Patil:
> 
> >From: Stephen Hemminger <shemming@brocade.com>
> >
> >Changes since last time:
> > 1. Support pci_config on BSD. Although since BSD probably doesn't
> >    have same filesystem  (/lib/firmware) the driver won't work.
> > 2. Change location of driver to match new filesystem hierarchy
> >
> >Stephen Hemminger (4):
> >  eal: provide functions to access PCI config
> >  bnx2x: driver core
> >  bnx2x: driver support routines
> >  bnx2x: enable PMD build
> 
> Acked-by: Harish Patil <harish.patil@qlogic.com>

There are some comments to address.
Please Stephen, could you reply to comments *and* submit a new version?

Note: in order to ease patch management, the version number (v5 here)
must be in each patch and not only cover letter.
As explained in http://dpdk.org/dev#send,
the option --subject-prefix 'PATCH v6' would help.