From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B9D0A0C4A; Wed, 7 Jul 2021 12:57:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72022406FF; Wed, 7 Jul 2021 12:57:57 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 3DC2B406B4 for ; Wed, 7 Jul 2021 12:57:56 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 79F7E3200754; Wed, 7 Jul 2021 06:57:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 07 Jul 2021 06:57:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= yGwttDMHLFi+KFErWWNoAjJxd0g2tpJ6f/D9vNYk/9g=; b=BanqMdvJe5Rj1WSg gsIUs+9hDM/qYN8KA/qIdui4WVecWSXlQzbCfgcQrAPeHLD6oPM0YBqjk3jc44rg mvZQeAU/64AxzovSoVDJ9hDdVX6lqygikp8sDcNMI0PcQSsz8UrtOdBxptDY1uYc O/7tmmNhtvM6TOzY6BgNPVM237frckSodNycOmQ0eyS7LupT1Ydo7gROm3ItyJ3v aSZnmPTYLpGry6jJEL9qD2VEMQCpNHYYj7wtZpiid0RpnRLyqHstbqQhnvmHtT+8 6PujNmGlZQAnK0hNB5ECeRyJqoCRyl/i5xkeUoP20AgstYd8yLWL1M0r15Gm/+0U 17NLXw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=yGwttDMHLFi+KFErWWNoAjJxd0g2tpJ6f/D9vNYk/ 9g=; b=alTC6knFx1E7mZXyhhCzGhVed5r9r5BpHTvuhCDO1wxnTa28xvUxfaLpN W49mq2vR3kiS1l9tfTtDIzohby8nvdxObaSbhnfofvyof/ZzqdnpHxx6D+ZPUuDI nVRmaXdHiZB7TgEYFb9wG/BTJNN84uCOtVtrEOHoXVkTMsoYnqVlyTYZcESM03gO iZIkUUjiMwn+QHCb4/L9CXu10/mHbAdSdoidlnnkdrY+rTnOJ4reLj0ya0ck1EWS RLP4QFRJexfSROIWItBo8MWKS6BuBlVe6Br18IIoCCOehDccU27L13a/ic6cA552 9ktn1ySSle3EXpNI4rZ63uf+Q1W9g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrtddvgdeffecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdduvdehhfetvedtuefftdeludeuhfefueejheetgeevveeiffdv tdffteeuvdenucffohhmrghinhepshhouhhrtggvfigrrhgvrdhorhhgnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhn jhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Jul 2021 06:57:51 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: Andrew Rybchenko , Dodji Seketeli , Huisong Li , dev , "Yigit, Ferruh" , "Ananyev, Konstantin" , Ray Kinsella Date: Wed, 07 Jul 2021 12:57:48 +0200 Message-ID: <1901125.4uf4Ga7oMq@thomas> In-Reply-To: References: <1620460836-38506-1-git-send-email-lihuisong@huawei.com> <25012025.yGfkWu0M9X@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/07/2021 12:40, David Marchand: > On Wed, Jul 7, 2021 at 11:59 AM Thomas Monjalon wrote: > > > This is problematic, as the following rule does not work: > > > > > > +; Ignore bitfields added in rte_eth_dev_data hole > > > +[suppress_type] > > > + name = rte_eth_dev_data > > > + has_data_member_inserted_between = {offset_after(lro), > > > offset_of(rx_queue_state)} > > > > > > On the other hand, a (wrong) rule with "has_data_member_inserted_at = > > > 2" (2 being the wrong offset you can read in abidiff output) works. > > > > > > This might force us to waive all changes to rte_eth_dev_data... not > > > that I am happy about it. > > > > We are not going to do other changes until 21.11, so it could be fine. > > Ok, example of a global exception for the structure: > > +; Ignore all changes to rte_eth_dev_data > +; Note: we only cared about dev_configured bit addition, but libabigail > +; seems to wrongly compute bitfields offset. > +; https://sourceware.org/bugzilla/show_bug.cgi?id=28060 > +[suppress_type] > + name = rte_eth_dev_data OK for me. Thanks for managing this issue.