From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id BFC43A0471
for <public@inbox.dpdk.org>; Fri, 19 Jul 2019 00:25:35 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id AA5682BA8;
Fri, 19 Jul 2019 00:25:33 +0200 (CEST)
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
[64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 9EC0B1DBF;
Fri, 19 Jul 2019 00:25:31 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.west.internal (Postfix) with ESMTP id 72FBB3D0;
Thu, 18 Jul 2019 18:25:30 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Thu, 18 Jul 2019 18:25:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=B0AVpK/5SttsPpe5sEuxeb4vqILvO4fq+lqoystAgvA=; b=Mt+A7QHgFFD3
ZhtFLFLu+jlYTHTaluEQTuZrOioA0hFC+Z/cIMUwKUE9b7UiaNDGdRyGveiJ52ME
s7crjj6f9Lo3pybskakgj8wxUvU0Ieemd0BGlVGssqeuyvcBAtYpx+KmeX2/LRAl
N6s3ENz7FwKoX6PQeeIpuVcQmeOLic4=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm3; bh=B0AVpK/5SttsPpe5sEuxeb4vqILvO4fq+lqoystAg
vA=; b=Kb35qz8xvOFFQPfBfzzsaYpiZ0LIiG78+pOPlGmc/vBWUqqz82gd8SZ1U
RYHCv5Q+xU0vn4fO6cjHtkc72clIwEsMptEMrdqpeW5HQTxtLIT8bsBFKjB6Bshk
PkEiJbE4EkMr1xf6sKmFFDL7Hkfe5WW2es3y7RJVN9nhLC6KdQ2gtdfnAMj2pyGf
wYAQ8t5a0Pob8W9sRzgzo/Wj9R228d/ImOTZKdMUvyyL0h1BLE05ffBkEz7lfRuY
n9EJ3OQUnL7utIsqgI1ErJV65tKcMGMpOIDd7Cg4iqY8VSZH+I19Q7aDe3uRiOm8
NQWvDm5+aAbzdP4kDYdjyqBvODVcQ==
X-ME-Sender: <xms:2fEwXeocBKk3TC45D98MZCKxB7p-Tbmr1JndtYHDuTnZpbDJ6Dsqtw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrieeigddutdcutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph
epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho
mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:2fEwXd5sIDozMe7EhOedwhAbPmXJdi5Sx_7WquZMU9x-mu1QjQ1Syg>
<xmx:2fEwXcEhaf9CQorRbQQLA4zDFCL-Y1Z7-iSIeZQzCMx21WxZwEaEkw>
<xmx:2fEwXU6vvZTWRE30DehhzIy2srOs-XOU6R8bB7gW6nXlti_Nbiwu8A>
<xmx:2vEwXUVc81sSOyj6X8jrq52lrf4FAJPccEfhet3aAHXYG6tZuel0Kg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 135B9380075;
Thu, 18 Jul 2019 18:25:28 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, bruce.richardson@intel.com
Date: Fri, 19 Jul 2019 00:25:28 +0200
Message-ID: <1901807.fy38742gHy@xps>
In-Reply-To: <20190718140330.43109-1-herakliusz.lipiec@intel.com>
References: <20190718132912.28250-1-herakliusz.lipiec@intel.com>
<20190718140330.43109-1-herakliusz.lipiec@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] mk: fix output directory name when compiling
with custom kernel header dir
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
18/07/2019 16:03, Herakliusz Lipiec:
> When building dpdk with differnt kernel headers by specifying
> RTE_KERNELDIR igb_uio is compiled to directory with a name of the
> version of kernel thats running on the system instead of the one that
> dpdk is actually compiled against. Fixed by replacing hardcoded value
> with value from RTE_KERNELDIR.
missing original commit reference:
Fixes: 3967af352aeb ("mk: install kernel modules")
> Cc: stable@dpdk.org
> Cc: bruce.richardson@intel.com
> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
>
> ---
> resending v1 with corrected cc address for stable and corrected
> alignment.
It should be marked v2,
and the alignment is still not correct.
> -kerneldir ?= /lib/modules/$(shell uname -r)/extra/dpdk
> +kerneldir ?= $(subst /build,/extra/dpdk,$(RTE_KERNELDIR))
I would suggest another syntax, easier to read:
kerneldir ?= $(RTE_KERNELDIR:/build=/extra/dpdk)