From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 77C87A51 for ; Sat, 14 Jul 2018 16:54:14 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0B9A321AB4; Sat, 14 Jul 2018 10:54:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 14 Jul 2018 10:54:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=NrfCWx1nlyT4UhVtjWTod4INiA btQ0FPeHmZVsEN4Mc=; b=aqlwg53oQwfqeSlRkbQ+5JWaG/9SlZBz3Aio+mE3TL 5gdqsY2yAIghK4xicYBJKm1xlM8itQNSWSMLF2HqkcJXsGxYY1nNiYy27MoNaL3Z kxxcB5caQ/xIKAbBDO4MtII3Pv9WBtf9xibF8boQtYBEPzBMyBd7vE+YpFTLhn+Z 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=NrfCWx 1nlyT4UhVtjWTod4INiAbtQ0FPeHmZVsEN4Mc=; b=X4WdDFz6Utru91AVeT2X8Z Y4g4xo6YpFY3TmT5YmMyqYxjieb4YbuMGOSvU454dfvRIstEzfyndfx79gPnAIZP eU4xk5rJCv5ObNaieQH2V4RPj24q/DaVJhBvJIIwUfxFWC1DW4Dq6DnCSh7+dsb1 HgI+r6gCFG27mGB2jg+x119UsPfwNcjt+jm5a94IGM5s6LtQ2J5f3RRsDO+5G/3p pFn63Im4/XUpRfDB7t2yTLtQcIaztfh2ZJhGHmo6DbUDx6x7Ck279oOifAr4gDDs J0qMQejp2t3xuu6Ji8GetFUCkFhArpAKzGgWkYWzQJ1l7R7fJs0KB/v/lu6YOGLg == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (unknown [37.170.15.252]) by mail.messagingengine.com (Postfix) with ESMTPA id ED9781025C; Sat, 14 Jul 2018 10:54:12 -0400 (EDT) From: Thomas Monjalon To: Gaetan Rivet Cc: dev@dpdk.org Date: Sat, 14 Jul 2018 12:30:52 +0200 Message-ID: <1903340.jiKkXg6Dl2@xps> In-Reply-To: <31ece7bda6ce4809dd5a6941a4f47176996b7321.1531345404.git.gaetan.rivet@6wind.com> References: <31ece7bda6ce4809dd5a6941a4f47176996b7321.1531345404.git.gaetan.rivet@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v11 08/25] devargs: add function to parse device layers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jul 2018 14:54:15 -0000 11/07/2018 23:44, Gaetan Rivet: > This function is private to the EAL. > It is used to parse each layers in a device description string, > and store the result in an rte_devargs structure. > > Signed-off-by: Gaetan Rivet There is a compilation issue. It makes EAL depends on kvargs. This change is required (to be squashed): --- a/lib/librte_eal/bsdapp/eal/Makefile +++ b/lib/librte_eal/bsdapp/eal/Makefile @@ -18,6 +18,7 @@ CFLAGS += $(WERROR_FLAGS) -O3 LDLIBS += -lexecinfo LDLIBS += -lpthread LDLIBS += -lgcc_s +LDLIBS += -lrte_kvargs EXPORT_MAP := ../../rte_eal_version.map --- a/lib/librte_eal/bsdapp/eal/meson.build +++ b/lib/librte_eal/bsdapp/eal/meson.build @@ -16,3 +16,5 @@ env_sources = files('eal_alarm.c', 'eal_memory.c', 'eal_dev.c' ) + +deps += ['kvargs'] --- a/lib/librte_eal/linuxapp/eal/Makefile +++ b/lib/librte_eal/linuxapp/eal/Makefile @@ -24,6 +24,7 @@ LDLIBS += -ldl LDLIBS += -lpthread LDLIBS += -lgcc_s LDLIBS += -lrt +LDLIBS += -lrte_kvargs ifeq ($(CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES),y) LDLIBS += -lnuma endif --- a/lib/librte_eal/linuxapp/eal/meson.build +++ b/lib/librte_eal/linuxapp/eal/meson.build @@ -23,6 +23,7 @@ env_sources = files('eal_alarm.c', 'eal_dev.c', ) +deps += ['kvargs'] if has_libnuma == 1 dpdk_conf.set10('RTE_EAL_NUMA_AWARE_HUGEPAGES', true) endif