DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Li Zhang <lizh@nvidia.com>
Cc: Ori Kam <orika@nvidia.com>,
	Slava Ovsiienko <viacheslavo@nvidia.com>,
	Matan Azrad <matan@nvidia.com>,
	"cristian.dumitrescu@intel.com" <cristian.dumitrescu@intel.com>,
	"lironh@marvell.com" <lironh@marvell.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Raslan Darawsheh <rasland@nvidia.com>,
	Roni Bar Yanai <roniba@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH 0/2] Check meter packet mode in PMD
Date: Thu, 01 Apr 2021 09:04:52 +0200	[thread overview]
Message-ID: <19061351.hDx7hfoL4V@thomas> (raw)
In-Reply-To: <DM6PR12MB4090471B43321BB7D6F65BCDBF7B9@DM6PR12MB4090.namprd12.prod.outlook.com>

01/04/2021 08:52, Li Zhang:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 01/04/2021 08:16, Li Zhang:
> > > Currently meter algorithms only supports rate is bytes per second(BPS).
> > > Add packet_mode flag in meter profile parameters data structure in RTE.
> > 
> > What means RTE?
> > I see no flag added in these patches.
> 
> It is RTE API, which added by another patch as below:
> Depends-on: series=16002  ("Support PPS(packet per second) on meter")
> https://patchwork.dpdk.org/project/dpdk/patch/20210331085405.1445546-2-lizh@nvidia.com/

Please do not say RTE API, it is meaningless.
Better to give the exact name of the structure,
or at least the name of the library.

Also your sentence means this patchset is adding a flag but it is not.
It's very confusing.

> > > Add the necessary checks to the existing drivers implementing the
> > > rte_mtr API to makes sure that profiles with packet_mode set to TRUE
> > > are rejected.
> > >
> > > Depends-on: series=16002  ("Support PPS(packet per second) on meter")
> > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> > >
> > hwork.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D16002&amp;dat
> > a=04
> > > %7C01%7Clizh%40nvidia.com%7C6fc22a58772641cbf72608d8f4d7bf75%7C4
> > 3083d1
> > >
> > 5727340c1b7db39efd9ccc17a%7C0%7C0%7C637528554762610316%7CUnkno
> > wn%7CTWF
> > >
> > pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC
> > I6M
> > >
> > n0%3D%7C1000&amp;sdata=VZ88lQoAZK3z7MODRycvja4YvpEcjC4apoZZy4p1
> > ZP4%3D&
> > > amp;reserved=0
> > 
> > It seems these patches should be part of the above patchset.
> > 
> > > Li Zhang (2):
> > >   net/softnic: check meter packet mode
> > >   net/mvpp2: check meter packet mode




  reply	other threads:[~2021-04-01  7:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01  6:16 Li Zhang
2021-04-01  6:16 ` [dpdk-dev] [PATCH 1/2] net/softnic: check meter packet mode Li Zhang
2021-04-07 20:13   ` Dumitrescu, Cristian
2021-04-08  2:31     ` Li Zhang
2021-04-01  6:16 ` [dpdk-dev] [PATCH 2/2] net/mvpp2: " Li Zhang
2021-04-07 20:13   ` Dumitrescu, Cristian
2021-04-08  2:32     ` Li Zhang
2021-04-01  6:31 ` [dpdk-dev] [PATCH 0/2] Check meter packet mode in PMD Thomas Monjalon
2021-04-01  6:52   ` Li Zhang
2021-04-01  7:04     ` Thomas Monjalon [this message]
2021-04-01  7:37       ` Li Zhang
2021-04-01  7:44         ` Thomas Monjalon
2021-04-01  8:50           ` Li Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19061351.hDx7hfoL4V@thomas \
    --to=thomas@monjalon.net \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=lironh@marvell.com \
    --cc=lizh@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=roniba@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).