From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7D54A034F; Thu, 1 Apr 2021 09:04:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84E0A40142; Thu, 1 Apr 2021 09:04:57 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 35D264013F for ; Thu, 1 Apr 2021 09:04:56 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id BBEC75C012B; Thu, 1 Apr 2021 03:04:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 01 Apr 2021 03:04:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= jq8xBWeeZ6cwuddMZu8DVmAM3j/jK3c/53Nd7d5Vj7A=; b=SpnrkyOwLZEPgYTK mJi6/7f1UCu2pMFyzmredM/UmEJ//PNJ9k09y0N/cZXDk7WWyy4y67ELh6his2Yb e+Et0rS6LFmiKfSJjaumtJoU8pgbBkl4C5uJ7TtMGYBMP++W7+Zwf3KUjD8CdXbG unDlvxA8cZ0cL9bXzkcExRcfW2VcszEsUXGStswXnDroiBpjgcMhCqsI9ncJuBWB 8NJyc4UDMevz5Oj7cV6DVOIRZFE6zCkwv4CVztct8+p5wZqE3aAGz2Yb3hm5E535 fK0JuVbV+eUHfzBb5QLaaku4BgJBQ9qYn84EdK9f9Af1Q814bL94G/7qZ7WZHOEz 480wmQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=jq8xBWeeZ6cwuddMZu8DVmAM3j/jK3c/53Nd7d5Vj 7A=; b=bAf7D+k+rIYrkysQ8EyLyXi6zDda4iY+r06QluQqPRsg94m4FgSbeYWFn iTCM6pctldcvaSHa8/AaQVdMrA3/02CXX/dFzHUOot+KPW/9Ce0gM1LZyh6WTroH qoGqkwfZ3PDsVkb4Vo+gDLS6pew/rLbWnw7Z+zCeGZ16lwl4vORdU0WXoafFrH4F q0ehqxEtUdafFF+r+f7OmE++ypmhcYFVZadfgNBAP95imZ/ojxG/vMvBBWz+TSil /GzCmhwv4VwmXmmuHZ++bveYCu6vmQ1N5bd1glzt6zdtP5vGkgaAwTdC7nIiRLPK 1119Jr3inKgJ55dCssaAtztWUcdpg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeifedguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejieejleegudevieeguefggeduteelheekleejffekvdefvddv jeduledtkeeigeenucffohhmrghinhepughpughkrdhorhhgpdhouhhtlhhoohhkrdgtoh hmnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvg ht X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4F1F51080068; Thu, 1 Apr 2021 03:04:54 -0400 (EDT) From: Thomas Monjalon To: Li Zhang Cc: Ori Kam , Slava Ovsiienko , Matan Azrad , "cristian.dumitrescu@intel.com" , "lironh@marvell.com" , "dev@dpdk.org" , Raslan Darawsheh , Roni Bar Yanai Date: Thu, 01 Apr 2021 09:04:52 +0200 Message-ID: <19061351.hDx7hfoL4V@thomas> In-Reply-To: References: <20210401061618.1478961-1-lizh@nvidia.com> <40266646.2hgBqQEIht@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/2] Check meter packet mode in PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/04/2021 08:52, Li Zhang: > From: Thomas Monjalon > > 01/04/2021 08:16, Li Zhang: > > > Currently meter algorithms only supports rate is bytes per second(BPS). > > > Add packet_mode flag in meter profile parameters data structure in RTE. > > > > What means RTE? > > I see no flag added in these patches. > > It is RTE API, which added by another patch as below: > Depends-on: series=16002 ("Support PPS(packet per second) on meter") > https://patchwork.dpdk.org/project/dpdk/patch/20210331085405.1445546-2-lizh@nvidia.com/ Please do not say RTE API, it is meaningless. Better to give the exact name of the structure, or at least the name of the library. Also your sentence means this patchset is adding a flag but it is not. It's very confusing. > > > Add the necessary checks to the existing drivers implementing the > > > rte_mtr API to makes sure that profiles with packet_mode set to TRUE > > > are rejected. > > > > > > Depends-on: series=16002 ("Support PPS(packet per second) on meter") > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc > > > > > hwork.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D16002&dat > > a=04 > > > %7C01%7Clizh%40nvidia.com%7C6fc22a58772641cbf72608d8f4d7bf75%7C4 > > 3083d1 > > > > > 5727340c1b7db39efd9ccc17a%7C0%7C0%7C637528554762610316%7CUnkno > > wn%7CTWF > > > > > pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC > > I6M > > > > > n0%3D%7C1000&sdata=VZ88lQoAZK3z7MODRycvja4YvpEcjC4apoZZy4p1 > > ZP4%3D& > > > amp;reserved=0 > > > > It seems these patches should be part of the above patchset. > > > > > Li Zhang (2): > > > net/softnic: check meter packet mode > > > net/mvpp2: check meter packet mode