From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA08C41FD1; Wed, 30 Aug 2023 18:27:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81A7D4027F; Wed, 30 Aug 2023 18:27:50 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 014804027B for ; Wed, 30 Aug 2023 18:27:49 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 5E4E032008FF; Wed, 30 Aug 2023 12:27:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 30 Aug 2023 12:27:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1693412866; x=1693499266; bh=7G4TwXp6zo/yd5mM0AN79Lj6goreyxh1dcj LQ3qFxyE=; b=YDqi1sG7fWazmPy8M3Q2cd/FfZ6zG3RvKiL3iU1/dX7KuI9gOH6 t6hStdsFI6p2bsRB5yJsrNfIBljQPPARpysaObS5BHfh+HJMoe2cijpzEyQ2XMjC zq7BCrm8wyvzq1UkYL0hb4B3UnnxojAwhEfG7NJMZRmzcdPiMgwOqa4UxkXUkPL7 HVhaAX0iYfdbgIyg+gVBItCCGu8Ucn3rZUBZw68CTrIhjV8RPkSb10zUO6RhHBlS ZQ2QoiGcyFf9clumm9RHEaYxWlfI8QbkQc1MXvnPUuYGkAEpeY0jTO3UWrberDbJ t07CKwegyhFuYIl0ES+3U8UCpHEZz7HxEag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1693412866; x=1693499266; bh=7G4TwXp6zo/yd5mM0AN79Lj6goreyxh1dcj LQ3qFxyE=; b=ipQlxcJPXqr4ViegKOb5188xKEaYWtTuAtkYKet1r2TcPJvYzah l9Ot1Yu6+24jJzlGG6JTz0UWj8hi+XJ3keoCc0ogfIZNlR0w2KNRzE2Dr6LthyTY 4cBFkHTWS1ozDvy35zxRnzf119uhAFh3Pjm1f6zHLPutZ8OMqwSNQunIdGNCLuJC eaqFpD0BR4W0tpS9bMORdoN1va1fvbuhsbSW6kBlfPMnPe6L65EVTqPEdquv/ZlJ BGpiqPxP/grlpcGFqpduPjnxJdJoLb5GZfASFXDf+grw49bSSeoA7C8+2RK+obEs +OpxUjp4TMGvvYZDqcOssKCDnsEMxcOyX1A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudefkedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkjghfggfgtgesth furedttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgr shesmhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedtjeeiieefhedtff fgvdelteeufeefheeujefgueetfedttdeikefgkeduhedtgfenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghloh hnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Aug 2023 12:27:45 -0400 (EDT) From: Thomas Monjalon To: 11 , yaojun@mucse.com Cc: dev@dpdk.org, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru Subject: Re: [PATCH v5 1/8] net/rnp: add skeleton Date: Wed, 30 Aug 2023 18:27:43 +0200 Message-ID: <1906580.taCxCBeP46@thomas> In-Reply-To: <5BDBD6571B89977B+005b01d9d412$6d346370$479d2a50$@mucse.com> References: <20230807021615.3663034-1-caowenbo@mucse.com> <2763426.X9hSmTKtgW@thomas> <5BDBD6571B89977B+005b01d9d412$6d346370$479d2a50$@mucse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 21/08/2023 11:32, 11: > Hi Thomas, > > Thanks for your useful advice, previously only focused on code format > and Ignored document format. no worries > > > +#. Running testpmd: > > > + > > > + Follow instructions available in the document > > > + :ref:`compiling and testing a PMD for a NIC ` > > > + to run testpmd. > > > > Do we really need that referencing the same document as above? > For this block, there's really no need to add this. > Previous ideas I want to add new content as the subsequent code is > submitted. > Do I need to add full features and NIC Description at the first code commit > ? The best is to introduce doc when code is added, in the same patch. So no full features in the first patch :)