From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 7E2A81CF60
 for <dev@dpdk.org>; Sun, 13 May 2018 16:56:21 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id E8E5A257B0;
 Sun, 13 May 2018 10:56:20 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Sun, 13 May 2018 10:56:20 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=On07vy5PuNpibCCOCA5gZ/pWxz
 hSB9wFXu1/HfmvF+Q=; b=UGLW0hjB7gqBpgKj3U02ls1l6vSCM6cje3NdX65z4J
 SaKXxY7oc0j3B7TMbZqjjR4DiiuKXgkJTLEmXOY4JPlT8rKpquA26L3JZ31cwrGC
 pUE9cnhJawENmf4IZQXVnajCFIjQ7LWy3dVC7X4c4DLfeb1qEP89E1uFbPqjgIFy
 M=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=On07vy
 5PuNpibCCOCA5gZ/pWxzhSB9wFXu1/HfmvF+Q=; b=mCLJSJ7DZEyaJJ2CjUeFPh
 8t7oKUcfU4iAicOMZV0wzZmh63h9h4ql6sIhPdCNg+2gx7UBGFJMOHS6899i88Va
 IoJRjBG+/AH/ow8LA0Io9MQsXNOZvgiu5h4PkoTuQ3MyNqUrxH3pt2/WYrfZNiTa
 wNktbFkpZZESvUCXAcDHwlIRLC+MS5xRy40h/pnMBRVTsa9WSusf7CerNG9iJf7f
 5AaVOHx8slLybJ9IQ45wMt1tOJo5/POoFASgiBI0aIYn0Z4RqnRkGAD054ooEyox
 t3Q9EQJiRRm34u/qWAaIcc+vz0r2qpgVOoW1/hzh7Sarv/H7mW0LF1iehXMfdZQw
 ==
X-ME-Sender: <xms:FFL4WiNmyh8PH-ygqnoIgiMe3EmBRDMRGpOBEppjmD0HS8uMzCIHLg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 5B2BBE4365;
 Sun, 13 May 2018 10:56:20 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Andy Green <andy@warmcat.com>
Cc: dev@dpdk.org
Date: Sun, 13 May 2018 16:56:19 +0200
Message-ID: <1908372.FHAYcbrlyj@xps>
In-Reply-To: <152609032721.121661.6937845392817292798.stgit@localhost.localdomain>
References: <152609021699.121661.5295227351721865436.stgit@localhost.localdomain>
 <152609032721.121661.6937845392817292798.stgit@localhost.localdomain>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3 01/24] lib/librte_eal: import libbsd
	strlcpy
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 13 May 2018 14:56:21 -0000

Hi,

12/05/2018 03:58, Andy Green:
> Signed-off-by: Andy Green <andy@warmcat.com>

Why do we need to replace rte_strlcpy fallback?
GCC 8 complains about the fallback using snprintf?


> +/*
> + * Copyright (c) 1998 Todd C. Miller <Todd.Miller@courtesan.com>
> + *
> + * Permission to use, copy, modify, and distribute this software for any
> + * purpose with or without fee is hereby granted, provided that the above
> + * copyright notice and this permission notice appear in all copies.
> + */
> +
> +size_t
> +rte_strlcpy(char *dst, const char *src, size_t siz)
> +{
[...]
> +}

I would like to be sure there is no legal issue with this imported code.


[...]
> -static inline size_t
> -rte_strlcpy(char *dst, const char *src, size_t size)
> -{
> -	return snprintf(dst, size, "%s", src);
> -}
> +size_t
> +rte_strlcpy(char *dst, const char *src, size_t size);